Skip to content

Commit ae8ff72

Browse files
committed
Some minor improvements
1 parent a71ae35 commit ae8ff72

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

src/main/java/com/rampatra/linkedlists/DetectLoop.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static <E extends Comparable<E>> boolean isLoopPresentUsingHashMap(Single
5555
HashMap<SingleLinkedNode<E>, Boolean> map = new HashMap<>();
5656
SingleLinkedNode<E> curr = node;
5757
while (curr != null) {
58-
if (map.get(curr) != null && map.get(curr) == true) {
58+
if (map.get(curr) != null && map.get(curr)) {
5959
return true;
6060
}
6161
map.put(curr, true);
@@ -66,12 +66,12 @@ public static <E extends Comparable<E>> boolean isLoopPresentUsingHashMap(Single
6666

6767
public static void main(String a[]) {
6868
SingleLinkedList<Integer> linkedList = new SingleLinkedList<>();
69-
linkedList.add(00);
70-
linkedList.add(11);
71-
linkedList.add(22);
72-
linkedList.add(33);
73-
linkedList.add(44);
74-
linkedList.add(55);
69+
linkedList.add(0);
70+
linkedList.add(1);
71+
linkedList.add(2);
72+
linkedList.add(3);
73+
linkedList.add(4);
74+
linkedList.add(5);
7575
linkedList.getNode(4).next = linkedList.getNode(3);
7676
System.out.println(isLoopPresent(linkedList));
7777
}

src/main/java/com/rampatra/linkedlists/ReverseLinkedListInGroups.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,26 +43,26 @@ public static <E extends Comparable<E>> SingleLinkedNode<E> reverseLinkedListInG
4343

4444
// recursively call for the rest of the nodes in the linked list
4545
if (next != null) {
46-
node.next = reverseLinkedListInGroups(next, k);
46+
node.next = reverseLinkedListInGroups(curr, k);
4747
}
4848

4949
return prev;
5050
}
5151

5252
public static void main(String a[]) {
5353
SingleLinkedList<Integer> linkedList = new SingleLinkedList<>();
54-
linkedList.add(00);
55-
linkedList.add(11);
56-
linkedList.add(22);
57-
linkedList.add(33);
58-
linkedList.add(44);
59-
linkedList.add(55);
60-
linkedList.add(66);
61-
linkedList.add(77);
62-
linkedList.add(88);
63-
linkedList.add(99);
64-
linkedList.add(100);
54+
linkedList.add(0);
55+
linkedList.add(1);
56+
linkedList.add(2);
57+
linkedList.add(3);
58+
linkedList.add(4);
59+
linkedList.add(5);
60+
linkedList.add(6);
61+
linkedList.add(7);
62+
linkedList.add(8);
63+
linkedList.add(9);
64+
linkedList.add(10);
6565
linkedList.printList();
66-
linkedList.printList(reverseLinkedListInGroups(linkedList.head, 3));
66+
SingleLinkedList.printList(reverseLinkedListInGroups(linkedList.head, 3));
6767
}
6868
}

0 commit comments

Comments
 (0)