Skip to content

Applying fixes doesn't do anything #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rhywun opened this issue Jul 3, 2018 · 2 comments
Closed

Applying fixes doesn't do anything #95

Rhywun opened this issue Jul 3, 2018 · 2 comments

Comments

@Rhywun
Copy link

Rhywun commented Jul 3, 2018

Steps to reproduce:

  1. Enter the following in a Haskell file:
letters :: [Char]
letters = ['a', 'b', 'c']
  1. Hover over the first [
  2. A message pops up reading "[hlint] Use String Found: [Char] Why not: String"
  3. A lightbulb appears. Hover over it and a choice reads "Apply hint:Use String"
  4. Click the choice.
  5. Nothing happens.

Expected result: [Char] to be replaced with String

Same occurs with any suggested fix.

Haskell Language Server 0.0.19
VSCode 1.24.1
macOS Sierra 10.12.6

@lukel97
Copy link
Collaborator

lukel97 commented Jul 13, 2018

Some hints provided by Hlint don't offer any refactoring, this hint could be one of those unfortunate ones. Might need to reopen #61?

@Rhywun
Copy link
Author

Rhywun commented Jul 14, 2018

Update:

I have since updated to the latest HIE v 0.2.1.0, and to v 0.0.20 of this plugin and I have tried several suggested fixes including the one above and all are working now! Thanks & I will close this issue.

@Rhywun Rhywun closed this as completed Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants