Skip to content

Trim Hlint diagnostic messages #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emlautarom1 opened this issue Nov 12, 2020 · 4 comments
Closed

Trim Hlint diagnostic messages #322

emlautarom1 opened this issue Nov 12, 2020 · 4 comments
Labels
status: need confirmation type: enhancement An enhancement to an already existing feature

Comments

@emlautarom1
Copy link

Hlint diagnostic messages contain the full path of the current file and row:column of the suggestion, with a "Suggestion" prefix. This makes the diagnostic verbose with no real benefit.

This may not affect most users, but since I'm currently using Error Lens, the result is pretty annoying. See the following example comparing type-check errors and hlint suggestions:

Screenshot from 2020-11-12 11-32-29

@ndmitchell
Copy link

I think writing our own Idea to string conversion would make sense. CC @jneira

@emlautarom1
Copy link
Author

I see that there's been some discussion about this issue in the hls repo: haskell/haskell-language-server#553

@jneira
Copy link
Member

jneira commented Nov 16, 2020

@emlautarom1 the issue was fixed in master by haskell/haskell-language-server#598
could you try that version?

@jneira jneira added type: enhancement An enhancement to an already existing feature responsibility: server status: need confirmation labels Nov 16, 2020
@emlautarom1
Copy link
Author

@jneira Indeed, the issue was fixed. This is the current output:

Screenshot from 2020-11-16 15-28-45

Some context:

  • Commit ecafd3efe9e4fc73f6275db4cfa78e0ea8936106 (output from git log -1 --format="%H").
  • Built with GHC 8.8.4, cabal-install 3.2.0.0 on Fedora 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need confirmation type: enhancement An enhancement to an already existing feature
Projects
None yet
Development

No branches or pull requests

3 participants