Changes in hlint config file should be applied on the fly #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jneira opened this issue Nov 12, 2020 · 1 comment

Labels

component: hls-hlint-plugin type: enhancement

Member

jneira commented Nov 12, 2020 •

edited

Loading

(from twitter: https://twitter.com/korayal/status/1326963429257711623)

I describe that behaviour prematurely in docs but it does not work
We should change getHlintSettingsRule from defineNoFile to a definition that takes in account possible configuration files to rerun the rule

haskell-language-server/plugins/hls-hlint-plugin/src/Ide/Plugin/Hlint.hs

Lines 218 to 223 in 61c69fd

    
           getHlintSettingsRule :: HlintUsage -> Rules () 
        
           getHlintSettingsRule usage = 
        
               defineNoFile $ \GetHlintSettings -> 
        
                 liftIO $ case usage of 
        
                     HlintEnabled cmdArgs -> argsSettings cmdArgs 
        
                     HlintDisabled -> fail "hlint configuration unspecified"

The text was updated successfully, but these errors were encountered:

jneira added type: enhancement component: hls-hlint-plugin labels

jneira mentioned this issue

Add ability for plugins to handle file change notifications #1588

Merged

Profpatsch commented Jun 29, 2022

Seconded, I run into this every time I change the hlint file.

michaelpj mentioned this issue

Code actions for ignoring hlint hints #3007

Closed

benjamin-thomas mentioned this issue

Read hlint config + show stan errors #3127

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment