Skip to content

Suggesting imports doesn't work on GHC-9.4 #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lf- opened this issue Sep 18, 2022 · 2 comments
Closed

Suggesting imports doesn't work on GHC-9.4 #3195

lf- opened this issue Sep 18, 2022 · 2 comments
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@lf-
Copy link
Contributor

lf- commented Sep 18, 2022

I've seen references to this not working on 9.4 at #3187, so I would assume that it's a known issue, but I'm writing it up so it's written down as a limitation.

Your environment

Which OS do you use?
archlinux/nix

Which version of GHC do you use and how did you install it?
9.4.2 from a dev branch of nixpkgs

How is your project built (alternative: link to the project)?
https://github.com/lf-/hsfixit/blob/main/flake.nix [sorry this is not currently buildable due to some hardcoding of the nixpkgs path; however, it is just the branch referenced above]

Which LSP client (editor/plugin) do you use?
neovim+coc

Which version of HLS do you use and how did you install it?
1.8.0.0 from the nix flake in there

Have you configured HLS in any way (especially: a hie.yaml file)?

cradle:
  cabal:
    - path: "./hsfixit-plugin/src"
      component: "lib:hsfixit-plugin"

    - path: "./hsfixit-types/src"
      component: "lib:hsfixit-types"

Steps to reproduce

Use some identifier that's not in scope, perhaps GHC.Data.Bag.bagToList or similar, and get a compile error.

Expected behaviour

I would like a code action to import the thing as I get on ghc-9.2.

Actual behaviour

Seems this doesn't yet happen on 9.4.

Debug information

@lf- lf- added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Sep 18, 2022
@lf- lf- mentioned this issue Sep 18, 2022
34 tasks
@lf-
Copy link
Contributor Author

lf- commented Sep 18, 2022

Oh, this is because hls-refactor-plugin is absent. :/ Unfortunate.

@michaelpj
Copy link
Collaborator

Yes, I don't think we want duplicate tickets for the (many) things that don't yet work on 9.4!

@michaelpj michaelpj closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

2 participants