Skip to content

Commit f9d8b35

Browse files
committed
address code review feedback
1 parent 239e6ff commit f9d8b35

File tree

1 file changed

+19
-8
lines changed

1 file changed

+19
-8
lines changed

README.md

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ This is *very* early stage software.
2525
- [Install via cabal](#install-via-cabal)
2626
- [Install specific GHC Version](#install-specific-ghc-version)
2727
- [Project Configuration](#project-configuration)
28+
- [Editor Integration](#editor-integration)
2829
- [Contributing](#contributing)
2930
- [It's time to join the project!](#its-time-to-join-the-project)
3031

@@ -269,11 +270,11 @@ dependencies:
269270

270271
## Editor Integration
271272

272-
Note to editor integrators: there is now a haskell-language-server-wrapper executable, which is installed alongside the haskell-language-server executable. When this is invoked in the project root directory, it attempts to work out the GHC version used in the project, and then launch the matching hie executable.
273+
Note to editor integrators: there is now a haskell-language-server-wrapper executable, which is installed alongside the haskell-language-server executable. When this is invoked in the project root directory, it attempts to work out the GHC version used in the project, and then launch the matching haskell-language-server executable.
273274

274-
All of the editor integrations assume that you have already installed HLS (see above) and that stack put the hls binary in your path (usually ~/.local/bin on linux and macOS).
275+
All of the editor integrations assume that you have already installed haskell-language-server (see above) and that the installation script put the haskell-language-server binary in your path (usually ~/.local/bin on linux and macOS).
275276

276-
### Using HLS with Emacs
277+
### Using haskell-language-server with Emacs
277278

278279
Install HLS along with the following emacs packages:
279280

@@ -283,13 +284,19 @@ Install HLS along with the following emacs packages:
283284

284285
Make sure to follow the instructions in the README of each of these packages.
285286

286-
``` lisp
287-
(setq lsp-haskell-process-path-hie "haskell-language-server-wrapper")
287+
``` emacs-lisp
288+
(use-package lsp-haskell
289+
:ensure t
290+
:config
291+
(setq lsp-haskell-process-path-hie "haskell-language-server-wrapper")
292+
;; Comment/uncomment this line to see interactions between lsp client/server.
293+
;;(setq lsp-log-io t)
294+
)
288295
```
289296

290297

291298

292-
### Using HLS with [doom-emacs](https://github.com/hlissner/doom-emacs/tree/develop/modules/lang/haskell#module-flags)
299+
### Using haskell-language-server with [doom-emacs](https://github.com/hlissner/doom-emacs/tree/develop/modules/lang/haskell#module-flags)
293300

294301
Install HLS, and then enable haskell lang module with lsp flag in `.doom.d/init.el`
295302
``` emacs-lisp
@@ -300,8 +307,12 @@ Install HLS, and then enable haskell lang module with lsp flag in `.doom.d/init.
300307
in your `.doom.d/config.el` file
301308

302309
``` emacs-lisp
303-
(after! lsp-haskell
304-
(setq lsp-haskell-process-path-hie "haskell-language-server-wrapper")
310+
(use-package lsp-haskell
311+
:ensure t
312+
:config
313+
(setq lsp-haskell-process-path-hie "haskell-language-server-wrapper")
314+
;; Comment/uncomment this line to see interactions between lsp client/server.
315+
;;(setq lsp-log-io t)
305316
)
306317
```
307318

0 commit comments

Comments
 (0)