Skip to content

Commit 2fa1ed8

Browse files
committed
add more test
1 parent ec931ff commit 2fa1ed8

File tree

1 file changed

+54
-12
lines changed

1 file changed

+54
-12
lines changed

src/cmd/go/internal/modload/query_test.go

+54-12
Original file line numberDiff line numberDiff line change
@@ -150,19 +150,61 @@ func TestQuery(t *testing.T) {
150150
}
151151
}
152152

153-
var(
154-
queryPackagePath = "github.com/google/codesearch/cmd/..."
155-
queryPackageQuery = "latest"
153+
var (
154+
_queryPackage = []struct {
155+
path string
156+
query string
157+
err string
158+
realPath string
159+
version string
160+
}{
161+
{
162+
path: "github.com/google/codesearch/cmd/...",
163+
query: "latest",
164+
err: "",
165+
realPath: "github.com/google/codesearch",
166+
version: "v1.1.0",
167+
},
168+
{
169+
path: "github.com/google/codesearch/cmd",
170+
query: "latest",
171+
err: `no matching versions for query "latest"`,
172+
realPath: "github.com/google/codesearch",
173+
version: "v1.1.0",
174+
},
175+
{
176+
path: "github.com/google/codesearch/...",
177+
query: "latest",
178+
err: ``,
179+
realPath: "github.com/google/codesearch",
180+
version: "v1.1.0",
181+
},
182+
{
183+
path: "github.com/google/codesearch",
184+
query: "latest",
185+
err: `invalid github.com/ import path "github.com/google"`,
186+
realPath: "github.com/google/codesearch",
187+
version: "v1.1.0",
188+
},
189+
}
156190
)
191+
157192
func TestQueryPackage(t *testing.T) {
158-
m, _, err := QueryPackage(queryPackagePath, queryPackageQuery, Allowed)
159-
if err != nil{
160-
t.Error(err)
161-
}
162-
if m.Version != "v1.1.0"{
163-
t.Errorf("queryPackage get wrong info: %s, expect: %s",m.Version, "v1.1.0" )
164-
}
165-
if m.Path != "github.com/google/codesearch"{
166-
t.Errorf("queryPackage get wrong path: %s, expect: %s",m.Path, "github.com/google/codesearch" )
193+
for _, tt := range _queryPackage {
194+
t.Run(strings.Replace(tt.path, "/", "_", -1)+"@"+tt.query, func(t *testing.T) {
195+
m, _, err := QueryPackage(tt.path, tt.query, Allowed)
196+
if err != nil {
197+
if err.Error() != tt.err {
198+
t.Errorf("queryPackage %s get wrong err: %s, expect: %s", tt.path, err, tt.err)
199+
}
200+
return
201+
}
202+
if m.Version != tt.version {
203+
t.Errorf("queryPackage get wrong info: %s, expect: %s", m.Version, tt.version)
204+
}
205+
if m.Path != tt.realPath {
206+
t.Errorf("queryPackage get wrong path: %s, expect: %s", m.Path, tt.realPath)
207+
}
208+
})
167209
}
168210
}

0 commit comments

Comments
 (0)