Merge remote-tracking branch 'origin/main' into michaelrfairhurst/implement-concurrency7-package

Author: MichaelRFairhurst

change_notes/2025-02-06-m5-3-1-exclude-unknown-type.md

@@ -0,0 +1,2 @@
+ - `M5-3-1` - `EachOperandOfTheOperatorOfTheLogicalAndOrTheLogicalOperatorsShallHaveTypeBool.ql`:
+   - Consistently exclude results in unevaluated contexts associated with uninstantiated templates, for example `noexcept` specifiers and `static_assert`s.

change_notes/2025-02-13-fix-issue-718.md

@@ -0,0 +1,2 @@
+- `A2-7-3` - `UndocumentedUserDefinedType.ql`
+  - Fixes #718. Include trailing characters after group comment endings with ///@{ ... ///@}.

cpp/autosar/src/rules/A2-7-3/UndocumentedUserDefinedType.ql

@@ -28,7 +28,7 @@ private predicate isInFunctionScope(Declaration d) {
 private string doxygenCommentGroupStrings(boolean opening) {
   opening = true and result = ["///@{", "/**@{*/"]
   or
-  opening = false and result = ["///@}", "/**@}*/"]
+  opening = false and result = ["///@}%", "/**@}*/"]
 }
 
 pragma[inline]

cpp/autosar/src/rules/M5-3-1/EachOperandOfTheOperatorTheLogicalAndOrTheLogicalOperatorsShallHaveTypeBool.ql

@@ -25,6 +25,11 @@ where
   ) and
   t = operand.getType() and
   not t.getUnderlyingType().getUnspecifiedType() instanceof BoolType and
+  // Ignore cases where the type is unknown - this will typically be in unevaluated contexts
+  // within uninstantiated templates. It's necessary to check for this explicitly because
+  // not all unevaluated contexts are considered to be `isFromUninstantiatedTemplate(_)`,
+  // e.g. `noexcept` specifiers
+  not t instanceof UnknownType and
   not exists(ReferenceType rt |
     rt = t.getUnderlyingType().getUnspecifiedType() and rt.getBaseType() instanceof BoolType
   ) and

cpp/autosar/test/rules/A2-7-3/test.cpp

@@ -225,4 +225,14 @@ class ClassG2 { // COMPLIANT
 class ClassG3 { // COMPLIANT
 public:
   friend int foo3() { return 1; } // NON_COMPLIANT
+};
+
+/// @brief A Doxygen comment.
+class ClassH { // COMPLIANT
+public:
+  /// @brief Group with comment at the end.
+  ///@{
+  void m(); // COMPLIANT
+  void n(); // COMPLIANT
+  ///@} End of group
 };

cpp/autosar/test/rules/M5-3-1/test.cpp

@@ -25,4 +25,13 @@ template <typename T = int> class A {
 void f() {
   A<int> a;
   a.test1();
-}
+}
+
+template <typename T> constexpr bool some_variable_template_v = false;
+template <> constexpr bool some_variable_template_v<int> = true;
+
+template <typename S>
+void template_with_no_except() noexcept(some_variable_template_v<S> &&
+                                        true) { // COMPLIANT
+}
+void test_template() { template_with_no_except<int>(); }