From fb407bc4a49b55657b971fce975cfea23578fc2a Mon Sep 17 00:00:00 2001 From: Ben Vinegar Date: Tue, 12 Jan 2016 13:11:18 -0800 Subject: [PATCH] Hardcode version string in src/raven.js (fixes GH-465) --- Gruntfile.js | 9 ++++++++- package.json | 2 +- src/raven.js | 6 +++++- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 90d7df6840ca..5cd1ac80faaf 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -258,9 +258,16 @@ module.exports = function(grunt) { // Custom Grunt tasks grunt.registerTask('version', function() { var pkg = grunt.config.get('pkg'); + + // Verify version string in source code matches what's in package.json + var Raven = require('./src/raven'); + if (Raven.prototype.VERSION !== pkg.version) { + return grunt.util.error('Mismatched version in src/raven.js: ' + Raven.prototype.VERSION + + ' (should be ' + pkg.version + ')'); + } + if (grunt.option('dev')) { pkg.release = 'dev'; - pkg.version = grunt.config.get('gitinfo').local.branch.current.shortSHA; } else { pkg.release = pkg.version; } diff --git a/package.json b/package.json index ad9e3fb0c592..db0ff1ff68bd 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "type": "git", "url": "git://github.com/getsentry/raven-js.git" }, - "main": "dist/raven.js", + "main": "src/singleton.js", "devDependencies": { "browserify-versionify": "^1.0.6", "chai": "2.3.0", diff --git a/src/raven.js b/src/raven.js index fa720cf15fa4..f42b779188e8 100644 --- a/src/raven.js +++ b/src/raven.js @@ -71,7 +71,11 @@ function Raven() { */ Raven.prototype = { - VERSION: '__VERSION__', + // Hardcode version string so that raven source can be loaded directly via + // webpack (using a build step causes webpack #1617). Grunt verifies that + // this value matches package.json during build. + // See: https://github.com/getsentry/raven-js/issues/465 + VERSION: '2.0.0', debug: false,