fix(core): Make sure logs get flushed in server-runtime-client #16222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
reviewed
May 7, 2025
| @@ -72,6 +73,10 @@ export class ServerRuntimeClient< | |||
| }, DEFAULT_LOG_FLUSH_INTERVAL); | |||
| } | |||
| }); | |||
|
|
|||
| client.on('flush', () => { | |||
| _INTERNAL_flushLogsBuffer(client); | |||
There was a problem hiding this comment.
Should we also cancel _logFlushIdleTimeout here?
There was a problem hiding this comment.
this should be done by the client.on('flushLogs' callback, which should be called as soon as the logs actually get flushed (from the _INTERNAL_flushLogsBuffer call).
The test validates this by showing the client['_logWeight'] is 0, which means we executed that code block.
There was a problem hiding this comment.
Ah, thanks for the explanation.
andreiborza
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually fixes #16110