Replays ending prematurely

[billyvg]

We're noticing some replays are potentially ending prematurely. Here is one such case: replay and error that happens a few seconds after the replay has ended.

The replay ends approximately 2 seconds before the errors occurs. It's possible that either:

1. something caused the replay to stop recording
2. user stopped interacting with the page, so there is nothing to flush after the error occurs
3. something else

In handleAfterSendEvent we may want to add a check to see if replay status is current enabled before tagging with a replay id. We also may want to add a placeholder rrweb event so that we have something to flush to continue the replay. This would address case #2, though it seems odd that this case would happen and I suspect there's something else going.

[billyvg]

It would be nice to add a replay breadcrumb when we stop a replay so that we have some insight into why and when replays are ending. This wouldn't really work when we stop a replay due to network issues.

[mydea]

Yeah, we def. can/should check replay status before adding the ID.

What about adding a proper console log when replay is stopped? Or maybe just for the tracing internal one. Then we'd see this at least in the breadcrumbs of the error, I guess, right?

Do we have an example since we updated to 7.60.1? There we added some logging, e.g. for the conversion buffer->session, that may help a bit as well?

[billyvg]

Relates to https://github.com/getsentry/team-replay/issues/73

[Fwang36]

Linking an another example provided by a customer. Trace view in the replay shows a total of 14 linked transactions. When viewing the Trace Id of the linked transactions, I see there are actually over 1300 events. Trace Id also shows 4 issues related, but on the replay there are only 2 linked issues.

Link to replay is in an Internal Comment at the bottom of this Zendesk Ticket

[mydea]

@billyvg do we know if this is still a problem?

[billyvg]

@mydea I assume so, it's not something I've been able to reproduce, but have seen evidence of it

[mydea]

We've done a bunch of changes making sure to avoid setting the replay ID when the replay is over, most recently in the latest release 7.72.0 (see: #9109). So I'm gonna close this for now, feel free to reopen (or open a new issue) if this keeps happening!