Skip to content

Replay: Don't capture iframe if it relies on srcdoc instead of src #8241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bruno-garcia opened this issue May 29, 2023 · 2 comments · Fixed by #14760
Closed

Replay: Don't capture iframe if it relies on srcdoc instead of src #8241

bruno-garcia opened this issue May 29, 2023 · 2 comments · Fixed by #14760
Assignees
@chargome
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@bruno-garcia
Copy link
Member

Since rrweb doesn't mask the contents of the iframe when it relies on srcdoc. It's best we simply default to blocking it.
@bruno-garcia bruno-garcia added Status: Backlog Package: replay Issues related to the Sentry Replay SDK labels May 29, 2023
@bruno-garcia bruno-garcia mentioned this issue May 29, 2023
Merged
@c298lee c298lee self-assigned this Dec 12, 2023
@chargome
Copy link
Member

@bruno-garcia is this still an issue? Just tested it with a react app and everything was masked there.

@chargome
Copy link
Member

chargome commented Oct 22, 2024 •
edited
Loading

Closing since we can't reproduce it

The issue is that the content of srcdoc is still visible when inspecting the dom in the replay.

@chargome chargome removed their assignment Oct 22, 2024
@chargome chargome reopened this Oct 22, 2024
@chargome chargome self-assigned this Dec 16, 2024
@chargome chargome mentioned this issue Dec 17, 2024
Merged
@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chargome chargome

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(replay): Mask srcdoc iframe contents per default getsentry/sentry-javascript
4 participants
@bruno-garcia @chargome @hubertdeng123 @c298lee