Skip to content

[v8] Remove public APIs around Hub class #11482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lms24 opened this issue Apr 8, 2024 · 0 comments · Fixed by #11630
Closed

[v8] Remove public APIs around Hub class #11482

Lms24 opened this issue Apr 8, 2024 · 0 comments · Fixed by #11630
Assignees

Comments

@Lms24
Copy link
Member

Lms24 commented Apr 8, 2024

It seems we forgot to actually deprecate and remove the Hub class. For v8 and onwards, there's no need to publicly keep the class around

### Public API - (breaking) changes
- [ ] https://github.com/getsentry/sentry-javascript/pull/11528
- [ ] https://github.com/getsentry/sentry-javascript/pull/11530
- [ ] https://github.com/getsentry/sentry-javascript/pull/11539
- [ ] https://github.com/getsentry/sentry-javascript/pull/11536
- [ ] https://github.com/getsentry/sentry-javascript/pull/11560
- [ ] https://github.com/getsentry/sentry-javascript/pull/11565
- [ ] https://github.com/getsentry/sentry-javascript/pull/11581
### Internal Changes
- [x] Rewrite `getCurrentHub` to return a simple "aliasing" object instead satisfying `HubInterface`
- [ ] https://github.com/getsentry/sentry-javascript/pull/11630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant