feat(scope): Only set lastEventId for error events

andreiborza · andreiborza · commit f85d36925f09 · 2024-05-14T17:23:25.000+02:00
diff --git a/packages/core/src/baseclient.ts b/packages/core/src/baseclient.ts
@@ -650,9 +650,8 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {
 
     this.emit('preprocessEvent', event, hint);
 
-    const eventId = event.event_id || hint.event_id;
-    if (eventId) {
-      isolationScope.setLastEventId(eventId);
+    if (!event.type) {
+      isolationScope.setLastEventId(event.event_id || hint.event_id);
     }
 
     return prepareEvent(options, event, hint, currentScope, this, isolationScope).then(evt => {

Original file line number	Diff line number	Diff line change
`@@ -650,9 +650,8 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> {`
`650`	`650`
`651`	`651`	`this.emit('preprocessEvent', event, hint);`
`652`	`652`
`653`		`- const eventId = event.event_id \|\| hint.event_id;`
`654`		`- if (eventId) {`
`655`		`- isolationScope.setLastEventId(eventId);`
	`653`	`+ if (!event.type) {`
	`654`	`+ isolationScope.setLastEventId(event.event_id \|\| hint.event_id);`
`656`	`655`	`}`
`657`	`656`
`658`	`657`	`return prepareEvent(options, event, hint, currentScope, this, isolationScope).then(evt => {`