Skip to content

Commit c59c7c9

Browse files
authored
fix(test): Make Remix integration tests Node 24 compatible (#16241)
Resolves: #16239 Looks like importing types without `type` fails on Node 24.
1 parent 5dd37a6 commit c59c7c9

File tree

10 files changed

+10
-10
lines changed

10 files changed

+10
-10
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -760,7 +760,7 @@ jobs:
760760
strategy:
761761
fail-fast: false
762762
matrix:
763-
node: [18, 20, 22]
763+
node: [18, 20, 22, 24]
764764
steps:
765765
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
766766
uses: actions/checkout@v4

packages/remix/test/integration/test/client/capture-exception.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';
44

55
test('should report a manually captured error.', async ({ page }) => {

packages/remix/test/integration/test/client/capture-message.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';
44

55
test('should report a manually captured message.', async ({ page }) => {

packages/remix/test/integration/test/client/click-error.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';
44

55
test('should report a manually captured message on click with the correct stacktrace.', async ({ page }) => {

packages/remix/test/integration/test/client/errorboundary.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';
44

55
test('should capture React component errors.', async ({ page }) => {

packages/remix/test/integration/test/client/manualtracing.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getMultipleSentryEnvelopeRequests } from './utils/helpers';
44

55
test('should report a manually created / finished transaction.', async ({ page }) => {

packages/remix/test/integration/test/client/meta-tags.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getFirstSentryEnvelopeRequest } from './utils/helpers';
44

55
test('should inject `sentry-trace` and `baggage` meta tags inside the root page.', async ({ page }) => {

packages/remix/test/integration/test/client/pageload.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { Event } from '@sentry/core';
2+
import type { Event } from '@sentry/core';
33
import { getFirstSentryEnvelopeRequest } from './utils/helpers';
44

55
test('should add `pageload` transaction on load.', async ({ page }) => {

packages/remix/test/integration/test/client/root-loader.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Page, expect, test } from '@playwright/test';
1+
import { type Page, expect, test } from '@playwright/test';
22

33
async function getRouteData(page: Page): Promise<any> {
44
return page.evaluate('window.__remixContext.state.loaderData').catch(err => {

packages/remix/test/integration/test/server/instrumentation/loader.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Event } from '@sentry/core';
1+
import type { Event } from '@sentry/core';
22
import { describe, expect, it } from 'vitest';
33
import { RemixTestEnv, assertSentryEvent, assertSentryTransaction } from '../utils/helpers';
44

0 commit comments

Comments
 (0)