Skip to content

Commit 9a3aa0f

Browse files
s1gr1dLms24
andauthored
feat(v8/angular): Merge angular and angular-ivy packages and start Angular support at v14 (#11091)
Start using vitest for better ESM support (since Angular 13) closes #9830 --------- Co-authored-by: Lukas Stracke <[email protected]>
1 parent 34643e3 commit 9a3aa0f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+2803
-5861
lines changed

.craft.yml

-5
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ targets:
4949
includeNames: /^sentry-profiling-node-\d.*\.tgz$/
5050

5151
## 3 Browser-based Packages
52-
- name: npm
53-
id: '@sentry/angular-ivy'
54-
includeNames: /^sentry-angular-ivy-\d.*\.tgz$/
5552
- name: npm
5653
id: '@sentry/angular'
5754
includeNames: /^sentry-angular-\d.*\.tgz$/
@@ -179,8 +176,6 @@ targets:
179176
onlyIfPresent: /^sentry-vue-\d.*\.tgz$/
180177
'npm:@sentry/gatsby':
181178
onlyIfPresent: /^sentry-gatsby-\d.*\.tgz$/
182-
'npm:@sentry/angular-ivy':
183-
onlyIfPresent: /^sentry-angular-ivy-\d.*\.tgz$/
184179
'npm:@sentry/angular':
185180
onlyIfPresent: /^sentry-angular-\d.*\.tgz$/
186181
'npm:@sentry/astro':

.github/ISSUE_TEMPLATE/bug.yml

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ body:
3333
- '@sentry/browser'
3434
- '@sentry/astro'
3535
- '@sentry/angular'
36-
- '@sentry/angular-ivy'
3736
- '@sentry/aws-serverless'
3837
- '@sentry/bun'
3938
- '@sentry/deno'

.github/workflows/issue-package-label.yml

-3
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ jobs:
3838
"@sentry.angular": {
3939
"label": "Package: Angular"
4040
},
41-
"@sentry.angular-ivy": {
42-
"label": "Package: Angular"
43-
},
4441
"@sentry.bun": {
4542
"label": "Package: Bun"
4643
},

MIGRATION.md

+7
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,13 @@ Sentry SDK requires the fetch API to be available in the environment.
597597

598598
The `wrap` method has been removed. There is no replacement API.
599599

600+
#### Removal of `@sentry/angular-ivy` package
601+
602+
The `@sentry/angular-ivy` package has been removed. The `@sentry/angular` package now supports Ivy by default and
603+
requires at least Angular 14. If you are using Angular 13 or lower, we suggest upgrading your Angular version before
604+
migrating to v8. If you can't upgrade your Angular version to at least Angular 14, you can also continue using the
605+
`@sentry/angular-ivy@7` SDK. However, v7 of the SDKs will no longer be fully supported going forward.
606+
600607
### Server-side SDKs (Node, Deno, Bun, etc.)
601608

602609
Removed top-level exports: `enableAnrDetection`, `Anr`, `deepReadDirSync`

README.md

-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ package. Please refer to the README and instructions of those SDKs for more deta
4545
integrations for Express
4646
- [`@sentry/angular`](https://github.com/getsentry/sentry-javascript/tree/master/packages/angular): Browser SDK for
4747
Angular
48-
- [`@sentry/angular-ivy`](https://github.com/getsentry/sentry-javascript/tree/master/packages/angular-ivy): Browser SDK
49-
for Angular with native support for Angular's Ivy rendering engine.
5048
- [`@sentry/astro`](https://github.com/getsentry/sentry-javascript/tree/master/packages/astro): SDK for Astro
5149
- [`@sentry/ember`](https://github.com/getsentry/sentry-javascript/tree/master/packages/ember): Browser SDK for Ember
5250
- [`@sentry/react`](https://github.com/getsentry/sentry-javascript/tree/master/packages/react): Browser SDK for React
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Angular17
22

3-
E2E test app for Angular 17 and `@sentry/angular-ivy`.
3+
E2E test app for Angular 17 and `@sentry/angular`.

dev-packages/e2e-tests/test-applications/angular-17/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@angular/platform-browser": "^17.1.0",
2424
"@angular/platform-browser-dynamic": "^17.1.0",
2525
"@angular/router": "^17.1.0",
26-
"@sentry/angular-ivy": "* || latest",
26+
"@sentry/angular": "* || latest",
2727
"rxjs": "~7.8.0",
2828
"tslib": "^2.3.0",
2929
"zone.js": "~0.14.3"

dev-packages/e2e-tests/test-applications/angular-17/src/app/app.config.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { APP_INITIALIZER, ApplicationConfig, ErrorHandler } from '@angular/core';
22
import { Router, provideRouter } from '@angular/router';
33

4-
import { TraceService, createErrorHandler } from '@sentry/angular-ivy';
4+
import { TraceService, createErrorHandler } from '@sentry/angular';
55
import { routes } from './app.routes';
66

77
export const appConfig: ApplicationConfig = {

dev-packages/e2e-tests/test-applications/angular-17/src/app/component-tracking/component-tracking.components.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { AfterViewInit, Component, OnInit } from '@angular/core';
2-
import { TraceClass, TraceMethod, TraceModule } from '@sentry/angular-ivy';
2+
import { TraceClass, TraceMethod, TraceModule } from '@sentry/angular';
33
import { SampleComponent } from '../sample-component/sample-component.components';
44

55
@Component({

dev-packages/e2e-tests/test-applications/angular-17/src/app/home/home.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { RouterLink } from '@angular/router';
1313
<li> <a id="redirectLink" [routerLink]="['/redirect1']">Redirect</a> </li>
1414
<li> <a id="cancelLink" [routerLink]="['/cancel']">Cancel</a> </li>
1515
<li> <a id="nonExistentLink" [routerLink]="['/non-existent']">Error</a> </li>
16-
<li> <a id="componentTracking" [routerLink]="['/component-tracking']">Error</a> </li>
16+
<li> <a id="componentTracking" [routerLink]="['/component-tracking']">Component Tracking</a> </li>
1717
</ul>
1818
<button id="errorBtn" (click)="throwError()">Throw error</button>
1919
</main>

dev-packages/e2e-tests/test-applications/angular-17/src/main.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { bootstrapApplication } from '@angular/platform-browser';
22
import { AppComponent } from './app/app.component';
33
import { appConfig } from './app/app.config';
44

5-
import * as Sentry from '@sentry/angular-ivy';
5+
import * as Sentry from '@sentry/angular';
66

77
Sentry.init({
88
dsn: 'https://3b6c388182fb435097f41d181be2b2ba@o4504321058471936.ingest.sentry.io/4504321066008576',

dev-packages/e2e-tests/verdaccio-config/config.yaml

-6
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ packages:
3838
unpublish: $all
3939
# proxy: npmjs # Don't proxy for E2E tests!
4040

41-
'@sentry/angular-ivy':
42-
access: $all
43-
publish: $all
44-
unpublish: $all
45-
# proxy: npmjs # Don't proxy for E2E tests!
46-
4741
'@sentry/astro':
4842
access: $all
4943
publish: $all

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
},
4646
"workspaces": [
4747
"packages/angular",
48-
"packages/angular-ivy",
4948
"packages/astro",
5049
"packages/aws-serverless",
5150
"packages/browser",

packages/angular-ivy/LICENSE

-14
This file was deleted.

packages/angular-ivy/README.md

-234
This file was deleted.

0 commit comments

Comments
 (0)