Skip to content

Commit 24e8320

Browse files
committed
remove span attributes separately for otel and sentry spans
1 parent 1772a77 commit 24e8320

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

packages/core/src/tracing/sentrySpan.ts

+9
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { getMetricSummaryJsonForSpan } from '../metrics/metric-summary';
55
import {
66
SEMANTIC_ATTRIBUTE_EXCLUSIVE_TIME,
77
SEMANTIC_ATTRIBUTE_PROFILE_ID,
8+
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
89
SEMANTIC_ATTRIBUTE_SENTRY_OP,
910
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
1011
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
@@ -355,6 +356,14 @@ export class SentrySpan implements Span {
355356

356357
const source = this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] as TransactionSource | undefined;
357358

359+
// remove internal root span attributes we don't need to send.
360+
/* eslint-disable @typescript-eslint/no-dynamic-delete */
361+
delete this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME];
362+
spans.forEach(span => {
363+
span.data && delete span.data[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME];
364+
});
365+
// eslint-enabled-next-line @typescript-eslint/no-dynamic-delete
366+
358367
const transaction: TransactionEvent = {
359368
contexts: {
360369
trace: spanToTransactionTraceContext(this),

packages/opentelemetry/src/spanExporter.ts

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import type {
1212
TransactionSource,
1313
} from '@sentry/core';
1414
import {
15+
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
1516
SEMANTIC_ATTRIBUTE_SENTRY_OP,
1617
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
1718
SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
@@ -392,6 +393,7 @@ function removeSentryAttributes(data: Record<string, unknown>): Record<string, u
392393
/* eslint-disable @typescript-eslint/no-dynamic-delete */
393394
delete cleanedData[SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE];
394395
delete cleanedData[SEMANTIC_ATTRIBUTE_SENTRY_PARENT_IS_REMOTE];
396+
delete cleanedData[SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME];
395397
/* eslint-enable @typescript-eslint/no-dynamic-delete */
396398

397399
return cleanedData;

0 commit comments

Comments
 (0)