Skip to content

Commit 1763829

Browse files
committed
test(sveltekit): Switch to explicit vitest imports
1 parent 80d76c9 commit 1763829

20 files changed

+44
-20
lines changed

packages/sveltekit/test/client/browserTracingIntegration.test.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
1+
/**
2+
* @vitest-environment jsdom
3+
*/
4+
15
/* eslint-disable @typescript-eslint/unbound-method */
6+
import { beforeEach, describe, expect, it, vi } from 'vitest';
7+
28
import type { Span } from '@sentry/types';
39
import { writable } from 'svelte/store';
4-
import { vi } from 'vitest';
510

611
import { navigating, page } from '$app/stores';
712

packages/sveltekit/test/client/fetch.test.ts

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
/**
2+
* @vitest-environment jsdom
3+
*/
4+
5+
import { beforeEach, describe, expect, it } from 'vitest';
6+
17
import { init } from '../../src/client/index';
28

39
describe('instruments fetch', () => {

packages/sveltekit/test/client/handleError.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
import { beforeEach, describe, expect, it, vi } from 'vitest';
2+
13
import * as SentrySvelte from '@sentry/svelte';
24
import type { HandleClientError, NavigationEvent } from '@sveltejs/kit';
3-
import { vi } from 'vitest';
45

56
import { handleErrorWithSentry } from '../../src/client/handleError';
67

packages/sveltekit/test/client/load.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
import { beforeEach, describe, expect, it, vi } from 'vitest';
2+
13
import * as SentrySvelte from '@sentry/svelte';
24
import type { Load } from '@sveltejs/kit';
35
import { redirect } from '@sveltejs/kit';
4-
import { vi } from 'vitest';
56

67
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
78
import { wrapLoadWithSentry } from '../../src/client/load';

packages/sveltekit/test/client/sdk.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
import { afterEach, describe, expect, it, vi } from 'vitest';
2+
13
import type { BrowserClient } from '@sentry/svelte';
24
import * as SentrySvelte from '@sentry/svelte';
35
import { SDK_VERSION, getClient, getCurrentScope, getGlobalScope, getIsolationScope } from '@sentry/svelte';
4-
import { vi } from 'vitest';
56

67
import { init } from '../../src/client';
78

packages/sveltekit/test/common/utils.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { describe, expect, it } from 'vitest';
2+
13
import { isHttpError, isRedirect } from '../../src/common/utils';
24

35
describe('isRedirect', () => {

packages/sveltekit/test/index.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { describe, expect, it } from 'vitest';
2+
13
import * as SentryClient from '../src/client';
24
import * as SentryServer from '../src/server';
35

packages/sveltekit/test/server/handle.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { beforeEach, describe, expect, it } from 'vitest';
2+
13
import {
24
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
35
getRootSpan,

packages/sveltekit/test/server/handleError.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
import { beforeEach, describe, expect, it, vi } from 'vitest';
2+
13
import * as SentryNode from '@sentry/node';
24
import type { HandleServerError, RequestEvent } from '@sveltejs/kit';
3-
import { vi } from 'vitest';
45

56
import { handleErrorWithSentry } from '../../src/server/handleError';
67

packages/sveltekit/test/server/load.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
2+
13
import {
24
SEMANTIC_ATTRIBUTE_SENTRY_OP,
35
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
@@ -8,7 +10,6 @@ import * as SentryNode from '@sentry/node';
810
import type { Event } from '@sentry/types';
911
import type { Load, ServerLoad } from '@sveltejs/kit';
1012
import { error, redirect } from '@sveltejs/kit';
11-
import { vi } from 'vitest';
1213

1314
import { wrapLoadWithSentry, wrapServerLoadWithSentry } from '../../src/server/load';
1415
import { getDefaultNodeClientOptions } from '../utils';

packages/sveltekit/test/server/sdk.test.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
import { afterEach, describe, expect, it, vi } from 'vitest';
2+
13
import * as SentryNode from '@sentry/node';
24
import type { NodeClient } from '@sentry/node';
35
import { SDK_VERSION, getClient } from '@sentry/node';
46

5-
import { vi } from 'vitest';
67
import { init } from '../../src/server/sdk';
78

89
const nodeInit = vi.spyOn(SentryNode, 'init');

packages/sveltekit/test/server/utils.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { describe, expect, it } from 'vitest';
2+
13
import { getTracePropagationData } from '../../src/server/utils';
24

35
const MOCK_REQUEST_EVENT: any = {

packages/sveltekit/test/vite/autoInstrument.test.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { vi } from 'vitest';
1+
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
22

33
import { canWrapLoad, makeAutoInstrumentationPlugin } from '../../src/vite/autoInstrument';
44

@@ -12,7 +12,6 @@ let fileContent: string | undefined;
1212
vi.mock('fs', async () => {
1313
const actual = await vi.importActual('fs');
1414
return {
15-
// @ts-expect-error this exists, I promise!
1615
...actual,
1716
promises: {
1817
// @ts-expect-error this also exists, I promise!

packages/sveltekit/test/vite/detectAdapter.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import { vi } from 'vitest';
1+
import { beforeEach, describe, expect, it, vi } from 'vitest';
22

33
import { detectAdapter } from '../../src/vite/detectAdapter';
44

55
let existsFile = true;
66
const pkgJson = {
7-
dependencies: {},
7+
dependencies: {} as Record<string, string>,
88
};
99
describe('detectAdapter', () => {
1010
beforeEach(() => {

packages/sveltekit/test/vite/injectGlobalValues.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { describe, expect, it } from 'vitest';
2+
13
import { getGlobalValueInjectionCode } from '../../src/vite/injectGlobalValues';
24

35
describe('getGlobalValueInjectionCode', () => {

packages/sveltekit/test/vite/sentrySvelteKitPlugins.test.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { vi } from 'vitest';
1+
import { describe, expect, it, vi } from 'vitest';
22

33
import type { Plugin } from 'vite';
44
import * as autoInstrument from '../../src/vite/autoInstrument';
@@ -8,7 +8,6 @@ import * as sourceMaps from '../../src/vite/sourceMaps';
88
vi.mock('fs', async () => {
99
const actual = await vi.importActual('fs');
1010
return {
11-
// @ts-expect-error this exists, I promise!
1211
...actual,
1312
promises: {
1413
// @ts-expect-error this also exists, I promise!

packages/sveltekit/test/vite/sourceMaps.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { vi } from 'vitest';
1+
import { beforeEach, describe, expect, it, vi } from 'vitest';
22

33
import type { Plugin } from 'vite';
44
import { makeCustomSentryVitePlugins } from '../../src/vite/sourceMaps';

packages/sveltekit/test/vite/svelteConfig.test.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import { vi } from 'vitest';
1+
import { beforeEach, describe, expect, it, vi } from 'vitest';
22

33
import type { SupportedSvelteKitAdapters } from '../../src/vite/detectAdapter';
44
import { getAdapterOutputDir, getHooksFileName, loadSvelteConfig } from '../../src/vite/svelteConfig';
55

6-
let existsFile;
6+
let existsFile: any;
77

88
describe('loadSvelteConfig', () => {
99
vi.mock('fs', () => {
@@ -25,7 +25,7 @@ describe('loadSvelteConfig', () => {
2525
// url apparently doesn't exist in the test environment, therefore we mock it:
2626
vi.mock('url', () => {
2727
return {
28-
pathToFileURL: path => {
28+
pathToFileURL: (path: string) => {
2929
return {
3030
href: path,
3131
};
@@ -58,7 +58,7 @@ describe('loadSvelteConfig', () => {
5858
describe('getAdapterOutputDir', () => {
5959
const mockedAdapter = {
6060
name: 'mocked-adapter',
61-
adapt(builder) {
61+
adapt(builder: any) {
6262
builder.writeClient('customBuildDir');
6363
},
6464
};

packages/sveltekit/tsconfig.test.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55

66
"compilerOptions": {
77
// should include all types from `./tsconfig.json` plus types for all test frameworks used
8-
"types": ["node", "vitest/globals"]
8+
"types": ["node"]
99
}
1010
}

packages/sveltekit/vite.config.ts

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export default {
1111
// test exists, no idea why TS doesn't recognize it
1212
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1313
...(baseConfig as UserConfig & { test: any }).test,
14-
environment: 'jsdom',
1514
setupFiles: ['./test/vitest.setup.ts'],
1615
alias: [
1716
{

0 commit comments

Comments
 (0)