Skip to content

Commit d5ac6ac

Browse files
authored
[PE] remove stale commit signing instructions (#7932)
Since we're not requiring signing anymore, we can remove this bit from the contributing docs. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read the [Flutter Style Guide] _recently_, and have followed its advice. - [x] I signed the [CLA]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
1 parent b1c0dd5 commit d5ac6ac

File tree

1 file changed

+0
-32
lines changed

1 file changed

+0
-32
lines changed

CONTRIBUTING.md

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -282,35 +282,3 @@ To set up the license key:
282282
1. Copy the template at resources/jxbrowser/jxbrowser.properties.template
283283
and save it as resources/jxbrowser/jxbrowser.properties.
284284
2. Replace `<KEY>` with the actual key.
285-
286-
## Signing commits
287-
288-
We require that all commits to the repository are signed with GPG or SSH, see [GitHub's documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification).
289-
290-
If you are on macOS, and choose to sign with GPG, here are some additonal notes:
291-
292-
- Download GPG's tarball along with its dependencies from [here](https://www.gnupg.org/download/).
293-
GPG is the first item, the dependencies are in the block below (Libgpg-error, Libgcrypt, etc.).
294-
- To install these tarballs on macOS, follow these instructions:
295-
- Download the desired `.tar.gz` or (`.tar.bz2`) file
296-
- Open Terminal
297-
- Extract the `.tar.gz` or (`.tar.bz2`) file with the following commands (Follow these steps for the dependencies first, then for GPG):
298-
```bash
299-
tar xvjf PACKAGENAME.tar.bz2
300-
# Navigate to the extracted folder using cd command
301-
cd PACKAGENAME
302-
# Now run the following command to install the tarball
303-
./configure
304-
make
305-
sudo make install
306-
```
307-
- You may need to install pinentry (`brew install pinentry`)
308-
- If the Pinentry continues to not work, check its path (`which pinentry`) and add it to the file `~/.gnupg/gpg-agent.conf`, i.e.:
309-
```bash
310-
pinentry-program /path/to/pinentry
311-
```
312-
- You may need to set the tty `export GPG_TTY=$(tty)` if you get this error when trying to commit:
313-
```bash
314-
error: gpg failed to sign the data
315-
fatal: failed to write commit object
316-
```

0 commit comments

Comments
 (0)