Bazel run config mnemonics (and cleanup). (#580)

Author: pq

src/io/flutter/inspections/SdkConfigurationNotificationProvider.java

@@ -66,6 +66,7 @@ private static EditorNotificationPanel createWrongSdkPanel(@NotNull Project proj
     return panel;
   }
 
+  @SuppressWarnings("SameReturnValue")
   private static EditorNotificationPanel createNoFlutterSdkPanel() {
     // TODO(pq): add panel for unconfigured Flutter SDK.
 

src/io/flutter/run/FlutterDebugProcess.java

@@ -64,6 +64,7 @@ public boolean shouldEnableHotReload() {
     return ((FlutterAppState)myState).getMode().isReloadEnabled();
   }
 
+  @SuppressWarnings("BooleanMethodIsAlwaysInverted")
   private boolean isDebuggingSession() {
     return isDebuggingSession(myState);
   }

src/io/flutter/run/bazel/FlutterBazelConfigurationEditorForm.form

@@ -40,7 +40,7 @@
         <properties>
           <inheritsPopupMenu value="true"/>
           <labelFor value="17e7b"/>
-          <text value="Launching script:"/>
+          <text value="Launching &amp;script:"/>
         </properties>
       </component>
       <component id="17e7b" class="com.intellij.openapi.ui.TextFieldWithBrowseButton" binding="myLaunchingScript">
@@ -57,7 +57,7 @@
         </constraints>
         <properties>
           <labelFor value="ada9e"/>
-          <text value="Additional args:"/>
+          <text value="Additional &amp;args:"/>
         </properties>
       </component>
       <component id="ada9e" class="javax.swing.JTextField" binding="myAdditionalArgs">
@@ -72,7 +72,7 @@
         </constraints>
         <properties>
           <labelFor value="ada9f"/>
-          <text value="Bazel build target:"/>
+          <text value="Bazel build &amp;target:"/>
         </properties>
       </component>
       <component id="ada9f" class="javax.swing.JTextField" binding="myBuildTarget">

src/io/flutter/run/daemon/FlutterDaemonController.java

@@ -241,7 +241,7 @@ private static GeneralCommandLine createBazelRunner(@NotNull Project project,
                                                       boolean isHot,
                                                       @NotNull String launchingScript,
                                                       @NotNull String bazelTarget,
-                                                      @Nullable String additionalArguments) throws ExecutionException {
+                                                      @Nullable String additionalArguments) {
     final GeneralCommandLine commandLine = new GeneralCommandLine().withWorkDirectory(projectDir);
     commandLine.setCharset(CharsetToolkit.UTF8_CHARSET);
     commandLine.setExePath(FileUtil.toSystemDependentName(launchingScript));

src/io/flutter/run/daemon/FlutterDaemonControllerHelper.java

@@ -667,7 +667,7 @@ void process(FlutterDaemonControllerHelper manager, FlutterDaemonController cont
 
   private static class AppStoppedEvent extends Event {
     // "event":"app.stop"
-    @SuppressWarnings("unused") private String appId;
+    @SuppressWarnings({"unused", "CanBeFinal"}) private String appId;
 
     void process(FlutterDaemonControllerHelper manager, FlutterDaemonController controller) {
       manager.eventAppStopped(this);

third_party/intellij-plugins-dart/src/com/jetbrains/lang/dart/ide/runner/server/vmService/DartVmServiceDebugProcessZ.java

@@ -198,9 +198,6 @@ public void logInformation(final String message, final Throwable exception) {
     });
   }
 
-  public void scheduleConnect() {
-  }
-
   public void scheduleConnectNew() {
     ApplicationManager.getApplication().executeOnPooledThread(() -> {
       if (myConnector != null) {