Skip to content

Commit 6e81fc8

Browse files
authored
Fix a sporadic error with the IDEA platform not registering all toolWindows (#8030)
This resolves #8029
1 parent 944aa02 commit 6e81fc8

File tree

2 files changed

+14
-10
lines changed

2 files changed

+14
-10
lines changed

resources/META-INF/plugin.xml

+7-5
Original file line numberDiff line numberDiff line change
@@ -388,14 +388,16 @@
388388
<codeInsight.lineMarkerProvider language="Dart" implementationClass="io.flutter.editor.FlutterIconLineMarkerProvider"/>
389389
<errorHandler implementation="io.flutter.FlutterErrorReportSubmitter"/>
390390

391-
<toolWindow id="Flutter Inspector" anchor="right" icon="FlutterIcons.DevToolsInspector"
392-
factoryClass="io.flutter.view.FlutterViewFactory"/>
393-
<projectService serviceImplementation="io.flutter.view.FlutterView" overrides="false"/>
394-
<!-- Do not uncomment until ready to release the Property Editor. -->
395-
<!-- <toolWindow id="Flutter Property Editor" anchor="right" icon="FlutterIcons.PropertyEditor" factoryClass="io.flutter.propertyeditor.PropertyEditorViewFactory" /> -->
391+
<toolWindow id="Flutter Inspector" anchor="right" icon="FlutterIcons.DevToolsInspector" factoryClass="io.flutter.view.FlutterViewFactory"/>
396392
<toolWindow id="Flutter Deep Links" anchor="right" icon="FlutterIcons.DevToolsDeepLinks" factoryClass="io.flutter.deeplinks.DeepLinksViewFactory" />
397393
<toolWindow id="Flutter DevTools" anchor="right" icon="FlutterIcons.DevTools" factoryClass="io.flutter.devtools.RemainingDevToolsViewFactory" />
398394
<toolWindow id="Flutter DevTools Extensions" anchor="right" icon="FlutterIcons.DevToolsExtensions" factoryClass="io.flutter.devtools.DevToolsExtensionsViewFactory" />
395+
<!-- Do not uncomment until ready to release the Property Editor. -->
396+
<!-- <toolWindow id="Flutter Property Editor" anchor="right" icon="FlutterIcons.PropertyEditor" factoryClass="io.flutter.propertyeditor.PropertyEditorViewFactory" /> -->
397+
398+
<!-- Having the projectService defined after the toolWindows allows them to all be picked up by the platform -->
399+
<!-- See https://github.com/flutter/flutter-intellij/issues/8029 -->
400+
<projectService serviceImplementation="io.flutter.view.FlutterView" overrides="false"/>
399401

400402
<projectOpenProcessor id="flutter" implementation="io.flutter.project.FlutterProjectOpenProcessor" order="first"/>
401403

resources/META-INF/plugin_template.xml

+7-5
Original file line numberDiff line numberDiff line change
@@ -316,14 +316,16 @@
316316
<codeInsight.lineMarkerProvider language="Dart" implementationClass="io.flutter.editor.FlutterIconLineMarkerProvider"/>
317317
<errorHandler implementation="io.flutter.FlutterErrorReportSubmitter"/>
318318

319-
<toolWindow id="Flutter Inspector" anchor="right" icon="FlutterIcons.DevToolsInspector"
320-
factoryClass="io.flutter.view.FlutterViewFactory"/>
321-
<projectService serviceImplementation="io.flutter.view.FlutterView" overrides="false"/>
322-
<!-- Do not uncomment until ready to release the Property Editor. -->
323-
<!-- <toolWindow id="Flutter Property Editor" anchor="right" icon="FlutterIcons.PropertyEditor" factoryClass="io.flutter.propertyeditor.PropertyEditorViewFactory" /> -->
319+
<toolWindow id="Flutter Inspector" anchor="right" icon="FlutterIcons.DevToolsInspector" factoryClass="io.flutter.view.FlutterViewFactory"/>
324320
<toolWindow id="Flutter Deep Links" anchor="right" icon="FlutterIcons.DevToolsDeepLinks" factoryClass="io.flutter.deeplinks.DeepLinksViewFactory" />
325321
<toolWindow id="Flutter DevTools" anchor="right" icon="FlutterIcons.DevTools" factoryClass="io.flutter.devtools.RemainingDevToolsViewFactory" />
326322
<toolWindow id="Flutter DevTools Extensions" anchor="right" icon="FlutterIcons.DevToolsExtensions" factoryClass="io.flutter.devtools.DevToolsExtensionsViewFactory" />
323+
<!-- Do not uncomment until ready to release the Property Editor. -->
324+
<!-- <toolWindow id="Flutter Property Editor" anchor="right" icon="FlutterIcons.PropertyEditor" factoryClass="io.flutter.propertyeditor.PropertyEditorViewFactory" /> -->
325+
326+
<!-- Having the projectService defined after the toolWindows allows them to all be picked up by the platform -->
327+
<!-- See https://github.com/flutter/flutter-intellij/issues/8029 -->
328+
<projectService serviceImplementation="io.flutter.view.FlutterView" overrides="false"/>
327329

328330
<projectOpenProcessor id="flutter" implementation="io.flutter.project.FlutterProjectOpenProcessor" order="first"/>
329331

0 commit comments

Comments
 (0)