Pragma ignored by 2018 version of xtensa compiler in BLERemoteService

[jubueche]

Description:

Describe your problem here

I am running the 2018 version of xtensa. When I was compiling my program it was unsuccessful, because of this line:

#pragma GCC diagnostic ignored "-Wunused-but-set-parameter"
in BLERemoteService.cpp line 238.

I just changed it to 'warning' and moved it up the file and that fixed the problem for me.

[atanisoft]

What compiler version is that? "2018 xtensa" doesn't mean much as a GCC version number.

[atanisoft]

this is also tracked via this bug.

[jubueche]

xtensa-esp32-elf-cpp (crosstool-NG esp32-2018r1) 8.2.0
That's when I get when I run --version. How do you see the GCC version of the used GCC compiler?
Anyway, I wonder why this is not fixed.

[atanisoft]

GCC 8.2.0 is not the supported version for this project which is still stuck on GCC 5.2.0 which is used by ESPIDF v3.2. GCC 8.x will be supported once ESPIDF v4 has reached a "stable" point.

But I do agree, I can't see any reason why this bug in the GCC g++ compiler has not been fixed yet.

As for this BLERemoteService.cpp fix, submit a PR to remove that pragma line entirely.

[jubueche]

Ok I submitted one here.

[stale]

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.