Skip to content

Error return RSSI is sint8 #7641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Erriez opened this issue Oct 7, 2020 · 0 comments · Fixed by #7657
Closed

Error return RSSI is sint8 #7641

Erriez opened this issue Oct 7, 2020 · 0 comments · Fixed by #7657

Comments

@Erriez
Copy link
Contributor

Erriez commented Oct 7, 2020 •
edited
Loading

According to the datasheet page 46, the function sint8 wifi_station_get_rssi(void); returns sint8, but return type in the library is int32_t:

Arduino/libraries/ESP8266WiFi/src/ESP8266WiFiSTA.cpp

Line 688 in bc2b13a

int32_t ESP8266WiFiSTAClass::RSSI(void) {

Proposal to change to:

int8_t ESP8266WiFiSTAClass::RSSI(void);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING: Change return type of RSSI() esp8266/Arduino
1 participant
@Erriez