Skip to content

Commit 3a8e1d4

Browse files
Move the templates/objects to their own namespaces
1 parent 06aa44f commit 3a8e1d4

File tree

4 files changed

+24
-10
lines changed

4 files changed

+24
-10
lines changed

libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer-impl.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
#include "StreamString.h"
77
#include "ESP8266HTTPUpdateServer.h"
88

9+
namespace esp8266httpupdateserver {
10+
using namespace esp8266webserver;
911

1012
static const char serverIndex[] PROGMEM =
1113
R"(<html><body><form method='POST' action='' enctype='multipart/form-data'>
@@ -105,3 +107,5 @@ void ESP8266HTTPUpdateServerTemplate<ServerType>::_setUpdaterError()
105107
Update.printError(str);
106108
_updaterError = str.c_str();
107109
}
110+
111+
};

libraries/ESP8266HTTPUpdateServer/src/ESP8266HTTPUpdateServer.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33

44
#include <ESP8266WebServer.h>
55

6+
namespace esp8266httpupdateserver {
7+
using namespace esp8266webserver;
8+
69
template <typename ServerType>
710
class ESP8266HTTPUpdateServerTemplate
811
{
@@ -44,17 +47,19 @@ class ESP8266HTTPUpdateServerTemplate
4447
String _updaterError;
4548
};
4649

50+
};
51+
4752
#include "ESP8266HTTPUpdateServer-impl.h"
4853

4954

50-
using ESP8266HTTPUpdateServer = ESP8266HTTPUpdateServerTemplate<WiFiServer>;
55+
using ESP8266HTTPUpdateServer = esp8266httpupdateserver::ESP8266HTTPUpdateServerTemplate<WiFiServer>;
5156

5257
namespace BearSSL {
53-
using ESP8266HTTPUpdateServerSecure = ESP8266HTTPUpdateServerTemplate<WiFiServerSecure>;
58+
using ESP8266HTTPUpdateServerSecure = esp8266httpupdateserver::ESP8266HTTPUpdateServerTemplate<WiFiServerSecure>;
5459
};
5560

5661
namespace axTLS {
57-
using ESP8266HTTPUpdateServerSecure = ESP8266HTTPUpdateServerTemplate<WiFiServerSecure>;
62+
using ESP8266HTTPUpdateServerSecure = esp8266httpupdateserver::ESP8266HTTPUpdateServerTemplate<WiFiServerSecure>;
5863
};
5964

6065
#endif

libraries/ESP8266WebServer/src/ESP8266WebServer.h

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <memory>
2929
#include <ESP8266WiFi.h>
3030
#include <FS.h>
31+
#include "detail/mimetable.h"
3132

3233
enum HTTPMethod { HTTP_ANY, HTTP_GET, HTTP_POST, HTTP_PUT, HTTP_PATCH, HTTP_DELETE, HTTP_OPTIONS };
3334
enum HTTPUploadStatus { UPLOAD_FILE_START, UPLOAD_FILE_WRITE, UPLOAD_FILE_END,
@@ -49,9 +50,6 @@ enum HTTPAuthMethod { BASIC_AUTH, DIGEST_AUTH };
4950
#define CONTENT_LENGTH_UNKNOWN ((size_t) -1)
5051
#define CONTENT_LENGTH_NOT_SET ((size_t) -2)
5152

52-
template<typename ServerType>
53-
class ESP8266WebServerTemplate;
54-
5553
typedef struct {
5654
HTTPUploadStatus status;
5755
String filename;
@@ -63,6 +61,11 @@ typedef struct {
6361
uint8_t buf[HTTP_UPLOAD_BUFLEN];
6462
} HTTPUpload;
6563

64+
namespace esp8266webserver {
65+
66+
template<typename ServerType>
67+
class ESP8266WebServerTemplate;
68+
6669
#include "detail/RequestHandler.h"
6770

6871
template<typename ServerType>
@@ -201,11 +204,13 @@ class ESP8266WebServerTemplate
201204

202205
};
203206

204-
205207
#include "ESP8266WebServer-impl.h"
206208
#include "Parsing-impl.h"
207209

208-
using ESP8266WebServer = ESP8266WebServerTemplate<WiFiServer>;
210+
};
211+
212+
213+
using ESP8266WebServer = esp8266webserver::ESP8266WebServerTemplate<WiFiServer>;
209214

210215

211216
#endif //ESP8266WEBSERVER_H

libraries/ESP8266WebServer/src/ESP8266WebServerSecure.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
#include <WiFiClientSecure.h>
2424

2525
namespace axTLS {
26-
using ESP8266WebServerSecure = ESP8266WebServerTemplate<WiFiServerSecure>;
26+
using ESP8266WebServerSecure = esp8266webserver::ESP8266WebServerTemplate<WiFiServerSecure>;
2727
};
2828

2929
namespace BearSSL {
30-
using ESP8266WebServerSecure = ESP8266WebServerTemplate<WiFiServerSecure>;
30+
using ESP8266WebServerSecure = esp8266webserver::ESP8266WebServerTemplate<WiFiServerSecure>;
3131
};

0 commit comments

Comments
 (0)