Skip to content

check_syntax command is skipped in PRs changing Enso codebase. #12086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
farmaazon opened this issue Jan 20, 2025 · 5 comments · May be fixed by #13043
Open

check_syntax command is skipped in PRs changing Enso codebase. #12086

farmaazon opened this issue Jan 20, 2025 · 5 comments · May be fixed by #13043
Assignees
Labels
--bug Type: bug -build-script Category: build script -ci p-high Should be completed in the next sprint

Comments

@farmaazon
Copy link
Contributor

Part of the rust Lint on CI is calling check_syntax against the entire enso codebase in our repository: here is an example of it failing: https://github.com/enso-org/enso/actions/runs/12867080365/job/35870986797?pr=12083#step:9:634

It depends on enso files, but is not run in PRs changing those: https://github.com/enso-org/enso/actions/runs/12831871200/job/35783310246

Probably should not be a part of WASM lint, but a step run when rust or enso code changes.

@farmaazon farmaazon added p-high Should be completed in the next sprint -ci --bug Type: bug -build-script Category: build script labels Jan 20, 2025
@farmaazon farmaazon added this to the 2025-Q1 Release milestone Jan 20, 2025
@4e6 4e6 self-assigned this Jan 29, 2025
@hubertp hubertp moved this from ❓New to 📤 Backlog in Issues Board Feb 10, 2025
@4e6 4e6 moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 5, 2025
@4e6 4e6 unassigned hubertp May 5, 2025
@4e6 4e6 linked a pull request May 6, 2025 that will close this issue
5 tasks
@enso-bot
Copy link

enso-bot bot commented May 7, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-05-05):

Progress: [12845] Working on review comments. Merged the PR. [13026] Fixed stack overflow error in the changelog check on CI. Created the PR.[12086] Started working on the issue. Created a separate wasm lint step for linting wasm source files. It should be finished by 2025-05-12.

Next Day: Next day I will be working on the #12086 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 7, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-05-06):

Progress: [12086] Separated the logic for linting enso libraries and rust sources into different CI jobs. Created the PR. [13044] Updated runtime async commands test to handle the timeouts during the program startup. Created the PR. It should be finished by 2025-05-12.

Next Day: Next day I will be working on the #12086 task. Continue working on the task

@4e6 4e6 moved this from 🔧 Implementation to 🌟 Q/A review in Issues Board May 8, 2025
@4e6 4e6 moved this from 🌟 Q/A review to 👁️ Code review in Issues Board May 8, 2025
@enso-bot
Copy link

enso-bot bot commented May 9, 2025

Dmitry Bushev reports a new STANDUP for the provided date (2025-05-07):

Progress: [13045] Added retrying logic to the download Engine Distribution job. Created a PR. [cloud][1946] Started working on the issue. Looking for Rust approaches of parsing multipart form data in AWS lambdas. It should be finished by 2025-05-12.

Next Day: Next day I will be working on the #12086 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 9, 2025

Dmitry Bushev reports a new STANDUP for yesterday (2025-05-08):

Progress: [cloud][1946] Agreed with Pavel to implement the lambda in TypeScript. Implemented the definition of the lambda. Updated the terraform config. It should be finished by 2025-05-12.

Next Day: Next day I will be working on the #12086 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 9, 2025

Dmitry Bushev reports a new STANDUP for today (2025-05-09):

Progress: [cloud][1946] Implemented S3 methods to get and put objects. Implemented updating of enso-project archive using the temporary directory. Updated error handling. Added necessary permissions. It should be finished by 2025-05-12.

Next Day: Next day I will be working on the #12086 task. Continue working on the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -build-script Category: build script -ci p-high Should be completed in the next sprint
Projects
Status: 👁️ Code review
Development

Successfully merging a pull request may close this issue.

4 participants