Skip to content

IcuCollationTokenFilter requires bunch of parameters that are not required on server side #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Enerccio opened this issue Jul 16, 2022 · 2 comments · Fixed by #384
Closed
Labels
Area: Specification Related to the API spec used to generate client code

Comments

@Enerccio
Copy link

Java API client version

8.2.3

Java version

1.8

Elasticsearch Version

8.2.3

Problem description

Serverside icu_collation does not require many parameters, for instance we only use language and country. However, when trying to use builder in java api you have to specify ALL properties, even those which are listed as "expert" in the manual (https://www.elastic.co/guide/en/elasticsearch/plugins/master/analysis-icu-collation-keyword-field.html) or you end with exception such as co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'IcuCollationTokenFilter.casefirst'.

@Enerccio
Copy link
Author

Same with PatternTokenizer. Why are there checks for this when they are optional?

@Enerccio
Copy link
Author

Also there is wrong decomposition enum Identical.

co.elastic.clients.elasticsearch._types.ElasticsearchException: [es/indices.create] failed: [illegal_argument_exception] Invalid decomposition: identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Specification Related to the API spec used to generate client code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants