Skip to content

Sidebar: Overlapped by cover page, toggled by screen width shortening #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohammedsahl opened this issue Jun 11, 2020 · 2 comments · Fixed by #1215
Closed

Sidebar: Overlapped by cover page, toggled by screen width shortening #1213

mohammedsahl opened this issue Jun 11, 2020 · 2 comments · Fixed by #1215
Labels
bug confirmed as a bug ui/ux related to user interface and/or user experience of docsify

Comments

@mohammedsahl
Copy link
Contributor

Bug Report

When the screen width gets shorter than 768px some unusual UI updates take place.

Steps to reproduce

This video better demonstrates the conditions needed to reproduce this
Posting screenshots would clog this issue 😅

What is current behavior

  • The sidebar is positioned under the cover page UI elements
  • The side bar toggles on when shortening the width

What is the expected behavior

  • The side bar should overlap the cover screen when the sidebar-toggle-button is pressed.
  • Shortening the screen width must not cause the sidebar must not toggle on

Other relevant information

  • Your OS:
  • Node.js version: v13.11.0
  • npm/yarn version: 6.13.7
  • Browser version: 83.0.4103.97
  • Docsify version: 4.4.1 (CLI version)
@anikethsaha
Copy link
Member

Thanks for the detailed report.

I appreciate your efforts in submitting a video of the bug 😃 , but those might take a long time for you.
for repro examples, you can simply write the steps or you can submit a code sandbox link as it will take less time.

No need to change this one, as it is pretty clear from the video 😄 .

This is a bug, Feel free to submit a PR. 👍

@anikethsaha anikethsaha added bug confirmed as a bug ui/ux related to user interface and/or user experience of docsify labels Jun 11, 2020
@mohammedsahl mohammedsahl mentioned this issue Jun 12, 2020
15 tasks
@mohammedsahl
Copy link
Contributor Author

It's a relatively small change. However I was wondering if the "sidebar toggling when shortening" fix should also be added to this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug ui/ux related to user interface and/or user experience of docsify
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants