diff --git a/requirements-development.txt b/requirements-development.txt index 834dc094..807c78a1 100644 --- a/requirements-development.txt +++ b/requirements-development.txt @@ -4,7 +4,7 @@ django-filter>=2.0 django-polymorphic>=2.0 factory-boy Faker -flake8 +flake8==3.6.0 flake8-isort isort mock diff --git a/rest_framework_json_api/relations.py b/rest_framework_json_api/relations.py index 044b6f9f..82b94cd5 100644 --- a/rest_framework_json_api/relations.py +++ b/rest_framework_json_api/relations.py @@ -116,14 +116,12 @@ def get_links(self, obj=None, lookup_field='pk'): }) self_link = self.get_url('self', self.self_link_view_name, self_kwargs, request) - """ - Assuming RelatedField will be declared in two ways: - 1. url(r'^authors/(?P[^/.]+)/(?P\w+)/$', - AuthorViewSet.as_view({'get': 'retrieve_related'})) - 2. url(r'^authors/(?P[^/.]+)/bio/$', - AuthorBioViewSet.as_view({'get': 'retrieve'})) - So, if related_link_url_kwarg == 'pk' it will add 'related_field' parameter to reverse() - """ + # Assuming RelatedField will be declared in two ways: + # 1. url(r'^authors/(?P[^/.]+)/(?P\w+)/$', + # AuthorViewSet.as_view({'get': 'retrieve_related'})) + # 2. url(r'^authors/(?P[^/.]+)/bio/$', + # AuthorBioViewSet.as_view({'get': 'retrieve'})) + # So, if related_link_url_kwarg == 'pk' it will add 'related_field' parameter to reverse() if self.related_link_url_kwarg == 'pk': related_kwargs = self_kwargs else: diff --git a/setup.cfg b/setup.cfg index dd743ab2..effb04ad 100644 --- a/setup.cfg +++ b/setup.cfg @@ -5,12 +5,13 @@ test = pytest universal = 1 [flake8] -ignore = F405 +ignore = F405,W504 max-line-length = 100 exclude = - docs/conf.py, build, + docs/conf.py, migrations, + .eggs .tox, [isort] @@ -21,7 +22,12 @@ known_localfolder = example known_standard_library = mock line_length = 100 multi_line_output = 3 -skip=migrations,.tox,docs/conf.py +skip= + build, + docs/conf.py, + migrations, + .eggs + .tox, [coverage:report] omit=