diff --git a/rest_framework_json_api/serializers.py b/rest_framework_json_api/serializers.py index 0b4a8dfd..1ac504ab 100644 --- a/rest_framework_json_api/serializers.py +++ b/rest_framework_json_api/serializers.py @@ -165,12 +165,11 @@ def get_fields(self): found_reserved_field_names = self._reserved_field_names.intersection( fields.keys() ) - if found_reserved_field_names: - raise AttributeError( - f"Serializer class {self.__class__.__module__}.{self.__class__.__qualname__} " - f"uses following reserved field name(s) which is not allowed: " - f"{', '.join(sorted(found_reserved_field_names))}" - ) + assert not found_reserved_field_names, ( + f"Serializer class {self.__class__.__module__}.{self.__class__.__qualname__} " + f"uses following reserved field name(s) which is not allowed: " + f"{', '.join(sorted(found_reserved_field_names))}" + ) if "type" in fields: # see https://jsonapi.org/format/#document-resource-object-fields diff --git a/tests/test_serializers.py b/tests/test_serializers.py index 70bb140f..19ee23d6 100644 --- a/tests/test_serializers.py +++ b/tests/test_serializers.py @@ -37,7 +37,7 @@ class Meta: def test_reserved_field_names(): - with pytest.raises(AttributeError) as e: + with pytest.raises(AssertionError) as e: class ReservedFieldNamesSerializer(serializers.Serializer): meta = serializers.CharField()