Skip to content

Support for default DRF Serializers (fixing wrong model type) #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
jarekwg opened this issue Sep 8, 2016 · 0 comments
Closed
2 tasks done

Support for default DRF Serializers (fixing wrong model type) #273

jarekwg opened this issue Sep 8, 2016 · 0 comments

Comments

@jarekwg
Copy link
Contributor

jarekwg commented Sep 8, 2016

Split off #270

The most recent version broke support for default DRF serializers for reverse and m2m relations (the wrong model type gets returned).

Although the recommended way is to use serializers supplied by jsonapi, we should try to maintain support for drf serializers so long as it's not too big of a job to do so.

  • Add failing tests (using from rest_framework import serializers vs. from restframework_json_api import serializers
  • Fix breaking change (probably a bug in utils.get_related_resource_type)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant