Skip to content

Included key with get_serializer_class #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snewcomer opened this issue Feb 19, 2016 · 3 comments
Closed

Included key with get_serializer_class #209

snewcomer opened this issue Feb 19, 2016 · 3 comments

Comments

@snewcomer
Copy link
Contributor

get_serializer_class method on the view doesn't work when trying to get included resources. Is this a pull request you would be open to (w/ tests of course!)?
@snewcomer
Copy link
Contributor Author

This line seems to be the source of the err.

django-rest-framework-json-api/rest_framework_json_api/serializers.py

Line 97 in 4488068

this_serializer_class = view.serializer_class

@jerel
Copy link
Member

jerel commented Feb 22, 2016

@snewcomer from what I see that seems it should be replaced with a call to get_serializer_class. I would welcome a PR with test coverage

@jerel
Copy link
Member

jerel commented Mar 15, 2016

Closed by #213

@jerel jerel closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerel @snewcomer