Skip to content

Commit fadbad6

Browse files
committed
Renamed mixins
1 parent cc74ce7 commit fadbad6

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

rest_framework_json_api/views.py

+14-5
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class PrefetchForIncludesHelperMixin(object):
3535

3636
def __init__(self, *args, **kwargs):
3737
warnings.warn("PrefetchForIncludesHelperMixin is deprecated. "
38-
"Use SelectAndPrefetchForIncludesMixin instead",
38+
"Use PreloadIncludesMixin instead",
3939
DeprecationWarning)
4040
super(PrefetchForIncludesHelperMixin, self).__init__(*args, **kwargs)
4141

@@ -107,10 +107,10 @@ def get_queryset(self):
107107
return qs
108108

109109

110-
class AutoPrefetchMixin(object):
110+
class AutoPreloadMixin(object):
111111
def get_queryset(self, *args, **kwargs):
112112
""" This mixin adds automatic prefetching for OneToOne and ManyToMany fields. """
113-
qs = super(AutoPrefetchMixin, self).get_queryset(*args, **kwargs)
113+
qs = super(AutoPreloadMixin, self).get_queryset(*args, **kwargs)
114114
included_resources = get_included_resources(self.request)
115115

116116
for included in included_resources:
@@ -154,6 +154,15 @@ def get_queryset(self, *args, **kwargs):
154154
return qs
155155

156156

157+
class AutoPrefetchMixin(AutoPreloadMixin):
158+
159+
def __init__(self, *args, **kwargs):
160+
warnings.warn("AutoPrefetchMixin is deprecated. "
161+
"Use AutoPreloadMixin instead",
162+
DeprecationWarning)
163+
super(AutoPrefetchMixin, self).__init__(*args, **kwargs)
164+
165+
157166
class RelatedMixin(object):
158167
"""
159168
This mixin handles all related entities, whose Serializers are declared in "related_serializers"
@@ -231,14 +240,14 @@ def get_related_instance(self):
231240
raise NotFound
232241

233242

234-
class ModelViewSet(AutoPrefetchMixin,
243+
class ModelViewSet(AutoPreloadMixin,
235244
PreloadIncludesMixin,
236245
RelatedMixin,
237246
viewsets.ModelViewSet):
238247
pass
239248

240249

241-
class ReadOnlyModelViewSet(AutoPrefetchMixin,
250+
class ReadOnlyModelViewSet(AutoPreloadMixin,
242251
PreloadIncludesMixin,
243252
RelatedMixin,
244253
viewsets.ReadOnlyModelViewSet):

0 commit comments

Comments
 (0)