Merge pull request #164 from django-json-api/feature/utils_overrides

Make the renderer subclassable

Author: jerel

example/tests/unit/test_renderer_class_methods.py

@@ -0,0 +1,50 @@
+import pytest
+from django.contrib.auth import get_user_model
+
+from rest_framework_json_api import serializers
+from rest_framework_json_api.renderers import JSONRenderer
+
+pytestmark = pytest.mark.django_db
+
+class ResourceSerializer(serializers.ModelSerializer):
+    class Meta:
+        fields = ('username',)
+        model = get_user_model()
+
+
+def test_build_json_resource_obj():
+    resource = {
+        'pk': 1,
+        'username': 'Alice',
+    }
+
+    serializer = ResourceSerializer(data={'username': 'Alice'})
+    serializer.is_valid()
+    resource_instance = serializer.save()
+
+    output = {
+        'type': 'user',
+        'id': '1',
+        'attributes': {
+            'username': 'Alice'
+        },
+    }
+
+    assert JSONRenderer.build_json_resource_obj(
+        serializer.fields, resource, resource_instance, 'user') == output
+
+
+def test_extract_attributes():
+    fields = {
+        'id': serializers.Field(),
+        'username': serializers.Field(),
+        'deleted': serializers.ReadOnlyField(),
+    }
+    resource = {'id': 1, 'deleted': None, 'username': 'jerel'}
+    expected = {
+        'username': 'jerel',
+        'deleted': None
+    }
+    assert sorted(JSONRenderer.extract_attributes(fields, resource)) == sorted(expected), 'Regular fields should be extracted'
+    assert sorted(JSONRenderer.extract_attributes(fields, {})) == sorted(
+        {'username': ''}), 'Should not extract read_only fields on empty serializer'

example/tests/unit/test_utils.py

@@ -16,7 +16,7 @@
 
 
 class ResourceSerializer(serializers.ModelSerializer):
-    class Meta():
+    class Meta:
         fields = ('username',)
         model = get_user_model()
 
@@ -86,44 +86,6 @@ def test_format_relation_name():
     assert utils.format_relation_name('first_name', 'camelize') == 'firstNames'
 
 
-def test_build_json_resource_obj():
-    resource = {
-        'pk': 1,
-        'username': 'Alice',
-    }
-
-    serializer = ResourceSerializer(data={'username': 'Alice'})
-    serializer.is_valid()
-    resource_instance = serializer.save()
-
-    output = {
-        'type': 'user',
-        'id': '1',
-        'attributes': {
-            'username': 'Alice'
-        },
-    }
-
-    assert utils.build_json_resource_obj(
-        serializer.fields, resource, resource_instance, 'user') == output
-
-
-def test_extract_attributes():
-    fields = {
-        'id': serializers.Field(),
-        'username': serializers.Field(),
-        'deleted': serializers.ReadOnlyField(),
-    }
-    resource = {'id': 1, 'deleted': None, 'username': 'jerel'}
-    expected = {
-        'username': 'jerel',
-        'deleted': None
-    }
-    assert sorted(utils.extract_attributes(fields, resource)) == sorted(expected), 'Regular fields should be extracted'
-    assert sorted(utils.extract_attributes(fields, {})) == sorted(
-        {'username': ''}), 'Should not extract read_only fields on empty serializer'
-
-
 class SerializerWithIncludedSerializers(EntrySerializer):
     included_serializers = {
         'blog': BlogSerializer,