From 8f167b887a6b8af98f0d53ab4958fc54d170cd36 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Thu, 31 Oct 2019 17:25:27 -0400 Subject: [PATCH 01/22] eclipse-base update for 4.13 (#480) --- _ext/eclipse-base/CHANGES.md | 4 ++++ _ext/eclipse-base/gradle.properties | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/_ext/eclipse-base/CHANGES.md b/_ext/eclipse-base/CHANGES.md index eec844b2a0..78fca2eea3 100644 --- a/_ext/eclipse-base/CHANGES.md +++ b/_ext/eclipse-base/CHANGES.md @@ -1,5 +1,9 @@ # spotless-eclipse-base +### Version 3.3.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-base))) + +* Added support of Eclipse 4.13 framework. ([#480](https://github.com/diffplug/spotless/issues/480)) + ### Version 3.2.1 - September 3rd 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-base))) * Fixed deletion of temporary workspace. ([#447](https://github.com/diffplug/spotless/issues/447)) diff --git a/_ext/eclipse-base/gradle.properties b/_ext/eclipse-base/gradle.properties index aebbc9672a..80fc902103 100644 --- a/_ext/eclipse-base/gradle.properties +++ b/_ext/eclipse-base/gradle.properties @@ -1,7 +1,7 @@ # Mayor versions correspond to the supported Eclipse core version. # Minor version is incremented for features or incompatible changes (including changes to supported dependency versions). # Patch version is incremented for backward compatible patches of this library. -ext_version=3.2.1 +ext_version=3.3.0 ext_artifactId=spotless-eclipse-base ext_description=Eclipse bundle controller and services for Spotless @@ -12,7 +12,7 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile dependencies -VER_ECLIPSE_CORE_RESOURCES=[3.13.400,4.0.0[ +VER_ECLIPSE_CORE_RESOURCES=[3.13.500,4.0.0[ # Provided dependencies VER_SLF4J=[1.6,2.0[ \ No newline at end of file From 12602464ab16bd08856f5858476a6c59faaba640 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Thu, 31 Oct 2019 17:25:55 -0400 Subject: [PATCH 02/22] eclipse-jdt update for 4.13 (#480) --- _ext/eclipse-jdt/gradle.properties | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/_ext/eclipse-jdt/gradle.properties b/_ext/eclipse-jdt/gradle.properties index 48116f43ec..1c8d0c21da 100644 --- a/_ext/eclipse-jdt/gradle.properties +++ b/_ext/eclipse-jdt/gradle.properties @@ -1,6 +1,6 @@ # Mayor/Minor versions correspond to the minimum Eclipse version supported/tested. # Patch version is incremented for backward compatible patches of this library. -ext_version=4.12.0 +ext_version=4.13.0 ext_artifactId=spotless-eclipse-jdt ext_description=Eclipse's JDT formatter bundled for Spotless @@ -11,5 +11,5 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile -VER_ECLIPSE_JDT_CORE=[3.12.0,4.0.0[ -VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ +VER_ECLIPSE_JDT_CORE=[3.19.0,4.0.0[ +VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ From 85e2f33b11497225ba7d2002effc58a7231cea09 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Thu, 31 Oct 2019 17:26:16 -0400 Subject: [PATCH 03/22] eclipse-cdt update for 4.13 (#480) --- _ext/eclipse-cdt/CHANGES.md | 4 ++++ _ext/eclipse-cdt/gradle.properties | 11 +++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/_ext/eclipse-cdt/CHANGES.md b/_ext/eclipse-cdt/CHANGES.md index 41d28a984b..65d123a082 100644 --- a/_ext/eclipse-cdt/CHANGES.md +++ b/_ext/eclipse-cdt/CHANGES.md @@ -1,5 +1,9 @@ # spotless-eclipse-cdt +### Version 9.9.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) + +* Switch to Eclipse CDT release 9.9 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). + ### Version 9.8.0 - July 24th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) * Switch to Eclipse CDT release 9.8 for Eclipse 4.12 ([#423](https://github.com/diffplug/spotless/pull/423)). diff --git a/_ext/eclipse-cdt/gradle.properties b/_ext/eclipse-cdt/gradle.properties index 168e8037f0..0b5c9b0287 100644 --- a/_ext/eclipse-cdt/gradle.properties +++ b/_ext/eclipse-cdt/gradle.properties @@ -1,7 +1,7 @@ # Versions correspond to the Eclipse-CDT version used for the fat-JAR. # See https://www.eclipse.org/cdt/ for further information about Eclipse-CDT versions. # Patch version can be incremented independently for backward compatible patches of this library. -ext_version=9.8.0 +ext_version=9.9.0 ext_artifactId=spotless-eclipse-cdt ext_description=Eclipse's CDT C/C++ formatter bundled for Spotless ext_org=diffplug @@ -11,11 +11,10 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile dependencies -VER_ECLIPSE_CDT=9.7 -VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ -VER_ECLISPE_JFACE=[3.12.0,4.0.0[ -VER_ECLISPE_WORKBENCH=[3.11.0,4.0.0[ -VER_ECLISPE_PLATFORM=[3.6.0,4.0.0[ +VER_ECLIPSE_CDT=9.9 +VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ +VER_ECLISPE_JFACE=[3.15.300,4.0.0[ +VER_ECLISPE_PLATFORM=[3.6.700,4.0.0[ VER_IBM_ICU=[61,62[ # Provided dependencies From 02e322389585aeb2fb1269798c9aaab50dbbf3c2 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Thu, 31 Oct 2019 17:30:09 -0400 Subject: [PATCH 04/22] eclipse-wtp update for 4.13 (#480) --- _ext/eclipse-wtp/CHANGES.md | 4 ++++ _ext/eclipse-wtp/gradle.properties | 14 +++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/_ext/eclipse-wtp/CHANGES.md b/_ext/eclipse-wtp/CHANGES.md index 0e612c817f..1175b93d9c 100644 --- a/_ext/eclipse-wtp/CHANGES.md +++ b/_ext/eclipse-wtp/CHANGES.md @@ -1,5 +1,9 @@ # spotless-eclipse-wtp +### Version 3.15.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-wtp))) + +* Switch to Eclipse WTP release 3.15.0 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). + ### Version 3.14.0 - July 24th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-wtp))) * Switch to Eclipse WTP release 3.14.0 for Eclipse 4.12 ([#423](https://github.com/diffplug/spotless/pull/423)). diff --git a/_ext/eclipse-wtp/gradle.properties b/_ext/eclipse-wtp/gradle.properties index a5f52ed9ea..7f31e2f146 100644 --- a/_ext/eclipse-wtp/gradle.properties +++ b/_ext/eclipse-wtp/gradle.properties @@ -1,7 +1,7 @@ # Versions correspond to the Eclipse-WTP version used for the fat-JAR. # See https://www.eclipse.org/webtools/ for further information about Eclipse-WTP versions. # Patch version can be incremented independently for backward compatible patches of this library. -ext_version=3.14.0 +ext_version=3.15.0 ext_artifactId=spotless-eclipse-wtp ext_description=Eclipse's WTP formatters bundled for Spotless @@ -12,13 +12,13 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile -VER_ECLIPSE_WTP=2019-06 -VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ +VER_ECLIPSE_WTP=2019-09 +VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ VER_IBM_ICU=[61,62[ -VER_ECLISPE_EMF=[2.12.0,3.0.0[ -VER_ECLISPE_PLATFORM=[3.6.0,4.0.0[ -VER_ECLISPE_JFACE=[3.12.0,4.0.0[ -VER_ECLISPE_EFS=[1.6.0,2.0.0[ +VER_ECLISPE_EMF=[2.16.0,3.0.0[ +VER_ECLISPE_PLATFORM=[3.8.0,4.0.0[ +VER_ECLISPE_JFACE=[3.15.300,4.0.0[ +VER_ECLISPE_EFS=[1.7.500,2.0.0[ VER_ECLISPE_XSD=[2.12.0,3.0.0[ # Provided dependencies From 1b8ef412319eae3dcdd2d119892243f549d7790c Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Thu, 31 Oct 2019 17:30:28 -0400 Subject: [PATCH 05/22] eclipse-groovy update for 4.13 (#480) --- _ext/eclipse-groovy/CHANGES.md | 4 ++++ _ext/eclipse-groovy/gradle.properties | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/_ext/eclipse-groovy/CHANGES.md b/_ext/eclipse-groovy/CHANGES.md index f75e1a3153..d99b18b69d 100644 --- a/_ext/eclipse-groovy/CHANGES.md +++ b/_ext/eclipse-groovy/CHANGES.md @@ -1,5 +1,9 @@ # spotless-eclipse-groovy +### Version 3.5.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-groovy))) + +* Switch to Groovy-Eclipse release 3.5.0 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). + ### Version 3.4.0 - July 24th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-groovy))) * Switch to Groovy-Eclipse release 3.4.0 for Eclipse 4.12 using Groovy-Indy 3.0.0 ([#423](https://github.com/diffplug/spotless/pull/423)). diff --git a/_ext/eclipse-groovy/gradle.properties b/_ext/eclipse-groovy/gradle.properties index 0c2867e315..2f6145fb43 100644 --- a/_ext/eclipse-groovy/gradle.properties +++ b/_ext/eclipse-groovy/gradle.properties @@ -1,7 +1,7 @@ # Versions correspond to the Groovy-Eclipse version used for the fat-JAR. # See https://github.com/groovy/groovy-eclipse/releases for further information about Groovy-Eclipse versions. # Patch version can be incremented independently for backward compatible patches of this library. -ext_version=3.4.0 +ext_version=3.5.0 ext_artifactId=spotless-eclipse-groovy ext_description=Groovy Eclipse's formatter bundled for Spotless @@ -12,10 +12,10 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile -VER_ECLIPSE=4.12 -VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ -VER_ECLISPE_JFACE=[3.12.0,4.0.0[ -VER_GRECLIPSE=3.4.0 +VER_ECLIPSE=4.13 +VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ +VER_ECLISPE_JFACE=[3.15.300,4.0.0[ +VER_GRECLIPSE=3.5.0 VER_GROOVY=3.0.0 # Provided dependencies From ce6662f164cde6bf424cf3e69d6a2848bc650549 Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Thu, 31 Oct 2019 15:14:32 -0700 Subject: [PATCH 06/22] Revert "eclipse-base update for 4.13 (#480)" This reverts commit 8f167b887a6b8af98f0d53ab4958fc54d170cd36. --- _ext/eclipse-base/CHANGES.md | 4 ---- _ext/eclipse-base/gradle.properties | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/_ext/eclipse-base/CHANGES.md b/_ext/eclipse-base/CHANGES.md index 78fca2eea3..eec844b2a0 100644 --- a/_ext/eclipse-base/CHANGES.md +++ b/_ext/eclipse-base/CHANGES.md @@ -1,9 +1,5 @@ # spotless-eclipse-base -### Version 3.3.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-base))) - -* Added support of Eclipse 4.13 framework. ([#480](https://github.com/diffplug/spotless/issues/480)) - ### Version 3.2.1 - September 3rd 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-base))) * Fixed deletion of temporary workspace. ([#447](https://github.com/diffplug/spotless/issues/447)) diff --git a/_ext/eclipse-base/gradle.properties b/_ext/eclipse-base/gradle.properties index 80fc902103..aebbc9672a 100644 --- a/_ext/eclipse-base/gradle.properties +++ b/_ext/eclipse-base/gradle.properties @@ -1,7 +1,7 @@ # Mayor versions correspond to the supported Eclipse core version. # Minor version is incremented for features or incompatible changes (including changes to supported dependency versions). # Patch version is incremented for backward compatible patches of this library. -ext_version=3.3.0 +ext_version=3.2.1 ext_artifactId=spotless-eclipse-base ext_description=Eclipse bundle controller and services for Spotless @@ -12,7 +12,7 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile dependencies -VER_ECLIPSE_CORE_RESOURCES=[3.13.500,4.0.0[ +VER_ECLIPSE_CORE_RESOURCES=[3.13.400,4.0.0[ # Provided dependencies VER_SLF4J=[1.6,2.0[ \ No newline at end of file From d4d01bfccbd3e901aecaef4156784cd01772464a Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Thu, 31 Oct 2019 15:17:21 -0700 Subject: [PATCH 07/22] Revert "eclipse-jdt update for 4.13 (#480)" This reverts commit 12602464ab16bd08856f5858476a6c59faaba640. --- _ext/eclipse-jdt/gradle.properties | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/_ext/eclipse-jdt/gradle.properties b/_ext/eclipse-jdt/gradle.properties index 1c8d0c21da..48116f43ec 100644 --- a/_ext/eclipse-jdt/gradle.properties +++ b/_ext/eclipse-jdt/gradle.properties @@ -1,6 +1,6 @@ # Mayor/Minor versions correspond to the minimum Eclipse version supported/tested. # Patch version is incremented for backward compatible patches of this library. -ext_version=4.13.0 +ext_version=4.12.0 ext_artifactId=spotless-eclipse-jdt ext_description=Eclipse's JDT formatter bundled for Spotless @@ -11,5 +11,5 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile -VER_ECLIPSE_JDT_CORE=[3.19.0,4.0.0[ -VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ +VER_ECLIPSE_JDT_CORE=[3.12.0,4.0.0[ +VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ From 6c452fea79bdf51071b3873a35a39b9385b2477e Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Thu, 31 Oct 2019 15:20:13 -0700 Subject: [PATCH 08/22] Revert "eclipse-cdt update for 4.13 (#480)" This reverts commit 85e2f33b11497225ba7d2002effc58a7231cea09. --- _ext/eclipse-cdt/CHANGES.md | 4 ---- _ext/eclipse-cdt/gradle.properties | 11 ++++++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/_ext/eclipse-cdt/CHANGES.md b/_ext/eclipse-cdt/CHANGES.md index 65d123a082..41d28a984b 100644 --- a/_ext/eclipse-cdt/CHANGES.md +++ b/_ext/eclipse-cdt/CHANGES.md @@ -1,9 +1,5 @@ # spotless-eclipse-cdt -### Version 9.9.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) - -* Switch to Eclipse CDT release 9.9 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). - ### Version 9.8.0 - July 24th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) * Switch to Eclipse CDT release 9.8 for Eclipse 4.12 ([#423](https://github.com/diffplug/spotless/pull/423)). diff --git a/_ext/eclipse-cdt/gradle.properties b/_ext/eclipse-cdt/gradle.properties index 0b5c9b0287..168e8037f0 100644 --- a/_ext/eclipse-cdt/gradle.properties +++ b/_ext/eclipse-cdt/gradle.properties @@ -1,7 +1,7 @@ # Versions correspond to the Eclipse-CDT version used for the fat-JAR. # See https://www.eclipse.org/cdt/ for further information about Eclipse-CDT versions. # Patch version can be incremented independently for backward compatible patches of this library. -ext_version=9.9.0 +ext_version=9.8.0 ext_artifactId=spotless-eclipse-cdt ext_description=Eclipse's CDT C/C++ formatter bundled for Spotless ext_org=diffplug @@ -11,10 +11,11 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile dependencies -VER_ECLIPSE_CDT=9.9 -VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ -VER_ECLISPE_JFACE=[3.15.300,4.0.0[ -VER_ECLISPE_PLATFORM=[3.6.700,4.0.0[ +VER_ECLIPSE_CDT=9.7 +VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ +VER_ECLISPE_JFACE=[3.12.0,4.0.0[ +VER_ECLISPE_WORKBENCH=[3.11.0,4.0.0[ +VER_ECLISPE_PLATFORM=[3.6.0,4.0.0[ VER_IBM_ICU=[61,62[ # Provided dependencies From 0b00d79cd9bb1ebed96b45f0b37c0c4d670b483a Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Thu, 31 Oct 2019 21:53:20 -0700 Subject: [PATCH 09/22] Publish eclipse-cdt 9.8.1. --- CHANGES.md | 4 +++- _ext/eclipse-cdt/CHANGES.md | 8 +++++++- _ext/eclipse-cdt/gradle.properties | 4 ++-- .../spotless/extra/eclipse_cdt_formatter/v4.12.0.lockfile | 2 +- plugin-gradle/CHANGES.md | 5 ++++- plugin-maven/CHANGES.md | 4 +++- 6 files changed, 20 insertions(+), 7 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 18f971e36f..5d033ad89c 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,10 +6,11 @@ You might be looking for: - [plugin-maven/CHANGES.md](plugin-maven/CHANGES.md) ### Version 1.26.0-SNAPSHOT - TBD (javadoc [lib](https://diffplug.github.io/spotless/javadoc/spotless-lib/snapshot/) [lib-extra](https://diffplug.github.io/spotless/javadoc/spotless-lib-extra/snapshot/), [snapshot repo](https://oss.sonatype.org/content/repositories/snapshots/com/diffplug/spotless/)) -* Fix project URLs in poms. ([#478](https://github.com/diffplug/spotless/pull/478)) +* Fix project URLs in poms. ([#478](https://github.com/diffplug/spotless/pull/478)) * Fix `ImportSorter` crashing with empty files. ([#474](https://github.com/diffplug/spotless/pull/474)) * Fixes [#305](https://github.com/diffplug/spotless/issues/305) StringIndexOutOfBoundsException for empty Groovy file when performing importOrder +* Bugfix: CDT version `4.12.0` now properly uses `9.8`, whereas before it used `9.7`. ([#482](https://github.com/diffplug/spotless/pull/482#discussion_r341380884)) ### Version 1.25.0 - October 6th 2019 (javadoc [lib](https://diffplug.github.io/spotless/javadoc/spotless-lib/1.25.0/) [lib-extra](https://diffplug.github.io/spotless/javadoc/spotless-lib-extra/1.25.0/), artifact [lib]([jcenter](https://bintray.com/diffplug/opensource/spotless-lib), [lib-extra]([jcenter](https://bintray.com/diffplug/opensource/spotless-lib-extra))) @@ -40,6 +41,7 @@ You might be looking for: * Updated default eclipse-groovy from 4.10 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). * Updated default eclipse-jdt from 4.11.0 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). * Updated default eclipse-cdt from 4.11.0 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). + * **KNOWN BUG - accidentally published CDT 9.7 rather than 9.8 - fixed in 1.26.0** * Added new maven coordinates for scalafmt 2.0.0+, maintains backwards compatability ([#415](https://github.com/diffplug/spotless/issues/415)) ### Version 1.23.1 - June 17th 2019 (javadoc [lib](https://diffplug.github.io/spotless/javadoc/spotless-lib/1.23.1/) [lib-extra](https://diffplug.github.io/spotless/javadoc/spotless-lib-extra/1.23.1/), artifact [lib]([jcenter](https://bintray.com/diffplug/opensource/spotless-lib), [lib-extra]([jcenter](https://bintray.com/diffplug/opensource/spotless-lib-extra))) diff --git a/_ext/eclipse-cdt/CHANGES.md b/_ext/eclipse-cdt/CHANGES.md index 41d28a984b..c539eeb0bd 100644 --- a/_ext/eclipse-cdt/CHANGES.md +++ b/_ext/eclipse-cdt/CHANGES.md @@ -1,12 +1,18 @@ # spotless-eclipse-cdt +### Version 9.8.1 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) + +* Really publish Eclipse CDT release 9.8 for Eclipse 4.12 ([#482](https://github.com/diffplug/spotless/pull/482)). + ### Version 9.8.0 - July 24th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) +**Known bug - we actually published Eclipse CDT 9.7 instead of 9.8 - fixed in 9.8.1** + * Switch to Eclipse CDT release 9.8 for Eclipse 4.12 ([#423](https://github.com/diffplug/spotless/pull/423)). ### Version 9.7.0 - March 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) -* Switch to Eclipse CTD release 9.7 for Eclipse 4.11 ([#389](https://github.com/diffplug/spotless/pull/389)). +* Switch to Eclipse CDT release 9.7 for Eclipse 4.11 ([#389](https://github.com/diffplug/spotless/pull/389)). * Include Eclipse logging allowing formatter warnings/errors to be logged via SLF4J ([#236](https://github.com/diffplug/spotless/issues/236)). ### Version 9.4.5 - February 25th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) diff --git a/_ext/eclipse-cdt/gradle.properties b/_ext/eclipse-cdt/gradle.properties index 168e8037f0..fdf8d34ad0 100644 --- a/_ext/eclipse-cdt/gradle.properties +++ b/_ext/eclipse-cdt/gradle.properties @@ -1,7 +1,7 @@ # Versions correspond to the Eclipse-CDT version used for the fat-JAR. # See https://www.eclipse.org/cdt/ for further information about Eclipse-CDT versions. # Patch version can be incremented independently for backward compatible patches of this library. -ext_version=9.8.0 +ext_version=9.8.1 ext_artifactId=spotless-eclipse-cdt ext_description=Eclipse's CDT C/C++ formatter bundled for Spotless ext_org=diffplug @@ -11,7 +11,7 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile dependencies -VER_ECLIPSE_CDT=9.7 +VER_ECLIPSE_CDT=9.8 VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ VER_ECLISPE_JFACE=[3.12.0,4.0.0[ VER_ECLISPE_WORKBENCH=[3.11.0,4.0.0[ diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.12.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.12.0.lockfile index a894c93136..6fd639528a 100644 --- a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.12.0.lockfile +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.12.0.lockfile @@ -1,5 +1,5 @@ # Spotless formatter based on CDT version 9.8.0 (see https://www.eclipse.org/cdt/) -com.diffplug.spotless:spotless-eclipse-cdt:9.8.0 +com.diffplug.spotless:spotless-eclipse-cdt:9.8.1 com.diffplug.spotless:spotless-eclipse-base:3.2.1 com.google.code.findbugs:annotations:3.0.0 com.google.code.findbugs:jsr305:3.0.0 diff --git a/plugin-gradle/CHANGES.md b/plugin-gradle/CHANGES.md index dc034781d0..e484fee2ac 100644 --- a/plugin-gradle/CHANGES.md +++ b/plugin-gradle/CHANGES.md @@ -1,10 +1,12 @@ # spotless-plugin-gradle releases ### Version 3.26.0-SNAPSHOT - TBD ([javadoc](https://diffplug.github.io/spotless/javadoc/snapshot/), [snapshot](https://oss.sonatype.org/content/repositories/snapshots/com/diffplug/spotless/spotless-plugin-gradle/)) -* Fix project URLs in poms. ([#478](https://github.com/diffplug/spotless/pull/478)) +* Fix project URLs in poms. ([#478](https://github.com/diffplug/spotless/pull/478)) * Fix `ImportSorter` crashing with empty files. ([#474](https://github.com/diffplug/spotless/pull/474)) * Fixes [#305](https://github.com/diffplug/spotless/issues/305) StringIndexOutOfBoundsException for empty Groovy file when performing importOrder +* Bugfix: CDT version `4.12.0` now properly uses `9.8`, whereas before it used `9.7`. ([#482](https://github.com/diffplug/spotless/pull/482#discussion_r341380884)) + ### Version 3.25.0 - October 6th 2019 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-plugin-gradle/3.25.0/), [jcenter](https://bintray.com/diffplug/opensource/spotless-plugin-gradle/3.25.0)) @@ -42,6 +44,7 @@ * Updated default eclipse-groovy from 4.10 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). * Updated default eclipse-jdt from 4.11.0 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). * Updated default eclipse-cdt from 4.11.0 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). + * **KNOWN BUG - accidentally published CDT 9.7 rather than 9.8 - fixed in 3.26.0** * Added new maven coordinates for scalafmt 2.0.0+, maintains backwards compatability ([#415](https://github.com/diffplug/spotless/issues/415)) ### Version 3.23.1 - June 17th 2019 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-plugin-gradle/3.23.1/), [jcenter](https://bintray.com/diffplug/opensource/spotless-plugin-gradle/3.23.1)) diff --git a/plugin-maven/CHANGES.md b/plugin-maven/CHANGES.md index 16e2617644..68eb4b768b 100644 --- a/plugin-maven/CHANGES.md +++ b/plugin-maven/CHANGES.md @@ -1,10 +1,11 @@ # spotless-plugin-maven releases ### Version 1.26.0-SNAPSHOT - TBD ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-maven-plugin/snapshot/), [snapshot](https://oss.sonatype.org/content/repositories/snapshots/com/diffplug/spotless/spotless-maven-plugin/)) -* Fix project URLs in poms. ([#478](https://github.com/diffplug/spotless/pull/478)) +* Fix project URLs in poms. ([#478](https://github.com/diffplug/spotless/pull/478)) * Fix `ImportSorter` crashing with empty files. ([#474](https://github.com/diffplug/spotless/pull/474)) * Fixes [#305](https://github.com/diffplug/spotless/issues/305) StringIndexOutOfBoundsException for empty Groovy file when performing importOrder +* Bugfix: CDT version `4.12.0` now properly uses `9.8`, whereas before it used `9.7`. ([#482](https://github.com/diffplug/spotless/pull/482#discussion_r341380884)) ### Version 1.25.1 - October 7th 2019 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-maven-plugin/1.25.1/), [jcenter](https://bintray.com/diffplug/opensource/spotless-maven-plugin/1.25.1)) @@ -33,6 +34,7 @@ * Updated default eclipse-groovy from 4.10 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). * Updated default eclipse-jdt from 4.11.0 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). * Updated default eclipse-cdt from 4.11.0 to 4.12.0 ([#423](https://github.com/diffplug/spotless/pull/423)). + * **KNOWN BUG - accidentally published CDT 9.7 rather than 9.8 - fixed in 1.26.0** * Added new maven coordinates for scalafmt 2.0.0+, maintains backwards compatability ([#415](https://github.com/diffplug/spotless/issues/415)) ### Version 1.23.1 - June 17th 2019 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-maven-plugin/1.23.1/), [jcenter](https://bintray.com/diffplug/opensource/spotless-maven-plugin/1.23.1)) From d1c85121e46ce4168b32cd9842f57e620ee4a6c1 Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Fri, 1 Nov 2019 00:27:03 -0700 Subject: [PATCH 10/22] Publish eclipse-cdt 9.9.0. --- _ext/eclipse-cdt/CHANGES.md | 4 ++++ _ext/eclipse-cdt/gradle.properties | 11 +++++------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/_ext/eclipse-cdt/CHANGES.md b/_ext/eclipse-cdt/CHANGES.md index c539eeb0bd..f5df3fd87f 100644 --- a/_ext/eclipse-cdt/CHANGES.md +++ b/_ext/eclipse-cdt/CHANGES.md @@ -1,5 +1,9 @@ # spotless-eclipse-cdt +### Version 9.9.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) + +* Switch to Eclipse CDT release 9.9 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). + ### Version 9.8.1 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-cdt))) * Really publish Eclipse CDT release 9.8 for Eclipse 4.12 ([#482](https://github.com/diffplug/spotless/pull/482)). diff --git a/_ext/eclipse-cdt/gradle.properties b/_ext/eclipse-cdt/gradle.properties index fdf8d34ad0..f9b09e1b58 100644 --- a/_ext/eclipse-cdt/gradle.properties +++ b/_ext/eclipse-cdt/gradle.properties @@ -1,9 +1,9 @@ # Versions correspond to the Eclipse-CDT version used for the fat-JAR. # See https://www.eclipse.org/cdt/ for further information about Eclipse-CDT versions. # Patch version can be incremented independently for backward compatible patches of this library. -ext_version=9.8.1 +ext_version=9.9.0 ext_artifactId=spotless-eclipse-cdt -ext_description=Eclipse's CDT C/C++ formatter bundled for Spotless +ext_description=Eclipse''s CDT C/C++ formatter bundled for Spotless ext_org=diffplug ext_group=com.diffplug.spotless @@ -11,11 +11,10 @@ ext_group=com.diffplug.spotless ext_VER_JAVA=1.8 # Compile dependencies -VER_ECLIPSE_CDT=9.8 +VER_ECLIPSE_CDT=9.9 VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ -VER_ECLISPE_JFACE=[3.12.0,4.0.0[ -VER_ECLISPE_WORKBENCH=[3.11.0,4.0.0[ -VER_ECLISPE_PLATFORM=[3.6.0,4.0.0[ +VER_ECLISPE_JFACE=[3.15.300,4.0.0[ +VER_ECLISPE_PLATFORM=[3.6.700,4.0.0[ VER_IBM_ICU=[61,62[ # Provided dependencies From 8c553634cde90128d5d1bf9b6de468453a5144a4 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Fri, 1 Nov 2019 13:56:44 -0400 Subject: [PATCH 11/22] revert extra quote (#480) --- _ext/eclipse-cdt/gradle.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_ext/eclipse-cdt/gradle.properties b/_ext/eclipse-cdt/gradle.properties index f9b09e1b58..a5109e3128 100644 --- a/_ext/eclipse-cdt/gradle.properties +++ b/_ext/eclipse-cdt/gradle.properties @@ -3,7 +3,7 @@ # Patch version can be incremented independently for backward compatible patches of this library. ext_version=9.9.0 ext_artifactId=spotless-eclipse-cdt -ext_description=Eclipse''s CDT C/C++ formatter bundled for Spotless +ext_description=Eclipse's CDT C/C++ formatter bundled for Spotless ext_org=diffplug ext_group=com.diffplug.spotless From 1c4cb7177b1985b05bbef7385ffa9eb74612cee3 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Fri, 1 Nov 2019 14:09:07 -0400 Subject: [PATCH 12/22] remove version bump to eclipse base (#480) --- _ext/eclipse-groovy/gradle.properties | 2 +- _ext/eclipse-wtp/gradle.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/_ext/eclipse-groovy/gradle.properties b/_ext/eclipse-groovy/gradle.properties index 2f6145fb43..c0eff9e8d8 100644 --- a/_ext/eclipse-groovy/gradle.properties +++ b/_ext/eclipse-groovy/gradle.properties @@ -13,7 +13,7 @@ ext_VER_JAVA=1.8 # Compile VER_ECLIPSE=4.13 -VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ +VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ VER_ECLISPE_JFACE=[3.15.300,4.0.0[ VER_GRECLIPSE=3.5.0 VER_GROOVY=3.0.0 diff --git a/_ext/eclipse-wtp/gradle.properties b/_ext/eclipse-wtp/gradle.properties index 7f31e2f146..e4e34aa965 100644 --- a/_ext/eclipse-wtp/gradle.properties +++ b/_ext/eclipse-wtp/gradle.properties @@ -13,7 +13,7 @@ ext_VER_JAVA=1.8 # Compile VER_ECLIPSE_WTP=2019-09 -VER_SPOTLESS_ECLISPE_BASE=[3.3.0,4.0.0[ +VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ VER_IBM_ICU=[61,62[ VER_ECLISPE_EMF=[2.16.0,3.0.0[ VER_ECLISPE_PLATFORM=[3.8.0,4.0.0[ From 4b63e090023c756af0123fb906dea78f7c42f527 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Fri, 1 Nov 2019 14:29:03 -0400 Subject: [PATCH 13/22] cdt/jdt eclipse 4.13 support (#480) --- .../extra/cpp/EclipseCdtFormatterStep.java | 2 +- .../extra/java/EclipseJdtFormatterStep.java | 2 +- .../eclipse_cdt_formatter/v4.13.0.lockfile | 22 +++++++++++++++++++ .../eclipse_jdt_formatter/v4.13.0.lockfile | 18 +++++++++++++++ .../cpp/EclipseCdtFormatterStepTest.java | 2 +- .../java/EclipseJdtFormatterStepTest.java | 2 +- 6 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile create mode 100644 lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile diff --git a/lib-extra/src/main/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStep.java b/lib-extra/src/main/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStep.java index a718ddea3a..f3b267bced 100644 --- a/lib-extra/src/main/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStep.java +++ b/lib-extra/src/main/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStep.java @@ -30,7 +30,7 @@ private EclipseCdtFormatterStep() {} private static final String NAME = "eclipse cdt formatter"; private static final String FORMATTER_CLASS = "com.diffplug.spotless.extra.eclipse.cdt.EclipseCdtFormatterStepImpl"; - private static final String DEFAULT_VERSION = "4.12.0"; + private static final String DEFAULT_VERSION = "4.13.0"; private static final String FORMATTER_METHOD = "format"; public static String defaultVersion() { diff --git a/lib-extra/src/main/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStep.java b/lib-extra/src/main/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStep.java index 1c68221349..0662b52a15 100644 --- a/lib-extra/src/main/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStep.java +++ b/lib-extra/src/main/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStep.java @@ -32,7 +32,7 @@ private EclipseJdtFormatterStep() {} private static final String FORMATTER_CLASS_OLD = "com.diffplug.gradle.spotless.java.eclipse.EclipseFormatterStepImpl"; private static final String FORMATTER_CLASS = "com.diffplug.spotless.extra.eclipse.java.EclipseJdtFormatterStepImpl"; private static final String MAVEN_GROUP_ARTIFACT = "com.diffplug.spotless:spotless-eclipse-jdt"; - private static final String DEFAULT_VERSION = "4.12.0"; + private static final String DEFAULT_VERSION = "4.13.0"; private static final String FORMATTER_METHOD = "format"; public static String defaultVersion() { diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile new file mode 100644 index 0000000000..b6085dc39e --- /dev/null +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile @@ -0,0 +1,22 @@ +# Spotless formatter based on CDT version 9.9.0 (see https://www.eclipse.org/cdt/) +com.diffplug.spotless:spotless-eclipse-cdt:9.9.0 +com.diffplug.spotless:spotless-eclipse-base:3.2.0 +com.google.code.findbugs:annotations:3.0.0 +com.google.code.findbugs:jsr305:3.0.0 +com.ibm.icu:icu4j:61.2 +org.eclipse.platform:org.eclipse.core.commands:3.9.500 +org.eclipse.platform:org.eclipse.core.contenttype:3.7.400 +org.eclipse.platform:org.eclipse.core.filebuffers:3.6.700 +org.eclipse.platform:org.eclipse.core.filesystem:1.7.500 +org.eclipse.platform:org.eclipse.core.jobs:3.10.500 +org.eclipse.platform:org.eclipse.core.resources:3.13.500 +org.eclipse.platform:org.eclipse.core.runtime:3.16.0 +org.eclipse.platform:org.eclipse.equinox.app:1.4.300 +org.eclipse.platform:org.eclipse.equinox.common:3.10.500 +org.eclipse.platform:org.eclipse.equinox.preferences:3.7.500 +org.eclipse.platform:org.eclipse.equinox.registry:3.8.500 +org.eclipse.platform:org.eclipse.jface.text:3.15.300 +org.eclipse.platform:org.eclipse.jface:3.17.0 +org.eclipse.platform:org.eclipse.osgi:3.15.0 +org.eclipse.platform:org.eclipse.swt:3.112.0 +org.eclipse.platform:org.eclipse.text:3.9.0 diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile new file mode 100644 index 0000000000..c3a23cb5f4 --- /dev/null +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile @@ -0,0 +1,18 @@ +# Spotless formatter based on JDT version 4.13.0 (see https://projects.eclipse.org/projects/eclipse.jdt) +# Compare tag in M2 pom with https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tag/?h=R4_13 to determine core version. +com.diffplug.spotless:spotless-eclipse-jdt:4.8.0 +com.diffplug.spotless:spotless-eclipse-base:3.2.0 +com.google.code.findbugs:annotations:3.0.0 +com.google.code.findbugs:jsr305:3.0.0 +org.eclipse.jdt:org.eclipse.jdt.core:3.19.0 +org.eclipse.platform:org.eclipse.core.commands:3.9.500 +org.eclipse.platform:org.eclipse.core.contenttype:3.7.400 +org.eclipse.platform:org.eclipse.core.jobs:3.10.500 +org.eclipse.platform:org.eclipse.core.resources:3.13.500 +org.eclipse.platform:org.eclipse.core.runtime:3.16.0 +org.eclipse.platform:org.eclipse.equinox.app:1.4.300 +org.eclipse.platform:org.eclipse.equinox.common:3.10.500 +org.eclipse.platform:org.eclipse.equinox.preferences:3.7.500 +org.eclipse.platform:org.eclipse.equinox.registry:3.8.500 +org.eclipse.platform:org.eclipse.osgi:3.15.0 +org.eclipse.platform:org.eclipse.text:3.9.0 diff --git a/lib-extra/src/test/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStepTest.java b/lib-extra/src/test/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStepTest.java index 44058bd896..079f255f93 100644 --- a/lib-extra/src/test/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStepTest.java +++ b/lib-extra/src/test/java/com/diffplug/spotless/extra/cpp/EclipseCdtFormatterStepTest.java @@ -24,7 +24,7 @@ public class EclipseCdtFormatterStepTest extends EclipseCommonTests { @Override protected String[] getSupportedVersions() { - return new String[]{"4.7.3a", "4.11.0", "4.12.0"}; + return new String[]{"4.7.3a", "4.11.0", "4.12.0", "4.13.0"}; } @Override diff --git a/lib-extra/src/test/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStepTest.java b/lib-extra/src/test/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStepTest.java index 2cb8d38b1d..04cce4fbfb 100644 --- a/lib-extra/src/test/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStepTest.java +++ b/lib-extra/src/test/java/com/diffplug/spotless/extra/java/EclipseJdtFormatterStepTest.java @@ -25,7 +25,7 @@ public class EclipseJdtFormatterStepTest extends EclipseCommonTests { @Override protected String[] getSupportedVersions() { return new String[]{"4.6.1", "4.6.2", "4.6.3", "4.7.0", "4.7.1", "4.7.2", "4.7.3a", "4.8.0", "4.9.0", "4.10.0", - "4.11.0", "4.12.0"}; + "4.11.0", "4.12.0", "4.13.0"}; } @Override From 15b33b6997ffcd3c1821e8c9733ce605b5529ec1 Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Fri, 1 Nov 2019 12:23:49 -0700 Subject: [PATCH 14/22] Bump the eclips-base dependency from 3.2.0 to 3.2.1 in the 4.13.0 lockfiles for cdt/jdt. --- .../spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile | 2 +- .../spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile index b6085dc39e..26e5c2d33a 100644 --- a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile @@ -1,6 +1,6 @@ # Spotless formatter based on CDT version 9.9.0 (see https://www.eclipse.org/cdt/) com.diffplug.spotless:spotless-eclipse-cdt:9.9.0 -com.diffplug.spotless:spotless-eclipse-base:3.2.0 +com.diffplug.spotless:spotless-eclipse-base:3.2.1 com.google.code.findbugs:annotations:3.0.0 com.google.code.findbugs:jsr305:3.0.0 com.ibm.icu:icu4j:61.2 diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile index c3a23cb5f4..4ee0adb3cf 100644 --- a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_jdt_formatter/v4.13.0.lockfile @@ -1,7 +1,7 @@ # Spotless formatter based on JDT version 4.13.0 (see https://projects.eclipse.org/projects/eclipse.jdt) # Compare tag in M2 pom with https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tag/?h=R4_13 to determine core version. com.diffplug.spotless:spotless-eclipse-jdt:4.8.0 -com.diffplug.spotless:spotless-eclipse-base:3.2.0 +com.diffplug.spotless:spotless-eclipse-base:3.2.1 com.google.code.findbugs:annotations:3.0.0 com.google.code.findbugs:jsr305:3.0.0 org.eclipse.jdt:org.eclipse.jdt.core:3.19.0 From e4ee903b1aba1a7161e4df3b7c94be7f35f19f46 Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Fri, 1 Nov 2019 12:47:59 -0700 Subject: [PATCH 15/22] Publish groovy 3.5.0 --- _ext/eclipse-groovy/CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_ext/eclipse-groovy/CHANGES.md b/_ext/eclipse-groovy/CHANGES.md index d99b18b69d..338165d806 100644 --- a/_ext/eclipse-groovy/CHANGES.md +++ b/_ext/eclipse-groovy/CHANGES.md @@ -1,6 +1,6 @@ # spotless-eclipse-groovy -### Version 3.5.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-groovy))) +### Version 3.5.0 - November 1st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-groovy))) * Switch to Groovy-Eclipse release 3.5.0 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). From 1ad30a8ec8ced92c96a41777078300ccc4c52ced Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Fri, 1 Nov 2019 17:31:48 -0400 Subject: [PATCH 16/22] eclipse platform versioning split (#480) --- _ext/eclipse-wtp/build.gradle | 4 ++-- _ext/eclipse-wtp/gradle.properties | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/_ext/eclipse-wtp/build.gradle b/_ext/eclipse-wtp/build.gradle index aed6173ddb..1dca2707c4 100644 --- a/_ext/eclipse-wtp/build.gradle +++ b/_ext/eclipse-wtp/build.gradle @@ -61,9 +61,9 @@ dependencies { compile "org.eclipse.emf:org.eclipse.emf.common:${VER_ECLISPE_EMF}" compile "org.eclipse.emf:org.eclipse.emf.ecore:${VER_ECLISPE_EMF}" // Some WPT plugins requires OSGI bundle interfaces (but not effectively used) - compile "org.eclipse.platform:org.eclipse.osgi.services:${VER_ECLISPE_PLATFORM}" + compile "org.eclipse.platform:org.eclipse.osgi.services:${VER_ECLIPSE_OSGI_SERVICES}" // Provides document data structure and file buffers for formatters - compile "org.eclipse.platform:org.eclipse.core.filebuffers:${VER_ECLISPE_PLATFORM}" + compile "org.eclipse.platform:org.eclipse.core.filebuffers:${VER_ECLIPSE_FILE_BUFFERS}" // Provides text partitioners for formatters compile ("org.eclipse.platform:org.eclipse.jface.text:${VER_ECLISPE_JFACE}") { exclude group: 'org.eclipse.platform', module: 'org.eclipse.swt' diff --git a/_ext/eclipse-wtp/gradle.properties b/_ext/eclipse-wtp/gradle.properties index e4e34aa965..b6f191d259 100644 --- a/_ext/eclipse-wtp/gradle.properties +++ b/_ext/eclipse-wtp/gradle.properties @@ -16,7 +16,8 @@ VER_ECLIPSE_WTP=2019-09 VER_SPOTLESS_ECLISPE_BASE=[3.2.0,4.0.0[ VER_IBM_ICU=[61,62[ VER_ECLISPE_EMF=[2.16.0,3.0.0[ -VER_ECLISPE_PLATFORM=[3.8.0,4.0.0[ +VER_ECLIPSE_OSGI_SERVICES=[3.8.0,4.0.0[ +VER_ECLIPSE_FILE_BUFFERS=[3.6.700,4.0.0[ VER_ECLISPE_JFACE=[3.15.300,4.0.0[ VER_ECLISPE_EFS=[1.7.500,2.0.0[ VER_ECLISPE_XSD=[2.12.0,3.0.0[ From 0309d604cc7726641c5dcdafa219bcb620a6a170 Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Mon, 4 Nov 2019 10:37:45 -0500 Subject: [PATCH 17/22] eclipse 4.13 groovy formatter (#480) --- .../extra/groovy/GrEclipseFormatterStep.java | 2 +- .../groovy_eclipse_formatter/v4.13.0.lockfile | 19 +++++++++++++++++++ .../groovy/GrEclipseFormatterStepTest.java | 2 +- 3 files changed, 21 insertions(+), 2 deletions(-) create mode 100644 lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile diff --git a/lib-extra/src/main/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStep.java b/lib-extra/src/main/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStep.java index 610393c121..19c0f1d3f1 100644 --- a/lib-extra/src/main/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStep.java +++ b/lib-extra/src/main/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStep.java @@ -35,7 +35,7 @@ private GrEclipseFormatterStep() {} private static final String FORMATTER_CLASS = "com.diffplug.spotless.extra.eclipse.groovy.GrEclipseFormatterStepImpl"; private static final String FORMATTER_CLASS_OLD = "com.diffplug.gradle.spotless.groovy.eclipse.GrEclipseFormatterStepImpl"; private static final String MAVEN_GROUP_ARTIFACT = "com.diffplug.spotless:spotless-eclipse-groovy"; - private static final String DEFAULT_VERSION = "4.12.0"; + private static final String DEFAULT_VERSION = "4.13.0"; private static final String FORMATTER_METHOD = "format"; /** Creates a formatter step using the default version for the given settings file. */ diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile new file mode 100644 index 0000000000..e54810f482 --- /dev/null +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile @@ -0,0 +1,19 @@ +# Spotless formatter based on Groovy-Eclipse version 3.5.0 (see https://github.com/groovy/groovy-eclipse/releases) +com.diffplug.spotless:spotless-eclipse-groovy:3.5.0 +com.diffplug.spotless:spotless-eclipse-base:3.2.1 +com.google.code.findbugs:annotations:3.0.0 +com.google.code.findbugs:jsr305:3.0.0 +org.eclipse.platform:org.eclipse.core.commands:3.9.500 +org.eclipse.platform:org.eclipse.core.contenttype:3.7.400 +org.eclipse.platform:org.eclipse.core.jobs:3.10.500 +org.eclipse.platform:org.eclipse.core.resources:3.13.500 +org.eclipse.platform:org.eclipse.core.runtime:3.16.0 +org.eclipse.platform:org.eclipse.equinox.app:1.4.300 +org.eclipse.platform:org.eclipse.equinox.common:3.10.500 +org.eclipse.platform:org.eclipse.equinox.preferences:3.7.500 +org.eclipse.platform:org.eclipse.equinox.registry:3.8.500 +org.eclipse.platform:org.eclipse.jface.text:3.15.300 +org.eclipse.platform:org.eclipse.jface:3.17.0 +org.eclipse.platform:org.eclipse.osgi:3.15.0 +org.eclipse.platform:org.eclipse.swt:3.112.0 +org.eclipse.platform:org.eclipse.text:3.9.0 diff --git a/lib-extra/src/test/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStepTest.java b/lib-extra/src/test/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStepTest.java index 8f5a803cf4..816b60e45c 100644 --- a/lib-extra/src/test/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStepTest.java +++ b/lib-extra/src/test/java/com/diffplug/spotless/extra/groovy/GrEclipseFormatterStepTest.java @@ -23,7 +23,7 @@ public class GrEclipseFormatterStepTest extends EclipseCommonTests { @Override protected String[] getSupportedVersions() { - return new String[]{"2.3.0", "4.6.3", "4.8.0", "4.8.1", "4.10.0", "4.12.0"}; + return new String[]{"2.3.0", "4.6.3", "4.8.0", "4.8.1", "4.10.0", "4.12.0", "4.13.0"}; } @Override From 008ac4f403cde0e01f083c393fe815aac27b54af Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Wed, 6 Nov 2019 09:46:58 -0800 Subject: [PATCH 18/22] Publish eclipse-wtp 3.15.0 --- _ext/eclipse-wtp/CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_ext/eclipse-wtp/CHANGES.md b/_ext/eclipse-wtp/CHANGES.md index 1175b93d9c..82f28179a6 100644 --- a/_ext/eclipse-wtp/CHANGES.md +++ b/_ext/eclipse-wtp/CHANGES.md @@ -1,6 +1,6 @@ # spotless-eclipse-wtp -### Version 3.15.0 - October 31st 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-wtp))) +### Version 3.15.0 - November 6th 2019 ([artifact]([jcenter](https://bintray.com/diffplug/opensource/spotless-eclipse-wtp))) * Switch to Eclipse WTP release 3.15.0 for Eclipse 4.13 ([#480](https://github.com/diffplug/spotless/issues/480)). From 7b249b94a123e807309de86adf34751fa9805e7a Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Wed, 6 Nov 2019 09:47:21 -0800 Subject: [PATCH 19/22] Remove SWT from the groovy lockfile, per @fvgh's advice --- .../spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile index e54810f482..aede5b0a76 100644 --- a/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/groovy_eclipse_formatter/v4.13.0.lockfile @@ -15,5 +15,4 @@ org.eclipse.platform:org.eclipse.equinox.registry:3.8.500 org.eclipse.platform:org.eclipse.jface.text:3.15.300 org.eclipse.platform:org.eclipse.jface:3.17.0 org.eclipse.platform:org.eclipse.osgi:3.15.0 -org.eclipse.platform:org.eclipse.swt:3.112.0 org.eclipse.platform:org.eclipse.text:3.9.0 From 3c8633972d4888f827145f4c693f577f01d03f3f Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Wed, 6 Nov 2019 16:27:50 -0500 Subject: [PATCH 20/22] Eclipse 4.13 support for wtp (#480) --- CHANGES.md | 2 ++ .../extra/wtp/EclipseWtpFormatterStep.java | 2 +- .../eclipse_wtp_formatters/v4.13.0.lockfile | 25 +++++++++++++++++++ .../wtp/EclipseWtpFormatterStepTest.java | 2 +- 4 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_wtp_formatters/v4.13.0.lockfile diff --git a/CHANGES.md b/CHANGES.md index 5d033ad89c..586f8afa19 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -12,6 +12,8 @@ You might be looking for: * Fixes [#305](https://github.com/diffplug/spotless/issues/305) StringIndexOutOfBoundsException for empty Groovy file when performing importOrder * Bugfix: CDT version `4.12.0` now properly uses `9.8`, whereas before it used `9.7`. ([#482](https://github.com/diffplug/spotless/pull/482#discussion_r341380884)) +* Add support for Eclipse 4.13 and all related formatters (JDT, CDT, WTP, and Groovy). ([#480](https://github.com/diffplug/spotless/issues/480)) + ### Version 1.25.0 - October 6th 2019 (javadoc [lib](https://diffplug.github.io/spotless/javadoc/spotless-lib/1.25.0/) [lib-extra](https://diffplug.github.io/spotless/javadoc/spotless-lib-extra/1.25.0/), artifact [lib]([jcenter](https://bintray.com/diffplug/opensource/spotless-lib), [lib-extra]([jcenter](https://bintray.com/diffplug/opensource/spotless-lib-extra))) * Add support for ktlint `0.34+`, and bump default version from `0.32.0` to `0.34.2`. ([#469](https://github.com/diffplug/spotless/pull/469)) diff --git a/lib-extra/src/main/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStep.java b/lib-extra/src/main/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStep.java index e9961328ed..045fcc3038 100644 --- a/lib-extra/src/main/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStep.java +++ b/lib-extra/src/main/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStep.java @@ -37,7 +37,7 @@ public enum EclipseWtpFormatterStep { private static final String NAME = "eclipse wtp formatters"; private static final String FORMATTER_PACKAGE = "com.diffplug.spotless.extra.eclipse.wtp."; - private static final String DEFAULT_VERSION = "4.12.0"; + private static final String DEFAULT_VERSION = "4.13.0"; private static final String FORMATTER_METHOD = "format"; private final String implementationClassName; diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_wtp_formatters/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_wtp_formatters/v4.13.0.lockfile new file mode 100644 index 0000000000..1650402c53 --- /dev/null +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_wtp_formatters/v4.13.0.lockfile @@ -0,0 +1,25 @@ +# Spotless formatter based on Eclipse-WTP version 3.15 (see https://www.eclipse.org/webtools/) +com.diffplug.spotless:spotless-eclipse-wtp:3.15.0 +com.diffplug.spotless:spotless-eclipse-base:3.2.1 +com.google.code.findbugs:annotations:3.0.0 +com.google.code.findbugs:jsr305:3.0.0 +com.ibm.icu:icu4j:61.2 +org.eclipse.emf:org.eclipse.emf.common:2.16.0 +org.eclipse.emf:org.eclipse.emf.ecore:2.19.0 +org.eclipse.platform:org.eclipse.core.commands:3.9.500 +org.eclipse.platform:org.eclipse.core.contenttype:3.7.400 +org.eclipse.platform:org.eclipse.core.filebuffers:3.6.700 +org.eclipse.platform:org.eclipse.core.filesystem:1.7.500 +org.eclipse.platform:org.eclipse.core.jobs:3.10.500 +org.eclipse.platform:org.eclipse.core.resources:3.13.500 +org.eclipse.platform:org.eclipse.core.runtime:3.16.0 +org.eclipse.platform:org.eclipse.equinox.app:1.4.300 +org.eclipse.platform:org.eclipse.equinox.common:3.10.500 +org.eclipse.platform:org.eclipse.equinox.preferences:3.7.500 +org.eclipse.platform:org.eclipse.equinox.registry:3.8.500 +org.eclipse.platform:org.eclipse.jface.text:3.15.300 +org.eclipse.platform:org.eclipse.jface:3.17.0 +org.eclipse.platform:org.eclipse.osgi.services:3.8.0 +org.eclipse.platform:org.eclipse.osgi:3.15.0 +org.eclipse.platform:org.eclipse.text:3.9.0 +org.eclipse.xsd:org.eclipse.xsd:2.12.0 diff --git a/lib-extra/src/test/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStepTest.java b/lib-extra/src/test/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStepTest.java index de60581d1e..90b2e81258 100644 --- a/lib-extra/src/test/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStepTest.java +++ b/lib-extra/src/test/java/com/diffplug/spotless/extra/wtp/EclipseWtpFormatterStepTest.java @@ -76,7 +76,7 @@ public static Iterable data() { @Override protected String[] getSupportedVersions() { - return new String[]{"4.7.3a", "4.7.3b", "4.8.0", "4.12.0"}; + return new String[]{"4.7.3a", "4.7.3b", "4.8.0", "4.12.0", "4.13.0"}; } @Override From 52a1d950427e51194ba30e463ba52e8cfe757a5a Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Wed, 6 Nov 2019 18:15:15 -0500 Subject: [PATCH 21/22] Remove swt dependency from cdt lockfile (#480) --- .../spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile index 26e5c2d33a..1d169ff087 100644 --- a/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile +++ b/lib-extra/src/main/resources/com/diffplug/spotless/extra/eclipse_cdt_formatter/v4.13.0.lockfile @@ -18,5 +18,4 @@ org.eclipse.platform:org.eclipse.equinox.registry:3.8.500 org.eclipse.platform:org.eclipse.jface.text:3.15.300 org.eclipse.platform:org.eclipse.jface:3.17.0 org.eclipse.platform:org.eclipse.osgi:3.15.0 -org.eclipse.platform:org.eclipse.swt:3.112.0 org.eclipse.platform:org.eclipse.text:3.9.0 From 75f32f929a28a6296f21a225b471066f9a74ad4e Mon Sep 17 00:00:00 2001 From: Kevin Brooks Date: Thu, 7 Nov 2019 13:17:21 -0500 Subject: [PATCH 22/22] Update changelogs (#480) --- plugin-gradle/CHANGES.md | 4 ++++ plugin-maven/CHANGES.md | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/plugin-gradle/CHANGES.md b/plugin-gradle/CHANGES.md index e484fee2ac..13f2022f2a 100644 --- a/plugin-gradle/CHANGES.md +++ b/plugin-gradle/CHANGES.md @@ -6,6 +6,10 @@ * Fix `ImportSorter` crashing with empty files. ([#474](https://github.com/diffplug/spotless/pull/474)) * Fixes [#305](https://github.com/diffplug/spotless/issues/305) StringIndexOutOfBoundsException for empty Groovy file when performing importOrder * Bugfix: CDT version `4.12.0` now properly uses `9.8`, whereas before it used `9.7`. ([#482](https://github.com/diffplug/spotless/pull/482#discussion_r341380884)) +* Updated default eclipse-wtp from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). +* Updated default eclipse-groovy from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). +* Updated default eclipse-jdt from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). +* Updated default eclipse-cdt from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). ### Version 3.25.0 - October 6th 2019 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-plugin-gradle/3.25.0/), [jcenter](https://bintray.com/diffplug/opensource/spotless-plugin-gradle/3.25.0)) diff --git a/plugin-maven/CHANGES.md b/plugin-maven/CHANGES.md index 68eb4b768b..a82674a792 100644 --- a/plugin-maven/CHANGES.md +++ b/plugin-maven/CHANGES.md @@ -6,6 +6,10 @@ * Fix `ImportSorter` crashing with empty files. ([#474](https://github.com/diffplug/spotless/pull/474)) * Fixes [#305](https://github.com/diffplug/spotless/issues/305) StringIndexOutOfBoundsException for empty Groovy file when performing importOrder * Bugfix: CDT version `4.12.0` now properly uses `9.8`, whereas before it used `9.7`. ([#482](https://github.com/diffplug/spotless/pull/482#discussion_r341380884)) +* Updated default eclipse-wtp from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). +* Updated default eclipse-groovy from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). +* Updated default eclipse-jdt from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). +* Updated default eclipse-cdt from 4.12.0 to 4.13.0 ([#482](https://github.com/diffplug/spotless/pull/482)). ### Version 1.25.1 - October 7th 2019 ([javadoc](https://diffplug.github.io/spotless/javadoc/spotless-maven-plugin/1.25.1/), [jcenter](https://bintray.com/diffplug/opensource/spotless-maven-plugin/1.25.1))