Skip to content

Focus visible on model menu selection #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekjackson-das opened this issue Mar 31, 2025 · 3 comments · May be fixed by #6645
Open

Focus visible on model menu selection #6638

derekjackson-das opened this issue Mar 31, 2025 · 3 comments · May be fixed by #6645
Assignees
Labels
♿ a11y Accessibility

Comments

@derekjackson-das
Copy link
Collaborator

The focus on the model select button in the Model Select Menu is not visible

Issue Description

When focus moves to the model select button it is not seen. It is also unclear in the menu and sub-menus. The light grey on grey that indicates the current active element is below the 3:1 contrast requirement for non-text elements and the WCAG 2.2 recommended contrast for focus.

WCAG Criteria

2.4.7 Focus Visible - AA
WCAG 2.2 - 2.4.13 Focus Appearance

Notes

Likely should remove these styles. They are interfering with the other styles used that honor dark and light modes.

Image

Screenshot or Screen Recording

https://share.zight.com/OAu1woeJ

@danny-avila
Copy link
Owner

Thanks, will merge this once we review the effect on styles, namely that there is no "cutting off" of borders in the various components.

@derekjackson-das
Copy link
Collaborator Author

derekjackson-das commented Apr 2, 2025

Adding some user feedback we received around the new menu from some user testing as a little more support and context to this issue.

  1. Switch system/Quad Stick user: "noticed that my focus did not appear on the GPT-4o-mini button. This may be because the button was already selected, but the lack of visual focus representation left me confused about where I was in the navigation process. I initially assumed my focus had jumped elsewhere on the page, leading to unnecessary searching and disorientation."
  2. ZoomText user: "The outline of the selection field, where I could choose and change the default model, was light grey on a white background, making it hard to distinguish. I suggest making the outline darker to improve visibility and ensure it is easy to see."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿ a11y Accessibility
Projects
None yet
3 participants
@derekjackson-das @danny-avila and others