Corrected acknowledgements

Author: glynos

ACKNOWLEDGEMENTS.md

@@ -0,0 +1,24 @@
+The Unicode functions included in this library have ben adapted from
+[utfcpp](https://github.com/nemtrif/utfcpp):
+
+Copyright 2006 Nemanja Trifunovic
+
+Permission is hereby granted, free of charge, to any person or organization
+obtaining a copy of the software and accompanying documentation covered by
+this license (the "Software") to use, reproduce, display, distribute,
+execute, and transmit the Software, and to prepare derivative works of the
+Software, and to permit third-parties to whom the Software is furnished to
+do so, all subject to the following:
+The copyright notices in the Software and this entire statement, including
+the above license grant, this restriction and the following disclaimer,
+must be included in all copies of the Software, in whole or in part, and
+all derivative works of the Software, unless such copies or derivative
+works are solely in the form of machine-executable object code generated by
+a source language processor.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT
+SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE
+FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
+ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.

README.md

@@ -179,13 +179,16 @@ the install command as an administrator (e.g. on Linux as `sudo`).
 
 ## Dependencies
 
-This library uses [expected](https://github.com/TartanLlama/expected)
-and a modified implementation of [utfcpp](https://github.com/nemtrif/utfcpp).
+This library uses [expected](https://github.com/TartanLlama/expected).
 
 The tests use [Catch2](https://github.com/catchorg/catch2),
 [nlohmann-json](https://github.com/nlohmann/json) and
 [fmtlib](https://github.com/fmtlib/fmt).
 
+## Acknowledgements
+
+This library includes a modified implementation of [utfcpp](https://github.com/nemtrif/utfcpp).
+
 ## Requirements
 
 This library has been tested using the following platforms and

include/skyr/v1/percent_encoding/percent_encoded_char.hpp

@@ -102,16 +102,6 @@ struct percent_encoded_char {
       '%',
       details::hex_to_letter(static_cast<char>((static_cast<unsigned>(byte) >> 4u) & 0x0fu)),
       details::hex_to_letter(static_cast<char>(static_cast<unsigned >(byte) & 0x0fu))} {}
-  ///
-  percent_encoded_char(const percent_encoded_char &) = default;
-  ///
-  percent_encoded_char(percent_encoded_char &&) noexcept = default;
-  ///
-  percent_encoded_char &operator=(const percent_encoded_char &) = default;
-  ///
-  percent_encoded_char &operator=(percent_encoded_char &&) noexcept = default;
-  ///
-  ~percent_encoded_char() = default;
 
   ///
   /// \return

include/skyr/v1/unicode/code_points/u16.hpp

@@ -32,17 +32,6 @@ class u16_code_point_t {
   constexpr u16_code_point_t(char16_t lead_value, char16_t trail_value)
       : code_point_((lead_value << 10U) + trail_value + constants::surrogates::offset) {}
 
-  ///
-  constexpr u16_code_point_t(const u16_code_point_t &) = default;
-  ///
-  constexpr u16_code_point_t(u16_code_point_t &&) noexcept = default;
-  ///
-  u16_code_point_t &operator=(const u16_code_point_t &) = default;
-  ///
-  u16_code_point_t &operator=(u16_code_point_t &&) noexcept = default;
-  ///
-  ~u16_code_point_t() = default;
-
   ///
   /// \return
   [[nodiscard]] constexpr auto is_surrogate_pair() const noexcept {

include/skyr/v1/unicode/core.hpp

@@ -17,28 +17,28 @@ namespace unicode {
 ///
 /// \param octet
 /// \return
-constexpr auto mask8(uint8_t octet) {
+constexpr inline auto mask8(uint8_t octet) {
   return static_cast<uint8_t>(0xffu & octet);
 }
 
 ///
 /// \param value
 /// \return
-constexpr auto mask16(char16_t value) {
+constexpr inline auto mask16(char16_t value) {
   return static_cast<char16_t>(u'\xffff' & value);
 }
 
 ///
 /// \param octet
 /// \return
-constexpr auto is_trail(uint8_t octet) {
+constexpr inline auto is_trail(uint8_t octet) {
   return ((mask8(octet) >> 6u) == 0x2u);
 }
 
 ///
 /// \param code_point
 /// \return
-constexpr auto is_lead_surrogate(char16_t code_point) {
+constexpr inline auto is_lead_surrogate(char16_t code_point) {
   return
       (code_point >= constants::surrogates::lead_min) &&
       (code_point <= constants::surrogates::lead_max);
@@ -47,7 +47,7 @@ constexpr auto is_lead_surrogate(char16_t code_point) {
 ///
 /// \param value
 /// \return
-constexpr auto is_trail_surrogate(char16_t value) {
+constexpr inline auto is_trail_surrogate(char16_t value) {
   return
       (value >= constants::surrogates::trail_min) &&
       (value <= constants::surrogates::trail_max);
@@ -56,7 +56,7 @@ constexpr auto is_trail_surrogate(char16_t value) {
 ///
 /// \param value
 /// \return
-constexpr auto is_surrogate(char16_t value) {
+constexpr inline auto is_surrogate(char16_t value) {
   return
       (value >= constants::surrogates::lead_min) &&
       (value <= constants::surrogates::trail_max);
@@ -65,7 +65,7 @@ constexpr auto is_surrogate(char16_t value) {
 /// Tests if the code point is a valid value.
 /// \param code_point
 /// \return \c true if it has a valid value, \c false otherwise
-constexpr auto is_valid_code_point(char32_t code_point) {
+constexpr inline auto is_valid_code_point(char32_t code_point) {
   return
       (code_point <= constants::code_points::max) &&
       !is_surrogate(static_cast<char16_t>(code_point));
@@ -74,7 +74,7 @@ constexpr auto is_valid_code_point(char32_t code_point) {
 /// Returns the size of the sequnce given the lead octet value.
 /// \param lead_value
 /// \return 1, 2, 3 or 4
-constexpr auto sequence_length(uint8_t lead_value) {
+constexpr inline auto sequence_length(uint8_t lead_value) {
   auto lead = mask8(lead_value);
   if (lead < 0x80u) {
     return 1;
@@ -164,7 +164,7 @@ template<typename OctetIterator>
 auto from_two_byte_sequence(OctetIterator first) -> tl::expected<sequence_state<OctetIterator>, std::error_code> {
   using result_type = tl::expected<sequence_state<OctetIterator>, std::error_code>;
 
-  auto set_code_point = [](auto state) -> result_type {
+  constexpr static auto set_code_point = [](auto state) -> result_type {
     return update_value(
         state,
         ((state.value << 6) & 0x7ff) + (*state.it & 0x3f));
@@ -186,13 +186,13 @@ template<typename OctetIterator>
 auto from_three_byte_sequence(OctetIterator first) -> tl::expected<sequence_state<OctetIterator>, std::error_code> {
   using result_type = tl::expected<sequence_state<OctetIterator>, std::error_code>;
 
-  auto update_code_point_from_second_byte = [](auto state) -> result_type {
+  constexpr static auto update_code_point_from_second_byte = [](auto state) -> result_type {
     return update_value(
         state,
         ((state.value << 12) & 0xffff) + ((mask8(*state.it) << 6) & 0xfff));
   };
 
-  auto set_code_point = [](auto state) -> result_type {
+  constexpr static auto set_code_point = [](auto state) -> result_type {
     return update_value(
         state,
         state.value + (*state.it & 0x3f));
@@ -215,19 +215,19 @@ template<typename OctetIterator>
 auto from_four_byte_sequence(OctetIterator first) -> tl::expected<sequence_state<OctetIterator>, std::error_code> {
   using result_type = tl::expected<sequence_state<OctetIterator>, std::error_code>;
 
-  auto update_code_point_from_second_byte = [](auto state) -> result_type {
+  constexpr static auto update_code_point_from_second_byte = [](auto state) -> result_type {
     return update_value(
         state,
         ((state.value << 18) & 0x1fffff) + ((mask8(*state.it) << 12) & 0x3ffff));
   };
 
-  auto update_code_point_from_third_byte = [](auto state) -> result_type {
+  constexpr static auto update_code_point_from_third_byte = [](auto state) -> result_type {
     return update_value(
         state,
         state.value + ((mask8(*state.it) << 6) & 0xfff));
   };
 
-  auto set_code_point = [](auto state) -> result_type {
+  constexpr static auto set_code_point = [](auto state) -> result_type {
     return update_value(
         state,
         state.value + (*state.it & 0x3f));