Skip to content

[sequence.reqmts] P2846 incorrectly applied for assign_range #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BoPersson opened this issue May 5, 2025 · 6 comments
Closed

[sequence.reqmts] P2846 incorrectly applied for assign_range #7865

BoPersson opened this issue May 5, 2025 · 6 comments

Comments

@BoPersson
Copy link

In N5008 the last part of Recommended practice says "should not perform any reallocation", but the proposal said "should not perform more than a single reallocation".

Obviously, if the assigned range is larger than the current capacity, there has to be some reallocation.

@frederick-vs-ja
Copy link
Contributor

I believe the intent is the same. But the current wording looks a bit weird. @cor3ntin What do you think?

@cor3ntin
Copy link
Contributor

The wording from https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p2846r6.pdf seems to have been incorrectly applied for assign_range, so this qualifies as editorial, I think @tkoeppe

@jwakely
Copy link
Member

jwakely commented May 12, 2025

Agreed, I don't see any mention of this in #7698 that would explain it. I think it is accidental.

@tkoeppe
Copy link
Contributor

tkoeppe commented May 12, 2025

Yes, agreed, thanks! If someone sends a PR we can merge it, or I'll do it at some point.

@frederick-vs-ja
Copy link
Contributor

@jensmaurer This issue should have been fixed now.

@jwakely
Copy link
Member

jwakely commented May 13, 2025

Fixed by 4b1283b

@jwakely jwakely closed this as completed May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants