Skip to content

Commit e5a24d5

Browse files
authored
Merge pull request #11 from coreui/fix-sidebar-slots
fix(Sidebar): add missing slots *Footer/*Form/*Header
2 parents c0d6749 + d709299 commit e5a24d5

File tree

4 files changed

+34
-19
lines changed

4 files changed

+34
-19
lines changed

package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@coreui/vue",
33
"description": "CoreUI Vue Bootstrap 4 layout components",
4-
"version": "2.0.0-rc.0",
4+
"version": "2.0.0-rc.1",
55
"license": "MIT",
66
"main": "dist/coreui-vue.common.js",
77
"module": "dist/coreui-vue.esm.js",
@@ -63,7 +63,7 @@
6363
},
6464
"devDependencies": {
6565
"babel-core": "^6.26.3",
66-
"babel-eslint": "^8.2.3",
66+
"babel-eslint": "^8.2.6",
6767
"babel-jest": "^22.4.4",
6868
"babel-plugin-dynamic-import-node": "^1.2.0",
6969
"babel-plugin-module-resolver": "^3.1.1",
@@ -74,7 +74,7 @@
7474
"eslint-plugin-html": "^4.0.3",
7575
"eslint-plugin-import": "^2.12.0",
7676
"eslint-plugin-jest": "^21.17.0",
77-
"eslint-plugin-prettier": "^2.6.0",
77+
"eslint-plugin-prettier": "^2.6.2",
7878
"eslint-plugin-vue": "^4.5.0",
7979
"husky": "^0.14.3",
8080
"jest": "^22.4.4",
@@ -83,18 +83,18 @@
8383
"jest-vue-preprocessor": "^1.4.0",
8484
"lint-staged": "^7.1.3",
8585
"lodash": "^4.17.10",
86-
"node-sass": "^4.9.0",
86+
"node-sass": "^4.9.2",
8787
"prettier": "^1.13.4",
8888
"rollup": "^0.59.4",
89-
"rollup-plugin-babel": "^3.0.4",
89+
"rollup-plugin-babel": "^3.0.7",
9090
"rollup-plugin-commonjs": "^9.1.3",
9191
"rollup-plugin-filesize": "^1.5.0",
9292
"rollup-plugin-json": "^3.0.0",
93-
"rollup-plugin-license": "^0.6.0",
93+
"rollup-plugin-license": "^0.7.0",
9494
"rollup-plugin-node-resolve": "^3.3.0",
9595
"rollup-plugin-replace": "^2.0.0",
9696
"rollup-plugin-uglify": "^3.0.0",
97-
"rollup-plugin-vue": "^4.2.0",
97+
"rollup-plugin-vue": "^4.3.1",
9898
"sass-loader": "^7.0.3",
9999
"uglify-es": "^3.3.9",
100100
"vue": "^2.5.16",
+9-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
1-
/* eslint-disable */
21
<template>
3-
<div></div>
4-
<!--<div class="sidebar-footer"></div>-->
2+
<div v-if="hasSlotDefault" class="sidebar-footer">
3+
<slot></slot>
4+
</div>
55
</template>
66

77
<script>
88
export default {
9-
name: 'sidebar-footer'
9+
name: 'sidebar-footer',
10+
computed: {
11+
hasSlotDefault() {
12+
return !!this.$slots.default;
13+
}
14+
}
1015
}
1116
</script>
+9-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
1-
/* eslint-disable */
21
<template>
3-
<div></div>
4-
<!-- <div class="sidebar-form"></div> -->
2+
<div v-if="hasSlotDefault" class="sidebar-form">
3+
<slot></slot>
4+
</div>
55
</template>
66
<script>
77
88
export default {
9-
name: 'sidebar-form'
9+
name: 'sidebar-form',
10+
computed: {
11+
hasSlotDefault() {
12+
return !!this.$slots.default;
13+
}
14+
}
1015
}
1116
</script>
+9-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
1-
/* eslint-disable */
21
<template>
3-
<div></div>
4-
<!-- <div class="sidebar-header"></div> -->
2+
<div v-if="hasSlotDefault" class="sidebar-header">
3+
<slot></slot>
4+
</div>
55
</template>
66
<script>
77
88
export default {
9-
name: 'sidebar-header'
9+
name: 'sidebar-header',
10+
computed: {
11+
hasSlotDefault() {
12+
return !!this.$slots.default;
13+
}
14+
}
1015
}
1116
</script>

0 commit comments

Comments
 (0)