fix: CDropdownToggle: add role attribute in case of non-button tag

woothu · woothu · commit 4de6508bbfdb · 2020-07-17T17:03:27.000+02:00
diff --git a/src/dropdown/CDropdownToggle.js b/src/dropdown/CDropdownToggle.js
@@ -59,7 +59,8 @@ const CDropdownToggle = props => {
     'aria-expanded': isOpen ? 'true' : 'false',
     'aria-haspopup': 'true',
     'aria-label': 'Dropdown toggle',
-    [`${tag && typeof tag === 'string' ? 'ref' : 'innerRef'}`]: setReference
+    [`${tag && typeof tag === 'string' ? 'ref' : 'innerRef'}`]: setReference,
+    'role': Tag === CButton ? null : 'button'
   }
 
   if (split) {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,8 @@ const CDropdownToggle = props => {`
`59`	`59`	`'aria-expanded': isOpen ? 'true' : 'false',`
`60`	`60`	`'aria-haspopup': 'true',`
`61`	`61`	`'aria-label': 'Dropdown toggle',`
`62`		- [`${tag && typeof tag === 'string' ? 'ref' : 'innerRef'}`]: setReference
	`62`	+ [`${tag && typeof tag === 'string' ? 'ref' : 'innerRef'}`]: setReference,
	`63`	`+ 'role': Tag === CButton ? null : 'button'`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`if (split) {`