fix(cmd): prevent adding connection with invalid identities file

Signed-off-by: axel7083 <[email protected]>

Author: axel7083

cmd/podman/system/connection/add.go

@@ -141,6 +141,14 @@ func add(cmd *cobra.Command, args []string) error {
 
 	switch uri.Scheme {
 	case "ssh":
+		// ensure the Identity provided is a valid file
+		info, err := os.Stat(entities.Identity)
+		switch {
+		case err != nil:
+			return err
+		case info.IsDir():
+			return fmt.Errorf("%q is a directory", entities.Identity)
+		}
 		return ssh.Create(entities, sshMode)
 	case "unix":
 		if cmd.Flags().Changed("identity") {

test/e2e/system_connection_test.go

@@ -45,6 +45,19 @@ var _ = Describe("podman system connection", func() {
 	BeforeEach(setupConnectionsConf)
 
 	Context("without running API service", func() {
+		It("adding ssh connection with non-existing identity", func() {
+			identity := "~/foo/bar.txt"
+			cmd := []string{"system", "connection", "add",
+				"--default",
+				"--identity", identity,
+				"QA",
+				"ssh://[email protected]:2222/run/podman/podman.sock",
+			}
+			session := podmanTest.Podman(cmd)
+			session.WaitWithDefaultTimeout()
+			Expect(session).Should(ExitWithError(125, fmt.Sprintf("Error: stat %s: no such file or directory", identity)))
+		})
+
 		It("add ssh://", func() {
 			cmd := []string{"system", "connection", "add",
 				"--default",