Skip to content

tests: don't do so many internet requests #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luap99 opened this issue May 6, 2025 · 0 comments
Open

tests: don't do so many internet requests #6163

Luap99 opened this issue May 6, 2025 · 0 comments
Labels

Comments

@Luap99
Copy link
Member

Luap99 commented May 6, 2025

Each network request increases the chances flakes, tests should always avoid making external requests as much as possible.
Example failures observed in podman: https://api.cirrus-ci.com/v1/artifact/task/6035732734672896/html/bud-podman-fedora-42-root-host-sqlite.log.html

# STEP 6/7: ADD https://github.com/containers/buildah/blob/main/README.md /tmp/
# Error: building at STEP "ADD https://github.com/containers/buildah/blob/main/README.md /tmp/": reading "https://github.com/containers/buildah/blob/main/README.md": invalid response status 429

Unless there is some strong reason I suggest these tests should setup their own local websever to serve these contents so they don't have to reach out to servers we don't control.

@Luap99 Luap99 added the flakes label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant