Skip to content

Commit 1325425

Browse files
committed
Auto merge of rust-lang#12748 - flip1995:rustup, r=flip1995
Rustup r? `@ghost` changelog: none
2 parents 7eb3809 + d878e0e commit 1325425

File tree

85 files changed

+275
-276
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+275
-276
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "clippy"
3-
version = "0.1.79"
3+
version = "0.1.80"
44
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
55
repository = "https://github.com/rust-lang/rust-clippy"
66
readme = "README.md"

clippy_config/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "clippy_config"
3-
version = "0.1.79"
3+
version = "0.1.80"
44
edition = "2021"
55

66
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

clippy_lints/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "clippy_lints"
3-
version = "0.1.79"
3+
version = "0.1.80"
44
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
55
repository = "https://github.com/rust-lang/rust-clippy"
66
readme = "README.md"

clippy_lints/src/dereference.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ use rustc_data_structures::fx::FxIndexMap;
99
use rustc_errors::Applicability;
1010
use rustc_hir::intravisit::{walk_ty, Visitor};
1111
use rustc_hir::{
12-
self as hir, BindingAnnotation, Body, BodyId, BorrowKind, Expr, ExprKind, HirId, MatchSource, Mutability, Node,
13-
Pat, PatKind, Path, QPath, TyKind, UnOp,
12+
self as hir, BindingMode, Body, BodyId, BorrowKind, Expr, ExprKind, HirId, MatchSource, Mutability, Node, Pat,
13+
PatKind, Path, QPath, TyKind, UnOp,
1414
};
1515
use rustc_lint::{LateContext, LateLintPass};
1616
use rustc_middle::ty::adjustment::{Adjust, Adjustment, AutoBorrow, AutoBorrowMutability};
@@ -599,7 +599,7 @@ impl<'tcx> LateLintPass<'tcx> for Dereferencing<'tcx> {
599599
}
600600

601601
fn check_pat(&mut self, cx: &LateContext<'tcx>, pat: &'tcx Pat<'_>) {
602-
if let PatKind::Binding(BindingAnnotation::REF, id, name, _) = pat.kind {
602+
if let PatKind::Binding(BindingMode::REF, id, name, _) = pat.kind {
603603
if let Some(opt_prev_pat) = self.ref_locals.get_mut(&id) {
604604
// This binding id has been seen before. Add this pattern to the list of changes.
605605
if let Some(prev_pat) = opt_prev_pat {

clippy_lints/src/eta_reduction.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use clippy_utils::ty::type_diagnostic_name;
55
use clippy_utils::usage::{local_used_after_expr, local_used_in};
66
use clippy_utils::{get_path_from_caller_to_method_type, is_adjusted, path_to_local, path_to_local_id};
77
use rustc_errors::Applicability;
8-
use rustc_hir::{BindingAnnotation, Expr, ExprKind, FnRetTy, Param, PatKind, QPath, TyKind, Unsafety};
8+
use rustc_hir::{BindingMode, Expr, ExprKind, FnRetTy, Param, PatKind, QPath, TyKind, Unsafety};
99
use rustc_infer::infer::TyCtxtInferExt;
1010
use rustc_lint::{LateContext, LateLintPass};
1111
use rustc_middle::ty::{
@@ -229,7 +229,7 @@ fn check_inputs(
229229
&& params.iter().zip(self_arg.into_iter().chain(args)).all(|(p, arg)| {
230230
matches!(
231231
p.pat.kind,
232-
PatKind::Binding(BindingAnnotation::NONE, id, _, None)
232+
PatKind::Binding(BindingMode::NONE, id, _, None)
233233
if path_to_local_id(arg, id)
234234
)
235235
// Only allow adjustments which change regions (i.e. re-borrowing).

clippy_lints/src/explicit_write.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use clippy_utils::source::snippet_with_applicability;
44
use clippy_utils::{is_expn_of, path_def_id};
55
use rustc_errors::Applicability;
66
use rustc_hir::def::Res;
7-
use rustc_hir::{BindingAnnotation, Block, BlockCheckMode, Expr, ExprKind, Node, PatKind, QPath, Stmt, StmtKind};
7+
use rustc_hir::{BindingMode, Block, BlockCheckMode, Expr, ExprKind, Node, PatKind, QPath, Stmt, StmtKind};
88
use rustc_lint::{LateContext, LateLintPass};
99
use rustc_session::declare_lint_pass;
1010
use rustc_span::{sym, ExpnId};
@@ -114,7 +114,7 @@ fn look_in_block<'tcx, 'hir>(cx: &LateContext<'tcx>, kind: &'tcx ExprKind<'hir>)
114114
&& let Node::Pat(res_pat) = cx.tcx.hir_node(expr_res)
115115

116116
// Find id of the local we found in the block
117-
&& let PatKind::Binding(BindingAnnotation::NONE, local_hir_id, _ident, None) = local.pat.kind
117+
&& let PatKind::Binding(BindingMode::NONE, local_hir_id, _ident, None) = local.pat.kind
118118

119119
// If those two are the same hir id
120120
&& res_pat.hir_id == local_hir_id

clippy_lints/src/functions/must_use.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ fn is_mutable_pat(cx: &LateContext<'_>, pat: &hir::Pat<'_>, tys: &mut DefIdSet)
185185
if let hir::PatKind::Wild = pat.kind {
186186
return false; // ignore `_` patterns
187187
}
188-
if cx.tcx.has_typeck_results(pat.hir_id.owner.to_def_id()) {
188+
if cx.tcx.has_typeck_results(pat.hir_id.owner.def_id) {
189189
is_mutable_ty(cx, cx.tcx.typeck(pat.hir_id.owner.def_id).pat_ty(pat), tys)
190190
} else {
191191
false
@@ -233,7 +233,7 @@ fn mutates_static<'tcx>(cx: &LateContext<'tcx>, body: &'tcx hir::Body<'_>) -> bo
233233
Call(_, args) => {
234234
let mut tys = DefIdSet::default();
235235
for arg in args {
236-
if cx.tcx.has_typeck_results(arg.hir_id.owner.to_def_id())
236+
if cx.tcx.has_typeck_results(arg.hir_id.owner.def_id)
237237
&& is_mutable_ty(cx, cx.tcx.typeck(arg.hir_id.owner.def_id).expr_ty(arg), &mut tys)
238238
&& is_mutated_static(arg)
239239
{
@@ -246,7 +246,7 @@ fn mutates_static<'tcx>(cx: &LateContext<'tcx>, body: &'tcx hir::Body<'_>) -> bo
246246
MethodCall(_, receiver, args, _) => {
247247
let mut tys = DefIdSet::default();
248248
for arg in std::iter::once(receiver).chain(args.iter()) {
249-
if cx.tcx.has_typeck_results(arg.hir_id.owner.to_def_id())
249+
if cx.tcx.has_typeck_results(arg.hir_id.owner.def_id)
250250
&& is_mutable_ty(cx, cx.tcx.typeck(arg.hir_id.owner.def_id).expr_ty(arg), &mut tys)
251251
&& is_mutated_static(arg)
252252
{

clippy_lints/src/index_refutable_slice.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,9 @@ fn find_slice_values(cx: &LateContext<'_>, pat: &hir::Pat<'_>) -> FxIndexMap<Hir
9393
let mut slices: FxIndexMap<HirId, SliceLintInformation> = FxIndexMap::default();
9494
pat.walk_always(|pat| {
9595
// We'll just ignore mut and ref mut for simplicity sake right now
96-
if let hir::PatKind::Binding(
97-
hir::BindingAnnotation(by_ref, hir::Mutability::Not),
98-
value_hir_id,
99-
ident,
100-
sub_pat,
101-
) = pat.kind && by_ref != hir::ByRef::Yes(hir::Mutability::Mut)
96+
if let hir::PatKind::Binding(hir::BindingMode(by_ref, hir::Mutability::Not), value_hir_id, ident, sub_pat) =
97+
pat.kind
98+
&& by_ref != hir::ByRef::Yes(hir::Mutability::Mut)
10299
{
103100
// This block catches bindings with sub patterns. It would be hard to build a correct suggestion
104101
// for them and it's likely that the user knows what they are doing in such a case.

clippy_lints/src/let_if_seq.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use clippy_utils::source::snippet;
44
use clippy_utils::visitors::is_local_used;
55
use rustc_errors::Applicability;
66
use rustc_hir as hir;
7-
use rustc_hir::{BindingAnnotation, Mutability};
7+
use rustc_hir::{BindingMode, Mutability};
88
use rustc_lint::{LateContext, LateLintPass};
99
use rustc_session::declare_lint_pass;
1010

@@ -106,7 +106,7 @@ impl<'tcx> LateLintPass<'tcx> for LetIfSeq {
106106
};
107107

108108
let mutability = match mode {
109-
BindingAnnotation(_, Mutability::Mut) => "<mut> ",
109+
BindingMode(_, Mutability::Mut) => "<mut> ",
110110
_ => "",
111111
};
112112

clippy_lints/src/loops/manual_find.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use clippy_utils::{higher, is_res_lang_ctor, path_res, peel_blocks_with_stmt};
77
use rustc_errors::Applicability;
88
use rustc_hir::def::Res;
99
use rustc_hir::lang_items::LangItem;
10-
use rustc_hir::{BindingAnnotation, Block, Expr, ExprKind, HirId, Node, Pat, PatKind, Stmt, StmtKind};
10+
use rustc_hir::{BindingMode, Block, Expr, ExprKind, HirId, Node, Pat, PatKind, Stmt, StmtKind};
1111
use rustc_lint::LateContext;
1212
use rustc_span::Span;
1313

@@ -107,7 +107,7 @@ fn get_binding(pat: &Pat<'_>) -> Option<HirId> {
107107
hir_id = None;
108108
return;
109109
}
110-
if let BindingAnnotation::NONE = annotation {
110+
if let BindingMode::NONE = annotation {
111111
hir_id = Some(id);
112112
}
113113
});

clippy_lints/src/loops/mut_range_bound.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use super::MUT_RANGE_BOUND;
22
use clippy_utils::diagnostics::span_lint_and_note;
33
use clippy_utils::{get_enclosing_block, higher, path_to_local};
44
use rustc_hir::intravisit::{self, Visitor};
5-
use rustc_hir::{BindingAnnotation, Expr, ExprKind, HirId, Node, PatKind};
5+
use rustc_hir::{BindingMode, Expr, ExprKind, HirId, Node, PatKind};
66
use rustc_hir_typeck::expr_use_visitor::{Delegate, ExprUseVisitor, PlaceBase, PlaceWithHirId};
77
use rustc_infer::infer::TyCtxtInferExt;
88
use rustc_lint::LateContext;
@@ -41,7 +41,7 @@ fn mut_warn_with_span(cx: &LateContext<'_>, span: Option<Span>) {
4141
fn check_for_mutability(cx: &LateContext<'_>, bound: &Expr<'_>) -> Option<HirId> {
4242
if let Some(hir_id) = path_to_local(bound)
4343
&& let Node::Pat(pat) = cx.tcx.hir_node(hir_id)
44-
&& let PatKind::Binding(BindingAnnotation::MUT, ..) = pat.kind
44+
&& let PatKind::Binding(BindingMode::MUT, ..) = pat.kind
4545
{
4646
return Some(hir_id);
4747
}

clippy_lints/src/loops/same_item_push.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use rustc_data_structures::fx::FxHashSet;
77
use rustc_errors::Applicability;
88
use rustc_hir::def::{DefKind, Res};
99
use rustc_hir::intravisit::{walk_expr, Visitor};
10-
use rustc_hir::{BindingAnnotation, Block, Expr, ExprKind, HirId, Mutability, Node, Pat, PatKind, Stmt, StmtKind};
10+
use rustc_hir::{BindingMode, Block, Expr, ExprKind, HirId, Mutability, Node, Pat, PatKind, Stmt, StmtKind};
1111
use rustc_lint::LateContext;
1212
use rustc_span::symbol::sym;
1313
use rustc_span::SyntaxContext;
@@ -61,7 +61,7 @@ pub(super) fn check<'tcx>(
6161
let node = cx.tcx.hir_node(hir_id);
6262
if let Node::Pat(pat) = node
6363
&& let PatKind::Binding(bind_ann, ..) = pat.kind
64-
&& !matches!(bind_ann, BindingAnnotation(_, Mutability::Mut))
64+
&& !matches!(bind_ann, BindingMode(_, Mutability::Mut))
6565
&& let Node::LetStmt(parent_let_expr) = cx.tcx.parent_hir_node(hir_id)
6666
&& let Some(init) = parent_let_expr.init
6767
{

clippy_lints/src/loops/unused_enumerate_index.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
use super::UNUSED_ENUMERATE_INDEX;
22
use clippy_utils::diagnostics::{multispan_sugg, span_lint_and_then};
33
use clippy_utils::source::snippet;
4-
use clippy_utils::{match_def_path, pat_is_wild, sugg};
4+
use clippy_utils::{pat_is_wild, sugg};
55
use rustc_hir::def::DefKind;
66
use rustc_hir::{Expr, ExprKind, Pat, PatKind};
77
use rustc_lint::LateContext;
88
use rustc_middle::ty;
9+
use rustc_span::sym;
910

1011
/// Checks for the `UNUSED_ENUMERATE_INDEX` lint.
1112
///
@@ -16,9 +17,9 @@ pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, pat: &Pat<'tcx>, arg: &Expr<'_
1617
&& let ty = cx.typeck_results().expr_ty(arg)
1718
&& pat_is_wild(cx, &index.kind, body)
1819
&& let ty::Adt(base, _) = *ty.kind()
19-
&& match_def_path(cx, base.did(), &clippy_utils::paths::CORE_ITER_ENUMERATE_STRUCT)
20+
&& cx.tcx.is_diagnostic_item(sym::Enumerate, base.did())
2021
&& let Some((DefKind::AssocFn, call_id)) = cx.typeck_results().type_dependent_def(arg.hir_id)
21-
&& match_def_path(cx, call_id, &clippy_utils::paths::CORE_ITER_ENUMERATE_METHOD)
22+
&& cx.tcx.is_diagnostic_item(sym::enumerate_method, call_id)
2223
{
2324
span_lint_and_then(
2425
cx,

clippy_lints/src/manual_hash_one.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use clippy_utils::source::snippet_opt;
44
use clippy_utils::visitors::{is_local_used, local_used_once};
55
use clippy_utils::{is_trait_method, path_to_local_id};
66
use rustc_errors::Applicability;
7-
use rustc_hir::{BindingAnnotation, ExprKind, LetStmt, Node, PatKind, StmtKind};
7+
use rustc_hir::{BindingMode, ExprKind, LetStmt, Node, PatKind, StmtKind};
88
use rustc_lint::{LateContext, LateLintPass};
99
use rustc_session::impl_lint_pass;
1010
use rustc_span::sym;
@@ -62,7 +62,7 @@ impl_lint_pass!(ManualHashOne => [MANUAL_HASH_ONE]);
6262
impl LateLintPass<'_> for ManualHashOne {
6363
fn check_local(&mut self, cx: &LateContext<'_>, local: &LetStmt<'_>) {
6464
// `let mut hasher = seg.build_hasher();`
65-
if let PatKind::Binding(BindingAnnotation::MUT, hasher, _, None) = local.pat.kind
65+
if let PatKind::Binding(BindingMode::MUT, hasher, _, None) = local.pat.kind
6666
&& let Some(init) = local.init
6767
&& !init.span.from_expansion()
6868
&& let ExprKind::MethodCall(seg, build_hasher, [], _) = init.kind

clippy_lints/src/matches/manual_utils.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use rustc_ast::util::parser::PREC_POSTFIX;
1111
use rustc_errors::Applicability;
1212
use rustc_hir::def::Res;
1313
use rustc_hir::LangItem::{OptionNone, OptionSome};
14-
use rustc_hir::{BindingAnnotation, Expr, ExprKind, HirId, Mutability, Pat, PatKind, Path, QPath};
14+
use rustc_hir::{BindingMode, Expr, ExprKind, HirId, Mutability, Pat, PatKind, Path, QPath};
1515
use rustc_lint::LateContext;
1616
use rustc_span::{sym, SyntaxContext};
1717

@@ -139,7 +139,7 @@ where
139139
}
140140

141141
// `ref` and `ref mut` annotations were handled earlier.
142-
let annotation = if matches!(annotation, BindingAnnotation::MUT) {
142+
let annotation = if matches!(annotation, BindingMode::MUT) {
143143
"mut "
144144
} else {
145145
""

clippy_lints/src/matches/match_as_ref.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use clippy_utils::diagnostics::span_lint_and_sugg;
22
use clippy_utils::source::snippet_with_applicability;
33
use clippy_utils::{is_res_lang_ctor, path_res, peel_blocks};
44
use rustc_errors::Applicability;
5-
use rustc_hir::{Arm, BindingAnnotation, ByRef, Expr, ExprKind, LangItem, Mutability, PatKind, QPath};
5+
use rustc_hir::{Arm, BindingMode, ByRef, Expr, ExprKind, LangItem, Mutability, PatKind, QPath};
66
use rustc_lint::LateContext;
77
use rustc_middle::ty;
88

@@ -67,7 +67,7 @@ fn is_none_arm(cx: &LateContext<'_>, arm: &Arm<'_>) -> bool {
6767
fn is_ref_some_arm(cx: &LateContext<'_>, arm: &Arm<'_>) -> Option<Mutability> {
6868
if let PatKind::TupleStruct(ref qpath, [first_pat, ..], _) = arm.pat.kind
6969
&& is_res_lang_ctor(cx, cx.qpath_res(qpath, arm.pat.hir_id), LangItem::OptionSome)
70-
&& let PatKind::Binding(BindingAnnotation(ByRef::Yes(mutabl), _), .., ident, _) = first_pat.kind
70+
&& let PatKind::Binding(BindingMode(ByRef::Yes(mutabl), _), .., ident, _) = first_pat.kind
7171
&& let ExprKind::Call(e, [arg]) = peel_blocks(arm.body).kind
7272
&& is_res_lang_ctor(cx, path_res(cx, e), LangItem::OptionSome)
7373
&& let ExprKind::Path(QPath::Resolved(_, path2)) = arg.kind

clippy_lints/src/matches/needless_match.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use clippy_utils::{
88
};
99
use rustc_errors::Applicability;
1010
use rustc_hir::LangItem::OptionNone;
11-
use rustc_hir::{Arm, BindingAnnotation, ByRef, Expr, ExprKind, ItemKind, Node, Pat, PatKind, Path, QPath};
11+
use rustc_hir::{Arm, BindingMode, ByRef, Expr, ExprKind, ItemKind, Node, Pat, PatKind, Path, QPath};
1212
use rustc_lint::LateContext;
1313
use rustc_span::sym;
1414

@@ -178,7 +178,7 @@ fn pat_same_as_expr(pat: &Pat<'_>, expr: &Expr<'_>) -> bool {
178178
},
179179
)),
180180
) => {
181-
return !matches!(annot, BindingAnnotation(ByRef::Yes(_), _)) && pat_ident.name == first_seg.ident.name;
181+
return !matches!(annot, BindingMode(ByRef::Yes(_), _)) && pat_ident.name == first_seg.ident.name;
182182
},
183183
// Example: `Custom::TypeA => Custom::TypeB`, or `None => None`
184184
(PatKind::Path(QPath::Resolved(_, p_path)), ExprKind::Path(QPath::Resolved(_, e_path))) => {

clippy_lints/src/matches/single_match.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use clippy_utils::ty::{implements_trait, is_type_diagnostic_item, peel_mid_ty_re
44
use clippy_utils::{is_lint_allowed, is_unit_expr, is_wild, peel_blocks, peel_hir_pat_refs, peel_n_hir_expr_refs};
55
use core::cmp::max;
66
use rustc_errors::Applicability;
7-
use rustc_hir::{Arm, BindingAnnotation, Block, Expr, ExprKind, Pat, PatKind};
7+
use rustc_hir::{Arm, BindingMode, Block, Expr, ExprKind, Pat, PatKind};
88
use rustc_lint::LateContext;
99
use rustc_middle::ty::{self, Ty};
1010
use rustc_span::{sym, Span};
@@ -166,7 +166,7 @@ fn collect_pat_paths<'a>(acc: &mut Vec<Ty<'a>>, cx: &LateContext<'a>, pat: &Pat<
166166
let p_ty = cx.typeck_results().pat_ty(p);
167167
collect_pat_paths(acc, cx, p, p_ty);
168168
}),
169-
PatKind::TupleStruct(..) | PatKind::Binding(BindingAnnotation::NONE, .., None) | PatKind::Path(_) => {
169+
PatKind::TupleStruct(..) | PatKind::Binding(BindingMode::NONE, .., None) | PatKind::Path(_) => {
170170
acc.push(ty);
171171
},
172172
_ => {},

clippy_lints/src/methods/clone_on_copy.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use clippy_utils::diagnostics::span_lint_and_sugg;
22
use clippy_utils::source::snippet_with_context;
33
use clippy_utils::ty::is_copy;
44
use rustc_errors::Applicability;
5-
use rustc_hir::{BindingAnnotation, ByRef, Expr, ExprKind, MatchSource, Node, PatKind, QPath};
5+
use rustc_hir::{BindingMode, ByRef, Expr, ExprKind, MatchSource, Node, PatKind, QPath};
66
use rustc_lint::LateContext;
77
use rustc_middle::ty::adjustment::Adjust;
88
use rustc_middle::ty::print::with_forced_trimmed_paths;
@@ -69,7 +69,7 @@ pub(super) fn check(
6969
_ => false,
7070
},
7171
// local binding capturing a reference
72-
Node::LetStmt(l) if matches!(l.pat.kind, PatKind::Binding(BindingAnnotation(ByRef::Yes(_), _), ..)) => {
72+
Node::LetStmt(l) if matches!(l.pat.kind, PatKind::Binding(BindingMode(ByRef::Yes(_), _), ..)) => {
7373
return;
7474
},
7575
_ => false,

clippy_lints/src/methods/filter_next.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use clippy_utils::diagnostics::{span_lint, span_lint_and_then};
22
use clippy_utils::source::snippet;
33
use clippy_utils::ty::implements_trait;
4-
use rustc_ast::{BindingAnnotation, Mutability};
4+
use rustc_ast::{BindingMode, Mutability};
55
use rustc_errors::Applicability;
66
use rustc_hir as hir;
77
use rustc_lint::LateContext;
@@ -45,7 +45,7 @@ pub(super) fn check<'tcx>(
4545
span_lint_and_then(cx, FILTER_NEXT, expr.span, msg, |diag| {
4646
let (applicability, pat) = if let Some(id) = path_to_local(recv)
4747
&& let hir::Node::Pat(pat) = cx.tcx.hir_node(id)
48-
&& let hir::PatKind::Binding(BindingAnnotation(_, Mutability::Not), _, ident, _) = pat.kind
48+
&& let hir::PatKind::Binding(BindingMode(_, Mutability::Not), _, ident, _) = pat.kind
4949
{
5050
(Applicability::Unspecified, Some((pat.span, ident)))
5151
} else {

clippy_lints/src/methods/iter_kv_map.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use clippy_utils::diagnostics::{multispan_sugg, span_lint_and_sugg, span_lint_an
66
use clippy_utils::source::{snippet, snippet_with_applicability};
77
use clippy_utils::ty::is_type_diagnostic_item;
88
use clippy_utils::{pat_is_wild, sugg};
9-
use rustc_hir::{BindingAnnotation, Body, BorrowKind, ByRef, Expr, ExprKind, Mutability, Pat, PatKind};
9+
use rustc_hir::{BindingMode, Body, BorrowKind, ByRef, Expr, ExprKind, Mutability, Pat, PatKind};
1010
use rustc_lint::{LateContext, LintContext};
1111
use rustc_middle::ty;
1212
use rustc_span::{sym, Span};

clippy_lints/src/methods/iter_overeager_cloned.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use clippy_utils::diagnostics::span_lint_and_then;
22
use clippy_utils::source::snippet_opt;
33
use clippy_utils::ty::{implements_trait, is_copy};
4-
use rustc_ast::BindingAnnotation;
4+
use rustc_ast::BindingMode;
55
use rustc_errors::Applicability;
66
use rustc_hir::{Body, Expr, ExprKind, HirId, HirIdSet, PatKind};
77
use rustc_hir_typeck::expr_use_visitor::{Delegate, ExprUseVisitor, PlaceBase, PlaceWithHirId};
@@ -89,8 +89,7 @@ pub(super) fn check<'tcx>(
8989
}
9090

9191
match it.kind {
92-
PatKind::Binding(BindingAnnotation(_, Mutability::Mut), _, _, _)
93-
| PatKind::Ref(_, Mutability::Mut) => {
92+
PatKind::Binding(BindingMode(_, Mutability::Mut), _, _, _) | PatKind::Ref(_, Mutability::Mut) => {
9493
to_be_discarded = true;
9594
false
9695
},

clippy_lints/src/methods/iter_skip_next.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use clippy_utils::source::snippet;
33
use clippy_utils::{is_trait_method, path_to_local};
44
use rustc_errors::Applicability;
55
use rustc_hir as hir;
6-
use rustc_hir::{BindingAnnotation, Node, PatKind};
6+
use rustc_hir::{BindingMode, Node, PatKind};
77
use rustc_lint::LateContext;
88
use rustc_span::sym;
99

@@ -22,7 +22,7 @@ pub(super) fn check(cx: &LateContext<'_>, expr: &hir::Expr<'_>, recv: &hir::Expr
2222
if let Some(id) = path_to_local(recv)
2323
&& let Node::Pat(pat) = cx.tcx.hir_node(id)
2424
&& let PatKind::Binding(ann, _, _, _) = pat.kind
25-
&& ann != BindingAnnotation::MUT
25+
&& ann != BindingMode::MUT
2626
{
2727
application = Applicability::Unspecified;
2828
diag.span_help(

0 commit comments

Comments
 (0)