Skip to content

cz check skip merge messages #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manang opened this issue Feb 10, 2022 · 15 comments
Closed

cz check skip merge messages #483

manang opened this issue Feb 10, 2022 · 15 comments

Comments

@manang
Copy link
Contributor

manang commented Feb 10, 2022

Hi, is it possible to skip the check of messages like "merge branch"
So, the idea is that I want to skip the check of messages that match a regex.
Thanks

@Lee-W
Copy link
Member

Lee-W commented Feb 11, 2022

commitizen skips "merge" automatically. we're working on make it configurable, but this is not available as of now. another way is to configure through https://commitizen-tools.github.io/commitizen/customization/

@manang
Copy link
Contributor Author

manang commented Feb 11, 2022

I'm talking of cz check

this is an example of the commit message that bitbucket generates automatically:
`Merge: 792e33e 6bbfe0e
Author: Angelo Mantellini
Date: Thu Feb 10 20:24:26 2022 +0000

Pull request #74: Merge release bugfixes into devel

Merge in myteam/repo from master to devel

* commit '6bbfe0ee00765b1572050931da01c11ed79e6ab6': (2 commits)
  bump: version 1.9.0b0 → 1.9.0
  ...

`

cz check returns a different value than 0.
My problem is that in this case I can't customise the merge messages.
Thanks a lot for your answer
Angelo

@Lee-W
Copy link
Member

Lee-W commented Feb 14, 2022

That's a bit weird as this should be skipped here. Could you please provide the version you test on?

@manang
Copy link
Contributor Author

manang commented Feb 14, 2022

I'm checking why my "cz check" fails...thanks, I will report here..

@manang
Copy link
Contributor Author

manang commented Feb 14, 2022

ok, bitbucket merge commit is like:
Pull request #636: Merge release bugfixes into devel
so, the problem is there.
Thanks

@Lee-W
Copy link
Member

Lee-W commented Feb 14, 2022

hmmm... interesting. I'm thinking of using re to check to support more format. @woile what do you think?

@woile
Copy link
Member

woile commented Feb 14, 2022

I was not aware of this check, I think is worth adding Pull request to the list.
I think the ideal solution would be to have a setting users can set with commit messages to be skipped, besides the defaults

@manang
Copy link
Contributor Author

manang commented Feb 16, 2022

can I create pull request adding pull request to the list?
let me know, I can do today.
Thanks

@Lee-W
Copy link
Member

Lee-W commented Feb 17, 2022

@manang Yes, that would be most appreciated. Many thanks!

@manang
Copy link
Contributor Author

manang commented Feb 17, 2022

Hi, can you tell me why my pull request fails?
#487
thanks

@manang
Copy link
Contributor Author

manang commented Feb 17, 2022

I understood the problem, thanks

@manang
Copy link
Contributor Author

manang commented Feb 17, 2022

no, I don't understand, there is an error outside the part that I changed.
can you help me? thanks

@manang
Copy link
Contributor Author

manang commented Feb 17, 2022

how long do you need to create the debian package with the correction of cz?
Thanks

@woile
Copy link
Member

woile commented Feb 17, 2022

We do not maintain a debian package afaik.

The installation methods are listed here: https://commitizen-tools.github.io/commitizen/#installation

Looking at them, I'm thinking we should review them. Probably nowadays is best to use something like pipx, or pip install --user instead of sudo.
And maybe we can provide something like a binary using pyinstaller 🤔

@manang
Copy link
Contributor Author

manang commented Feb 17, 2022

ah, it is true...thanks a lot for your support

@manang manang closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants