Skip to content

Commit eb2971d

Browse files
committed
Config and Publish form improvements
1 parent 89047fd commit eb2971d

File tree

8 files changed

+30
-11
lines changed

8 files changed

+30
-11
lines changed

lib/actions.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ exports.quit = window_1.quit;
2121
var editor_paths_1 = require('./modules/editor-paths');
2222
exports.editorMarkdownOpen = editor_paths_1.editorMarkdownOpen;
2323
exports.editorTestOpen = editor_paths_1.editorTestOpen;
24+
exports.editorPjOpen = editor_paths_1.editorPjOpen;
2425
var core_coderoad_1 = require('core-coderoad');
2526
exports.alertOpen = core_coderoad_1.alertOpen;
2627
exports.alertClose = core_coderoad_1.alertClose;

lib/components/Config/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ var TutorialConfig = (function (_super) {
4242
}
4343
TutorialConfig.prototype.componentWillMount = function () {
4444
this.props.pjLoad();
45+
this.props.editorPjOpen();
4546
};
4647
TutorialConfig.prototype.componentDidMount = function () {
4748
var _this = this;
@@ -99,7 +100,7 @@ var TutorialConfig = (function (_super) {
99100
TutorialConfig = __decorate([
100101
react_redux_1.connect(function (state) { return ({
101102
packageJson: state.packageJson,
102-
}); }, { pjSave: actions_1.pjSave, pjLoad: actions_1.pjLoad, tutorialInit: actions_1.tutorialInit, routeSet: actions_1.routeSet }),
103+
}); }, { pjSave: actions_1.pjSave, pjLoad: actions_1.pjLoad, tutorialInit: actions_1.tutorialInit, routeSet: actions_1.routeSet, editorPjOpen: actions_1.editorPjOpen }),
103104
__metadata('design:paramtypes', [])
104105
], TutorialConfig);
105106
return TutorialConfig;

lib/components/Publish/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ var TutorialPublish = (function (_super) {
3939
}
4040
TutorialPublish.prototype.componentWillMount = function () {
4141
this.props.pjLoad();
42-
this.props.open;
42+
this.props.editorPjOpen();
4343
};
4444
TutorialPublish.prototype.componentDidMount = function () {
4545
var _this = this;
@@ -90,7 +90,7 @@ var TutorialPublish = (function (_super) {
9090
TutorialPublish = __decorate([
9191
react_redux_1.connect(function (state) { return ({
9292
packageJson: state.packageJson,
93-
}); }, { pjLoad: actions_1.pjLoad, pjSave: actions_1.pjSave }),
93+
}); }, { pjLoad: actions_1.pjLoad, pjSave: actions_1.pjSave, editorPjOpen: actions_1.editorPjOpen }),
9494
__metadata('design:paramtypes', [])
9595
], TutorialPublish);
9696
return TutorialPublish;

lib/modules/editor-paths/index.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,10 @@ function editorTestOpen(pageIndex, testIndex) {
2222
};
2323
}
2424
exports.editorTestOpen = editorTestOpen;
25+
function editorPjOpen() {
26+
return function (dispatch, getState) {
27+
var dir = getState().dir;
28+
dispatch(actions_1.editorOpen('package.json'));
29+
};
30+
}
31+
exports.editorPjOpen = editorPjOpen;

src/actions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export {
66
tutorialTaskAdd, tutorialHintAdd, tutorialActionAdd
77
} from './modules/tutorial';
88
export {windowToggle, quit} from './modules/window';
9-
export {editorMarkdownOpen, editorTestOpen} from './modules/editor-paths';
9+
export {editorMarkdownOpen, editorTestOpen, editorPjOpen} from './modules/editor-paths';
1010

1111
export {
1212
alertOpen, alertClose, alertReplay,

src/components/Config/index.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {Field, reduxForm, formValueSelector} from 'redux-form';
44
import MenuItem from 'material-ui/MenuItem';
55
import {Card, CardHeader} from 'material-ui/Card';
66
import RaisedButton from 'material-ui/RaisedButton';
7-
import {pjSave, pjLoad, tutorialInit, routeSet} from '../../actions';
7+
import {pjSave, pjLoad, tutorialInit, routeSet, editorPjOpen} from '../../actions';
88
import languageItems from './languageItems';
99
import runnerItems from './runnerItems';
1010
import {topElement} from '../TopPanel';
@@ -25,22 +25,24 @@ const styles = {
2525

2626
@connect(state => ({
2727
packageJson: state.packageJson,
28-
}), {pjSave, pjLoad, tutorialInit, routeSet })
28+
}), {pjSave, pjLoad, tutorialInit, routeSet, editorPjOpen })
2929
class TutorialConfig extends React.Component <{
3030
packageJson?: PackageJson,
3131
pjSave?: (pj: Tutorial.PJ) => Redux.ActionCreator,
3232
pjLoad?: () => Redux.ActionCreator,
3333
tutorialInit?: () => Redux.ActionCreator,
3434
routeSet?: (route: string) => Redux.ActionCreator,
3535
pristine?: boolean, submitting?: boolean, handleSubmit?: any,
36-
language?: string, invalid?: boolean, initialize?: any
36+
language?: string, invalid?: boolean, initialize?: any,
37+
editorPjOpen?: () => Redux.ActionCreator,
3738
}, {}> {
3839
refs: {
3940
[key: string]: (Element);
4041
name: HTMLInputElement;
4142
};
4243
componentWillMount() {
4344
this.props.pjLoad();
45+
this.props.editorPjOpen();
4446
}
4547
componentDidMount() {
4648
topElement.toggle(false);

src/components/Publish/index.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {Field, reduxForm} from 'redux-form';
44
import MenuItem from 'material-ui/MenuItem';
55
import {Card, CardHeader} from 'material-ui/Card';
66
import RaisedButton from 'material-ui/RaisedButton';
7-
import {pjSave, pjLoad, routeSet} from '../../actions';
7+
import {pjSave, pjLoad, routeSet, editorPjOpen} from '../../actions';
88
import {topElement} from '../TopPanel';
99
import textField from '../Form/textField';
1010
import validate from './validate';
@@ -22,16 +22,17 @@ const styles = {
2222

2323
@connect(state => ({
2424
packageJson: state.packageJson,
25-
}), {pjLoad, pjSave})
25+
}), {pjLoad, pjSave, editorPjOpen})
2626
class TutorialPublish extends React.Component<{
2727
packageJson?: any, pjSave?: (pj: PackageJson) => any,
2828
pristine?: boolean, submitting?: boolean, handleSubmit?: any,
2929
invalid?: boolean, initialize?: (values: Object) => any,
30-
pjLoad?: () => any
30+
pjLoad?: () => Redux.ActionCreator,
31+
editorPjOpen?: () => Redux.ActionCreator,
3132
}, {}> {
3233
componentWillMount() {
3334
this.props.pjLoad();
34-
this.props.open
35+
this.props.editorPjOpen();
3536
}
3637
componentDidMount() {
3738
topElement.toggle(false);

src/modules/editor-paths/index.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,10 @@ export function editorTestOpen(pageIndex: number, testIndex: number) {
3030
dispatch(editorOpen(filePath));
3131
};
3232
}
33+
34+
export function editorPjOpen() {
35+
return (dispatch, getState) => {
36+
const {dir} = getState();
37+
dispatch(editorOpen('package.json'));
38+
};
39+
}

0 commit comments

Comments
 (0)