Skip to content

Close editor under file dropdown doesn't work #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oonqt opened this issue Apr 26, 2019 · 8 comments · Fixed by #857
Closed

Close editor under file dropdown doesn't work #605

oonqt opened this issue Apr 26, 2019 · 8 comments · Fixed by #857
Labels
bug Something isn't working

Comments

@oonqt
Copy link
Contributor

oonqt commented Apr 26, 2019

File > Close Editor
Doesn't do anything.

@oonqt oonqt added the bug Something isn't working label Apr 26, 2019
@nol166
Copy link
Contributor

nol166 commented Apr 26, 2019

What OS/browser are you using? Are there any errors in the developer console? I can't seem to replicate this on Mac/Chrome

@oonqt
Copy link
Contributor Author

oonqt commented Apr 26, 2019

Tried on Windows/Chrome Mac/Chrome and Mac/Safari and none of them work. Maybe the functionality wasn't implemented for the browser?

@nol166
Copy link
Contributor

nol166 commented Apr 26, 2019

Currently, it is set to close the currently focused tab. I suppose with no tabs open it would appear to do nothing

@oonqt
Copy link
Contributor Author

oonqt commented Apr 26, 2019

Oh, I thought it was supposed to close the editor itself since the shortcut that It's linked to is Ctrl/Command + W which is the browser tab close shortcut on most browsers.

@nol166
Copy link
Contributor

nol166 commented Apr 26, 2019

That is a good point, we could definitely add that. Not sure if that would be desirable or not in the browser though.

@jaitaiwan
Copy link

I found that Close Editor worked in closing tabs, but of course there's no UI to tell you what it does when no tabs are open. I also found that Exit did nothing as well.

@gjrtimmer
Copy link

Currently, it is set to close the currently focused tab. I suppose with no tabs open it would appear to do nothing

I would like to suggest to change it. There is no option to logout, to force the login window.
What about the idea that, the File -> Exit forces a logout ?

And after the logout it may close the tab as described earlier in this thread.

Anyone any thought about this idea ?

@oonqt
Copy link
Contributor Author

oonqt commented May 17, 2019

Currently, it is set to close the currently focused tab. I suppose with no tabs open it would appear to do nothing

I would like to suggest to change it. There is no option to logout, to force the login window.
What about the idea that, the File -> Exit forces a logout ?

And after the logout it may close the tab as described earlier in this thread.

Anyone any thought about this idea ?

We're talking about the File -> Close Editor button here, but putting that aside, I think that setting File -> Exit to force a logout is a great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants