Skip to content

window.beforeclose prompt should not alert if running in app mode in chrome #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weikinhuang opened this issue Apr 23, 2019 · 1 comment
Closed

window.beforeclose prompt should not alert if running in app mode in chrome #574

weikinhuang opened this issue Apr 23, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@weikinhuang
Copy link

weikinhuang commented Apr 23, 2019 •
edited
Loading

  • code-server version: v1.939-vsc1.33.1
  • OS Version: linux server, osx client

Description

When running code-server in chrome app mode (ex sshcode) the window close prompt should not show up when doing ctrl+w, since running in app mode, it's able to overload the ctrl/cmd+w shortcut to actually close editor tabs

Steps to Reproduce

  1. Start code-server
  2. Open app with
/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --app=https://server-ip:8443
  1. Open several editor tabs
  2. cmd+w to close 1 tab
@weikinhuang weikinhuang added the bug Something isn't working label Apr 23, 2019
@nol166 nol166 mentioned this issue Apr 24, 2019
Closed
@code-asher
Copy link
Member

This was removed in v2. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable beforeUnload during app mode coder/code-server
3 participants
@weikinhuang @code-asher and others