remove references to gitops operator notifications controller

Author: scme0

charts/gitops-runtime/tests/external_argocd_test.yaml

@@ -257,35 +257,6 @@ tests:
             name: ARGO_CD_URL
             value: my-argocd-server:80
 
-  - it: gitops-operator Deployment should have a valid --argocd-repo-server arg set in notifications container
-    values:
-      - ./values/mandatory-values-ingress.yaml
-      - ./values/external-argocd-values.yaml
-    template: gitops-operator.yaml
-    documentSelector:
-      path: kind
-      value: Deployment
-    asserts:
-      - contains:
-          path: spec.template.spec.containers[1].args
-          content:
-            --argocd-repo-server=my-argocd-repo-server:8081
-
-  - it: gitops-operator Deployment should have a valid image set in notifications container
-    values:
-      - ./values/mandatory-values-ingress.yaml
-      - ./values/external-argocd-values.yaml
-    template: gitops-operator.yaml
-    documentSelector:
-      path: kind
-      value: Deployment
-    set:
-      global.external-argo-cd.server.image.tag: v1.2.3
-    asserts:
-      - equal:
-          path: spec.template.spec.containers[1].image
-          value: quay.io/argoproj/argocd:v1.2.3
-
   - it: event-reporter ConfigMap should have valid ArgoCd URL
     template: event-reporter.yaml
     documentSelector:

charts/gitops-runtime/tests/gitops-controller-misc_test.yaml

@@ -274,30 +274,6 @@ tests:
         name: leader-election
         any: true
 
-- it: argocd and workflows overrides for notifications controller
-  template: gitops-operator.yaml
-  documentSelector:
-    path: kind
-    value: Deployment
-  values:
-  - ./values/mandatory-values.yaml
-  set:
-    argo-cd.global.image:
-      repository: "argocd/test"
-      tag: "test"
-    argo-cd.fullnameOverride: myargocd
-    argo-cd.repoServer.service.port: 9080
-    argo-workflows.enabled: true
-    argo-workflows.fullnameOverride: argo-test
-    argo-workflows.server.secure: false
-  asserts:
-  - equal:
-      path: spec.template.spec.containers[1].image
-      value: argocd/test:test
-  - contains:
-      path: spec.template.spec.containers[1].args
-      content: --argocd-repo-server=myargocd-repo-server:9080
-
 - it: argocd and workflows overrides for manager
   template: gitops-operator.yaml
   documentSelector:
@@ -324,35 +300,6 @@ tests:
         name: ARGO_CD_URL
         value: myargocd-server:80/some-path
 
-- it: contains all resources for notifications controller
-  template: gitops-operator.yaml
-  values:
-  - ./values/mandatory-values.yaml
-  set:
-    gitops-operator.argoCdNotifications.cm.name: "test-notifications-cm"
-    gitops-operator.argoCdNotifications.secret.name: "test-notifications-secret"
-  asserts:
-  - containsDocument:
-      kind: ConfigMap
-      apiVersion: v1
-      name: test-notifications-cm
-      any: true
-  - containsDocument:
-      kind: Secret
-      apiVersion: v1
-      name: test-notifications-secret
-      any: true
-  - containsDocument:
-      kind: ClusterRole
-      apiVersion: rbac.authorization.k8s.io/v1
-      name: codefresh-gitops-operator-notifications
-      any: true
-  - containsDocument:
-      kind: ClusterRoleBinding
-      apiVersion: rbac.authorization.k8s.io/v1
-      name: codefresh-gitops-operator-notifications
-      any: true
-
 - it: uses explicit ARGO_CD_URL instead of value defined by argo-cd settings
   template: gitops-operator.yaml
   documentSelector:

charts/gitops-runtime/values.yaml

@@ -673,15 +673,6 @@ gitops-operator:
     annotations: {}
     name: "gitops-operator-controller-manager"
 
-  # -- Builtin notifications controller used by gitops-operator for promotion related notifications
-  argoCdNotifications:
-    # -- If set to true allows to override notifications image used by the gitops operator. When set to false the version of ArgoCD will be set to the version used for all other ArgoCD components.
-    imageOverride: false
-    # -- Set image.repository and image.tag notifications image used by the gitops operator. Ignored unless imageOverride is set to true.
-    image: {}
-    # -- Resources for notifications controller used by gitops-operator.
-    resources: {}
-
   imagePullSecrets: []
   nameOverride: ""
   fullnameOverride: ""