From 0033bbe5f7ef633f9399cfdaeb980b922f74ce7c Mon Sep 17 00:00:00 2001
From: Luc Kury <luc.kury@unibas.ch>
Date: Thu, 15 Aug 2019 15:32:42 +0200
Subject: [PATCH 1/2] Used reject instead of throw with 'new Error(...)' to
 avoid node crashing.

---
 index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/index.js b/index.js
index 2b6fd57..69a5977 100644
--- a/index.js
+++ b/index.js
@@ -40,7 +40,7 @@ class ResembleHelper extends Helper {
         if (err) {
           reject(err);
         } else {
-          if(!data.isSameDimensions) throw new Error("The images are not of same dimensions. Please use images of same dimensions so as to avoid any unexpected results.")
+          if(!data.isSameDimensions) reject(new Error("The images are not of same dimensions. Please use images of same dimensions so as to avoid any unexpected results."));
           resolve(data);
           if (data.misMatchPercentage >= tolerance) {
             mkdirp(getDirName(this.config.diffFolder + diffImage), function (err) {

From d9164214daf8c698313c306640181bb5ed6d17f7 Mon Sep 17 00:00:00 2001
From: Luc Kury <luc.kury@unibas.ch>
Date: Thu, 15 Aug 2019 15:41:01 +0200
Subject: [PATCH 2/2] Removed redundant function parameters.

---
 index.js | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/index.js b/index.js
index 69a5977..813eb95 100644
--- a/index.js
+++ b/index.js
@@ -16,15 +16,14 @@ class ResembleHelper extends Helper {
   /**
    * Compare Images
    * 
-   * @param image1
-   * @param image2
+   * @param image
    * @param diffImage
    * @param options
    * @returns {Promise<any | never>}
    */
-  async _compareImages(image1, image2, diffImage, options) {
-    image1 = this.config.baseFolder + image1;
-    image2 = this.config.screenshotFolder + image2;
+  async _compareImages(image, diffImage, options) {
+    const image1 = this.config.baseFolder + image;
+    const image2 = this.config.screenshotFolder + image;
 
     return new Promise((resolve, reject) => {
       
@@ -63,14 +62,13 @@ class ResembleHelper extends Helper {
 
   /**
    *
-   * @param image1
+   * @param image
    * @param options
    * @returns {Promise<*>}
    */
-  async _fetchMisMatchPercentage(image1, options) {
-    const image2 = image1;
-    const diffImage = "Diff_" + image1.split(".")[0];
-    const result = this._compareImages(image1, image2, diffImage, options);
+  async _fetchMisMatchPercentage(image, options) {
+    const diffImage = "Diff_" + image.split(".")[0];
+    const result = this._compareImages(image, diffImage, options);
     const data = await Promise.resolve(result);
     return data.misMatchPercentage;
   }