Skip to content

resemble.js Output Settings working? #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
armandsz22 opened this issue Oct 4, 2022 · 5 comments
Closed

resemble.js Output Settings working? #118

armandsz22 opened this issue Oct 4, 2022 · 5 comments
Labels
1.9.7 Scope for 1.9.7

Comments

@armandsz22
Copy link

Hi, is this option resemble.js Output Settings working?
Tried to follow instructions, tried ignoredBox. No effect. I want to use ignoredBoxes.
const outputSettings = {
ignoredBox: { left: 184, top: 231, right: 284, bottom: 254}
};
I.seeVisualDiff("Reporing_TimeCorrection-CorrectionOfDetails.png", {prepareBaseImage: baseImage.desktopPages.reporting.timeCorrection, tolerance: 0.00, outputSettings:outputSettings})

@armandsz22 armandsz22 changed the title esemble.js Output Settings working? resemble.js Output Settings working? Oct 7, 2022
@puneet0191 puneet0191 added the 1.9.7 Scope for 1.9.7 label Dec 8, 2022
@saadichouaib
Copy link
Contributor

I have the same issue. After debugging I can see the outputSettings object become empty here :

Line 81

https://github.com/codeceptjs/codeceptjs-resemblehelper/blob/master/index.js 

if (options.outputSettings) {
        options.outputSettings = {};
      }

@puneet0191 do you agree ?

@saadichouaib
Copy link
Contributor

@armandsz22

I just added a fix and it's approved : #120

If you want to try it without waiting for next release you can use directly my commit in your project :

"codeceptjs-resemblehelper": "git://github.com:codeceptjs/codeceptjs-resemblehelper.git#14d454bcb5b0d0d9be37f2ab1b7540050b896f36",

@saadichouaib
Copy link
Contributor

@puneet0191 we can close this one since its fix was merged #120

@puneet0191
Copy link
Member

@saadichouaib will close after release, we are testing the new branch right now, will make release next week. cc @sharath2106

@sharath2106
Copy link
Collaborator

We have released the latest version (1.9.7) of the library yesterday. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.7 Scope for 1.9.7
Projects
None yet
Development

No branches or pull requests

4 participants