Skip to content

Commit f174992

Browse files
committed
Fix low hanging fruit for initial PR review
1 parent 03a3814 commit f174992

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/code42cli/cmds/legal_hold.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def show(
137137
devices_dataframe = _merge_matter_members_with_devices(
138138
state.sdk, user_dataframe
139139
)
140-
if len(devices_dataframe.index) > 0:
140+
if len(devices_dataframe.index):
141141
echo("\nMatter Members and Devices:\n")
142142
click.echo(devices_dataframe.to_csv())
143143
echo(_print_storage_by_org(devices_dataframe))
@@ -264,7 +264,7 @@ def _print_matter_members(username_list, member_type="active"):
264264

265265

266266
def _merge_matter_members_with_devices(sdk, user_dataframe):
267-
devices_generator = sdk.devices.get_all(active="true", include_backup_usage=True)
267+
devices_generator = sdk.devices.get_all(active=True, include_backup_usage=True)
268268
device_list = _get_total_archive_bytes_per_device(devices_generator)
269269
devices_dataframe = DataFrame.from_records(
270270
device_list,
@@ -295,13 +295,13 @@ def _build_user_dataframe(users):
295295

296296
def _get_total_archive_bytes_per_device(devices_generator):
297297
device_list = [device for page in devices_generator for device in page["computers"]]
298-
for i in device_list:
299-
archive_bytes = [archive["archiveBytes"] for archive in i["backupUsage"]]
300-
i["archiveBytes"] = sum(archive_bytes)
298+
for device in device_list:
299+
archive_bytes = [archive["archiveBytes"] for archive in device["backupUsage"]]
300+
device["archiveBytes"] = sum(archive_bytes)
301301
return device_list
302302

303303

304-
def _print_storage_by_org(devices_dataframe):
304+
def _get_storage_by_org(devices_dataframe):
305305
echo("\nLegal Hold Storage by Org\n")
306306
devices_dataframe = devices_dataframe.filter(["orgId", "archiveBytes"])
307307
return devices_dataframe.groupby("orgId").sum()

0 commit comments

Comments
 (0)